From: Ingo Molnar <mingo@elte.hu>
To: Adrian Bunk <bunk@stusta.de>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-kernel@vger.kernel.org, "Rafael J. Wysocki" <rjw@sisk.pl>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: Ingo, no more kconfig patches
Date: Sat, 3 May 2008 21:14:45 +0200 [thread overview]
Message-ID: <20080503191445.GF5292@elte.hu> (raw)
In-Reply-To: <20080501115923.GX29330@cs181133002.pp.htv.fi>
* Adrian Bunk <bunk@stusta.de> wrote:
> On Thu, May 01, 2008 at 04:52:34AM +0200, Ingo Molnar wrote:
> >
> > * Adrian Bunk <bunk@kernel.org> wrote:
> >
> > > I would really appreciate it if you could send the error message
> > > and the .config but not quick kconfig patches that are often wrong
> > > and that you try to push through the maintainers as you tried
> > > here.
> >
> > hey, sorry about invading your turf of trivial patches ;) I dont see
> > it as a problem that the thought process and the initial patch is
> > incomplete and ad-hoc. My preference is to work with people out in
> > the open, even on trivial issues. Dmitry is a capable maintainer who
> > understands his code very well and he'll resist me if i'm full of
> > it. Just like i resisted you when you were full of it. That's what
> > maintainers do, their job is to know their code.
> >
> > And, occasionally, as in this case, i might end up being faced with
> > a bug in the code i maintain ;)
>
> You completely miss my point.
>
> You wrongly (and loudly) blamed Dmitry for something you broke
> yourself.
i didnt. Read what i wrote:
|| no, you are wrong, read the current Kconfig rules again. If the user
|| can create a .config that does not build, it is driver breakage. It
|| always was, and has been in the past 15 years.
||
|| Kconfig might be extended to make dependencies easier to manage for
|| developers but until that is implemented you have to craft your
|| driver's dependencies with the current tools in a way that doesnt
|| break the build.
and that's exactly what happens with Roman's patch: a Kconfig subsystem
design bug (its inability to properly propagate the dependencies of
select's) is worked around in the driver space: by the LEDS_CORE driver
config introduction and no user-visible.
Roman's patch is obviously cleaner than my hack (i just fixed a single
instantiation of the problem, while he changed the LEDS driver
dependency structure), but it's still a workaround for a Kconfig
subsystem bug and the same problem could reoccur elsewhere. It could hit
anytime dual dependencies are introduced in a driver accidentally.
As Sam said it, fixing that Kconfig design bug would be "nice" - but
unfortunately the Kconfig subsystem is not actively developed anymore.
Would you like to volunteer for that? It would be a _very_ useful
contribution. One such fix could avoid hundreds or even thousands of
trivial problems in the future - it could avoid having to make hundreds
or thousands of trivial patches in the future.
Ingo
next prev parent reply other threads:[~2008-05-03 19:15 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-30 20:03 [patch] input: JOYSTICK_XPAD build fix Ingo Molnar
2008-04-30 21:02 ` Dmitry Torokhov
2008-04-30 21:13 ` Ingo Molnar
2008-04-30 23:01 ` Ingo, no more kconfig patches Adrian Bunk
2008-05-01 1:17 ` Ingo Molnar
2008-05-01 1:37 ` Adrian Bunk
2008-05-01 2:06 ` Ingo Molnar
2008-05-01 2:12 ` Adrian Bunk
2008-05-01 2:52 ` Ingo Molnar
2008-05-01 11:59 ` Adrian Bunk
2008-05-03 19:14 ` Ingo Molnar [this message]
2008-05-03 19:17 ` Ingo Molnar
2008-05-03 20:24 ` Adrian Bunk
2008-05-03 21:03 ` Ingo Molnar
2008-05-03 21:24 ` Adrian Bunk
2008-05-03 21:38 ` Sam Ravnborg
2008-05-03 22:07 ` Adrian Bunk
2008-05-04 7:36 ` Sam Ravnborg
2008-05-04 7:49 ` Adrian Bunk
2008-05-03 21:52 ` Ingo Molnar
2008-05-03 22:03 ` Adrian Bunk
2008-05-04 3:54 ` Valdis.Kletnieks
2008-05-04 7:47 ` Adrian Bunk
2008-05-03 23:22 ` Thomas Gleixner
2008-05-04 0:34 ` Adrian Bunk
2008-05-03 21:17 ` Krzysztof Halasa
2008-05-03 21:47 ` Adrian Bunk
2008-05-03 22:13 ` Krzysztof Halasa
2008-05-03 22:29 ` Adrian Bunk
2008-05-03 23:37 ` Krzysztof Halasa
2008-05-04 0:49 ` Adrian Bunk
2008-05-04 12:18 ` Krzysztof Halasa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080503191445.GF5292@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=bunk@stusta.de \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.