All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@kernel.org>
To: Valdis.Kletnieks@vt.edu
Cc: Ingo Molnar <mingo@elte.hu>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	linux-kernel@vger.kernel.org, "Rafael J. Wysocki" <rjw@sisk.pl>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: Ingo, no more kconfig patches
Date: Sun, 4 May 2008 10:47:08 +0300	[thread overview]
Message-ID: <20080504074708.GD5838@cs181133002.pp.htv.fi> (raw)
In-Reply-To: <19743.1209873251@turing-police.cc.vt.edu>

On Sat, May 03, 2008 at 11:54:11PM -0400, Valdis.Kletnieks@vt.edu wrote:
> On Sun, 04 May 2008 01:03:30 +0300, Adrian Bunk said:
> > On Sat, May 03, 2008 at 11:52:14PM +0200, Ingo Molnar wrote:
> 
> > > My larger point is that this kconfig tool bug breeds a constant stream 
> > > of avoidable breakages, which causes lost manpower and causes a stream 
> > > of trivial patches hindering maintainers all around the tree. Because 
> > > every such trivial patch has to be reviewed, tested, it clogs the commit 
> > > logs, etc.
> > > 
> > > So the more trivial patches we _avoid_ having to do in the future, the 
> > > better. I'm not sure why you are even arguing against this this rather 
> > > simple point - your arguments are rather hard to understand. Wouldnt you 
> > > be happier if a whole category of trivial breakages was avoided and if 
> > > you didnt have to deal with and waste your time on that category of 
> > > trivial patches anymore?
> > > 
> > > Most of the time reoccuring trivial patches are an indicator of some 
> > > deeper structural problem - as in this case.
> > 
> > Your conclusions are based on an assumption that isn't true.
> > 
> > "trivial patches" are the patches you send.
> > 
> > But they are often bogus.
> > 
> > Fixing these issues properly often requires a deeper understanding of 
> > both kconfig and the dependencies of the underlying code.
> 
> I suspect that Ingo is however correct

Ingo claims the problem was trivial since the patches were trivial.

But fact is they aren't trivial - as you can e.g. see on Ingos patch 
that started this thread, and that was for the completely wrong place.

> - although a *proper* fix of one of
> these bugs requires human-intelligence to figure out what's *really* intended,
> the kconfig program *does* have enough information available to issue a a clear
> warning:
> 
> "Yo doodz - I don't know *what* you intended here, but this SELECT is just
> waiting to sink its teeth into somebody's posterior.  You might want to fix it
> somehow before somebody needs rabies shots..."
>...

And what do you want to do in such a case?

Kconfig is a user interface, and we actually need such cases you want to 
warn for for getting a good UI.

We already know what can cause problems.

But as far as I know there are no such problems users actually ran into 
in recent stable kernels - and most of the problems (like the one in 
this thread) are pathological cornercases you only see with randconfig.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


  reply	other threads:[~2008-05-04  7:48 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-30 20:03 [patch] input: JOYSTICK_XPAD build fix Ingo Molnar
2008-04-30 21:02 ` Dmitry Torokhov
2008-04-30 21:13   ` Ingo Molnar
2008-04-30 23:01     ` Ingo, no more kconfig patches Adrian Bunk
2008-05-01  1:17       ` Ingo Molnar
2008-05-01  1:37         ` Adrian Bunk
2008-05-01  2:06           ` Ingo Molnar
2008-05-01  2:12             ` Adrian Bunk
2008-05-01  2:52       ` Ingo Molnar
2008-05-01 11:59         ` Adrian Bunk
2008-05-03 19:14           ` Ingo Molnar
2008-05-03 19:17             ` Ingo Molnar
2008-05-03 20:24             ` Adrian Bunk
2008-05-03 21:03               ` Ingo Molnar
2008-05-03 21:24                 ` Adrian Bunk
2008-05-03 21:38                   ` Sam Ravnborg
2008-05-03 22:07                     ` Adrian Bunk
2008-05-04  7:36                       ` Sam Ravnborg
2008-05-04  7:49                         ` Adrian Bunk
2008-05-03 21:52                   ` Ingo Molnar
2008-05-03 22:03                     ` Adrian Bunk
2008-05-04  3:54                       ` Valdis.Kletnieks
2008-05-04  7:47                         ` Adrian Bunk [this message]
2008-05-03 23:22                   ` Thomas Gleixner
2008-05-04  0:34                     ` Adrian Bunk
2008-05-03 21:17               ` Krzysztof Halasa
2008-05-03 21:47                 ` Adrian Bunk
2008-05-03 22:13                   ` Krzysztof Halasa
2008-05-03 22:29                     ` Adrian Bunk
2008-05-03 23:37                       ` Krzysztof Halasa
2008-05-04  0:49                         ` Adrian Bunk
2008-05-04 12:18                           ` Krzysztof Halasa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080504074708.GD5838@cs181133002.pp.htv.fi \
    --to=bunk@kernel.org \
    --cc=Valdis.Kletnieks@vt.edu \
    --cc=akpm@linux-foundation.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=rjw@sisk.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.