Re: [PATCH] v4l/dvb: Add linux/version.h include as KERNEL_VERSION macro is used.

Re: [PATCH] v4l/dvb: Add linux/version.h include as KERNEL_VERSION macro is used.

[Arjan van de Ven]

On Thu, 1 May 2008 20:05:41 +0200
Andres Freund <andres@anarazel.de> wrote:

> Whitout this build fails with unknown macro on 
> e4c576b911e364737b1bf4f5bfdab1c440713f26
> 
> Hopefully I did everything correct, as this is my first usage of git
> beside checking out. Also its my first patch on lk....
> 
> Is an Signed-off-by already appropriate with such an trivial change?
> 

Hi,

maybe the real fix is to remove the use of KERNEL_VERSION in this code??

Greetings,
   Arjan van de Ven

[PATCH] v4l/dvb: Add linux/version.h include as KERNEL_VERSION macro is used.

[Andres Freund]

Whitout this build fails with unknown macro on 
e4c576b911e364737b1bf4f5bfdab1c440713f26

Hopefully I did everything correct, as this is my first usage of git beside 
checking out. Also its my first patch on lk....

Is an Signed-off-by already appropriate with such an trivial change?

Signed-off-by: Andres Freund <andres@anarazel.de>
---
 drivers/media/radio/radio-maxiradio.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/media/radio/radio-maxiradio.c 
b/drivers/media/radio/radio-maxiradio.c
index 0133ecf..e170fcd 100644
--- a/drivers/media/radio/radio-maxiradio.c
+++ b/drivers/media/radio/radio-maxiradio.c
@@ -34,6 +34,7 @@
 
 
 #include <linux/module.h>
+#include <linux/version.h>
 #include <linux/init.h>
 #include <linux/ioport.h>
 #include <linux/delay.h>

Re: [PATCH] v4l/dvb: Add linux/version.h include as KERNEL_VERSION macro is used.

[Adrian Bunk]

On Thu, May 01, 2008 at 08:05:41PM +0200, Andres Freund wrote:
> Whitout this build fails with unknown macro on 
> e4c576b911e364737b1bf4f5bfdab1c440713f26
> 
> Hopefully I did everything correct, as this is my first usage of git beside 
> checking out. Also its my first patch on lk....
> 
> Is an Signed-off-by already appropriate with such an trivial change?

Yes.

> Signed-off-by: Andres Freund <andres@anarazel.de>
> ---
>  drivers/media/radio/radio-maxiradio.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/media/radio/radio-maxiradio.c 
> b/drivers/media/radio/radio-maxiradio.c
> index 0133ecf..e170fcd 100644
> --- a/drivers/media/radio/radio-maxiradio.c
> +++ b/drivers/media/radio/radio-maxiradio.c
> @@ -34,6 +34,7 @@
>  
>  
>  #include <linux/module.h>
> +#include <linux/version.h>
>  #include <linux/init.h>
>  #include <linux/ioport.h>
>  #include <linux/delay.h>

The #include is already there a dozen lines below.

It seems to be missing in another file.

Can you send the error message and your .config?

Thanks
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: [PATCH] v4l/dvb: Add linux/version.h include as KERNEL_VERSION macro is used.

[Andres Freund]

On Thursday 01 May 2008, Adrian Bunk wrote in "Re: [PATCH] v4l/dvb: Add 
linux/version.h include as KERNEL_VERSION macro is used.":
> The #include is already there a dozen lines below.
Hm. Strange.
It fixed a build error for me. Will retest and report back.

Andres

Re: [PATCH] v4l/dvb: Add linux/version.h include as KERNEL_VERSION macro is used.

[Adrian Bunk]

On Thu, May 01, 2008 at 09:36:02PM +0200, Andres Freund wrote:
> On Thursday 01 May 2008, Adrian Bunk wrote in "Re: [PATCH] v4l/dvb: Add 
> linux/version.h include as KERNEL_VERSION macro is used.":
> > The #include is already there a dozen lines below.
> Hm. Strange.
> It fixed a build error for me. Will retest and report back.

That's why I said:

It seems to be missing in another file.
Can you send the error message and your .config?

> Andres

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: [PATCH] v4l/dvb: Add linux/version.h include as KERNEL_VERSION macro is used.

[Andres Freund]

[-- Attachment #1: Type: text/plain, Size: 461 bytes --]

On Thursday 01 May 2008, Adrian Bunk wrote in "Re: [PATCH] v4l/dvb: Add 
linux/version.h include as KERNEL_VERSION macro is used.":

> > Hm. Strange.
> > It fixed a build error for me. Will retest and report back.
> It seems to be missing in another file.
> Can you send the error message and your .config?
Unfortunately no. I overwrote the .config with some other config and I couldnt 
reproduce the failure so far with a new config.
Sorry

Andres

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: [PATCH] v4l/dvb: Add linux/version.h include as KERNEL_VERSION macro is used.

[Mauro Carvalho Chehab]

On Thu, 1 May 2008, Arjan van de Ven wrote:

> On Thu, 1 May 2008 20:05:41 +0200
> Andres Freund <andres@anarazel.de> wrote:
>
>> Whitout this build fails with unknown macro on
>> e4c576b911e364737b1bf4f5bfdab1c440713f26
>>
>> Hopefully I did everything correct, as this is my first usage of git
>> beside checking out. Also its my first patch on lk....
>>
>> Is an Signed-off-by already appropriate with such an trivial change?
>>
>
> Hi,
>
> maybe the real fix is to remove the use of KERNEL_VERSION in this code??

This is one of the rare cases where the usage of KERNEL_VERSION is valid. 
This is the code there:

#include <linux/version.h>      /* for KERNEL_VERSION MACRO     */
#define RADIO_VERSION KERNEL_VERSION(0,7,7)

This macro is required by V4L API to indicate the module version.

One possible solution would be to fork KERNEL_VERSION into something like 
V4L_VERSION, and replace it on drivers/media/video/* and 
drivers/media/radio/*.

Yet, I'm not sure if it would be nice to have two macros with the same 
code.

-- 
Cheers,
Mauro Carvalho Chehab
http://linuxtv.org
mchehab@infradead.org