From: Robert Millan <rmh@aybabtu.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: Please support installation on Xen virtual block devices
Date: Wed, 7 May 2008 14:43:26 +0200 [thread overview]
Message-ID: <20080507124326.GA16492@thorin> (raw)
In-Reply-To: <1210109603.20736.14.camel@dv>
On Tue, May 06, 2008 at 05:33:23PM -0400, Pavel Roskin wrote:
> On Tue, 2008-05-06 at 16:29 +0100, Ian Campbell wrote:
> > Any comments on this patch?
>
> It's basically OK, bug please provide the GNU style ChangeLog entry.
> The second part of the patch doesn't need preprocessor conditionals
> because it's already compiled for Linux only. Please use tabs for
> indentation rather than 8 spaces. The innermost block is indented two
> spaces too far.
Ian, it looks like you copied this style from existing code. Is that so?
In that case, I don't think the indentation issue concerns your patch (if we
have to fix indentation, we could just do it in the whole file).
--
Robert Millan
<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call… if you are unable to speak?
(as seen on /.)
next prev parent reply other threads:[~2008-05-07 12:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-24 19:28 Please support installation on Xen virtual block devices Ian Campbell
2008-05-06 15:29 ` Ian Campbell
2008-05-06 21:33 ` Pavel Roskin
2008-05-07 12:43 ` Robert Millan [this message]
2008-05-07 17:33 ` Pavel Roskin
2008-05-07 18:51 ` Ian Campbell
2008-05-07 20:49 ` Pavel Roskin
2008-05-07 21:07 ` Ian Campbell
2008-05-09 12:53 ` Robert Millan
2008-05-10 12:03 ` Ian Campbell
2008-05-11 5:35 ` Pavel Roskin
2008-05-12 15:33 ` Robert Millan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080507124326.GA16492@thorin \
--to=rmh@aybabtu.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.