From: Pavel Roskin <proski@gnu.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: Please support installation on Xen virtual block devices
Date: Wed, 07 May 2008 16:49:28 -0400 [thread overview]
Message-ID: <1210193368.17396.7.camel@dv> (raw)
In-Reply-To: <1210186300.18090.16.camel@localhost.localdomain>
On Wed, 2008-05-07 at 19:51 +0100, Ian Campbell wrote:
> On Wed, 2008-05-07 at 13:33 -0400, Pavel Roskin wrote:
> > Apparently, it was copied from the code that was inside an extra "for"
> > loop. Anyway, it's a very minor issue, and I would just apply the patch
> > right now, but I prefer not to write changelog entries for others.
>
> Sorry about that. An updated version is attached with changelog and
> (hopefully) correct indentation.
>
> I wasn't sure about the pre-processor conditionals, there seems to be
> lots of existing ifdef __linux__ in there and the device path is pretty
> Linux specific. I merged it into the one above but if you want them gone
> I will redo.
Applied.
It looks like you missed changes to linux_find_partition(). I'll fix it
myself (if indeed necessary).
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2008-05-07 20:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-24 19:28 Please support installation on Xen virtual block devices Ian Campbell
2008-05-06 15:29 ` Ian Campbell
2008-05-06 21:33 ` Pavel Roskin
2008-05-07 12:43 ` Robert Millan
2008-05-07 17:33 ` Pavel Roskin
2008-05-07 18:51 ` Ian Campbell
2008-05-07 20:49 ` Pavel Roskin [this message]
2008-05-07 21:07 ` Ian Campbell
2008-05-09 12:53 ` Robert Millan
2008-05-10 12:03 ` Ian Campbell
2008-05-11 5:35 ` Pavel Roskin
2008-05-12 15:33 ` Robert Millan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1210193368.17396.7.camel@dv \
--to=proski@gnu.org \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.