From: Pavel Roskin <proski@gnu.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: Please support installation on Xen virtual block devices
Date: Tue, 06 May 2008 17:33:23 -0400 [thread overview]
Message-ID: <1210109603.20736.14.camel@dv> (raw)
In-Reply-To: <1210087760.30746.44.camel@zakaz.uk.xensource.com>
On Tue, 2008-05-06 at 16:29 +0100, Ian Campbell wrote:
> Any comments on this patch?
It's basically OK, bug please provide the GNU style ChangeLog entry.
The second part of the patch doesn't need preprocessor conditionals
because it's already compiled for Linux only. Please use tabs for
indentation rather than 8 spaces. The innermost block is indented two
spaces too far.
In the long term, I would prefer that we don't need device.map at all.
This is discussed in a separate thread.
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2008-05-06 21:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-24 19:28 Please support installation on Xen virtual block devices Ian Campbell
2008-05-06 15:29 ` Ian Campbell
2008-05-06 21:33 ` Pavel Roskin [this message]
2008-05-07 12:43 ` Robert Millan
2008-05-07 17:33 ` Pavel Roskin
2008-05-07 18:51 ` Ian Campbell
2008-05-07 20:49 ` Pavel Roskin
2008-05-07 21:07 ` Ian Campbell
2008-05-09 12:53 ` Robert Millan
2008-05-10 12:03 ` Ian Campbell
2008-05-11 5:35 ` Pavel Roskin
2008-05-12 15:33 ` Robert Millan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1210109603.20736.14.camel@dv \
--to=proski@gnu.org \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.