From: Christoph Hellwig <hch@lst.de>
To: Robert Richter <robert.richter@amd.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
linux-kernel <linux-kernel@vger.kernel.org>,
linuxppc-dev@ozlabs.org,
oprofile-list <oprofile-list@lists.sourceforge.net>,
cbe-oss-dev@ozlabs.org, Carl Love <cel@us.ibm.com>
Subject: Re: [Cbe-oss-dev] [PATCH] Updated: Reworked Cell OProfile: SPU mutex lock fix
Date: Sat, 10 May 2008 21:07:59 +0200 [thread overview]
Message-ID: <20080510190759.GA16275@lst.de> (raw)
In-Reply-To: <20080509150759.GL24041@erda.amd.com>
> > + /* Ignoring the return value from the unregister
> > + * call. A failed return value simply says there
> > + * was no registered event. Hence there will not
> > + * be any calls to process a switch event that
> > + * could cause a problem.
> > + */
> > + spu_switch_event_unregister(&spu_active);
>
> Better to use this here, to show the return value is ignored:
>
> (void)spu_switch_event_unregister(...)
Actually Linux style is to not add those casts. But I don't think we
all the notifier_chain_unregister funtion should return error at all,
we should probably fix that up in the core code.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Robert Richter <robert.richter@amd.com>
Cc: Carl Love <cel@us.ibm.com>,
linuxppc-dev@ozlabs.org,
oprofile-list <oprofile-list@lists.sourceforge.net>,
cbe-oss-dev@ozlabs.org, Arnd Bergmann <arnd@arndb.de>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [Cbe-oss-dev] [PATCH] Updated: Reworked Cell OProfile: SPU mutex lock fix
Date: Sat, 10 May 2008 21:07:59 +0200 [thread overview]
Message-ID: <20080510190759.GA16275@lst.de> (raw)
In-Reply-To: <20080509150759.GL24041@erda.amd.com>
> > + /* Ignoring the return value from the unregister
> > + * call. A failed return value simply says there
> > + * was no registered event. Hence there will not
> > + * be any calls to process a switch event that
> > + * could cause a problem.
> > + */
> > + spu_switch_event_unregister(&spu_active);
>
> Better to use this here, to show the return value is ignored:
>
> (void)spu_switch_event_unregister(...)
Actually Linux style is to not add those casts. But I don't think we
all the notifier_chain_unregister funtion should return error at all,
we should probably fix that up in the core code.
next prev parent reply other threads:[~2008-05-10 19:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-30 20:35 [Cbe-oss-dev] [PATCH] Updated: Reworked Cell OProfile: SPU mutex lock fix Carl Love
2008-04-30 20:35 ` Carl Love
2008-05-07 16:54 ` Jochen Roth
2008-05-07 16:54 ` Jochen Roth
2008-05-07 17:09 ` Carl Love
2008-05-07 17:09 ` Carl Love
2008-05-08 7:50 ` Jochen Roth
2008-05-08 7:50 ` Jochen Roth
[not found] ` <1210199526.7726.43.camel@carll-linux-desktop>
[not found] ` <4822B03B.5060509@linux.vnet.ibm.com>
2008-05-08 20:47 ` Carl Love
2008-05-09 15:07 ` Robert Richter
2008-05-09 15:07 ` Robert Richter
2008-05-10 19:07 ` Christoph Hellwig [this message]
2008-05-10 19:07 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080510190759.GA16275@lst.de \
--to=hch@lst.de \
--cc=arnd@arndb.de \
--cc=cbe-oss-dev@ozlabs.org \
--cc=cel@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=oprofile-list@lists.sourceforge.net \
--cc=robert.richter@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.