From: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: jeff@garzik.org, linux-ide@vger.kernel.org, liml@rtr.ca,
Tejun Heo <htejun@gmail.com>
Subject: Re: [PATCH 3/5] libata: improve EH retry delay handling
Date: Mon, 19 May 2008 19:33:11 +0100 [thread overview]
Message-ID: <20080519193311.01b5b928@core> (raw)
In-Reply-To: <1211217475951-git-send-email-htejun@gmail.com>
On Tue, 20 May 2008 02:17:52 +0900
Tejun Heo <htejun@gmail.com> wrote:
> EH retries were delayed by 5 seconds to ensure that resets don't occur
> back-to-back. However, this 5 second delay is superflous or excessive
> in many cases. For example, after IDENTIFY times out, there's no
> reason to wait five more seconds before retrying.
You'll crash some ATAPI CD-ROM drives without that delay - at least for
PATA. As in power cycle required to get it back.
Perhaps we should check cable type here ?
next prev parent reply other threads:[~2008-05-19 18:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-19 17:17 [PATCHSET #upstream] libata: improve timeout handling for EH commands Tejun Heo
2008-05-19 17:17 ` [PATCH 1/5] libata: kill unused constants Tejun Heo
2008-06-04 10:29 ` Jeff Garzik
2008-05-19 17:17 ` [PATCH 2/5] libata: consistently use msecs for time durations Tejun Heo
2008-05-19 22:35 ` Elias Oltmanns
2008-05-20 4:03 ` Tejun Heo
2008-06-13 6:55 ` Jeff Garzik
2008-05-19 17:17 ` [PATCH 3/5] libata: improve EH retry delay handling Tejun Heo
2008-05-19 18:33 ` Alan Cox [this message]
2008-05-20 4:02 ` Tejun Heo
2008-05-19 17:17 ` [PATCH 4/5] libata: use ULONG_MAX to terminate reset timeout table Tejun Heo
2008-05-19 17:17 ` [PATCH 5/5] libata: improve EH internal command timeout handling Tejun Heo
2008-05-19 18:35 ` Alan Cox
2008-05-19 18:51 ` Jeff Garzik
2008-05-20 4:05 ` Tejun Heo
2008-05-29 1:59 ` [PATCHSET #upstream] libata: improve timeout handling for EH commands Tejun Heo
2008-06-03 18:06 ` Jeff Garzik
2008-06-04 5:02 ` Tejun Heo
2008-11-10 16:32 ` saeed bishara
2008-11-11 2:27 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080519193311.01b5b928@core \
--to=alan@lxorguk.ukuu.org.uk \
--cc=htejun@gmail.com \
--cc=jeff@garzik.org \
--cc=liml@rtr.ca \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.