Re: [PATCH 2/5] libata: consistently use msecs for time durations

[Tejun Heo <htejun@gmail.com>]

Elias Oltmanns wrote:
> Tejun Heo <htejun@gmail.com> wrote:
>> libata has been using mix of jiffies and msecs for time druations.
>> This is getting confusing.  As writing sub HZ values in jiffies is
>> PITA and msecs_to_jiffies() can't be used as initializer, unify unit
>> for all time durations to msecs.  So, durations are in msecs and
>> deadlines are in jiffies.  ata_deadline() is added to compute deadline
>> from a start time and duration in msecs.
>>
>> While at it, drop now superflous _msec suffix from arguments and
>> rename @timeout to @deadline if it represents a fixed point in time
>> rather than duration.
>>
>> Signed-off-by: Tejun Heo <htejun@gmail.com>
> [...]
>> +static inline unsigned long ata_deadline(unsigned long from_jiffies,
>> +					 unsigned long timeout_msecs)
> 							      ^^^^^^
> Wouldn't that be against the newly adopted convention? Just a thought.

Yeah, but as the function takes both jiffies and msecs, I thought it 
would be better to make it explicit.  Hmmm... I can't really decide 
which way would be better.

-- 
tejun