Re: [PATCH 3/5] libata: improve EH retry delay handling

[Tejun Heo <htejun@gmail.com>]

Alan Cox wrote:
> On Tue, 20 May 2008 02:17:52 +0900
> Tejun Heo <htejun@gmail.com> wrote:
> 
>> EH retries were delayed by 5 seconds to ensure that resets don't occur
>> back-to-back.  However, this 5 second delay is superflous or excessive
>> in many cases.  For example, after IDENTIFY times out, there's no
>> reason to wait five more seconds before retrying.
> 
> You'll crash some ATAPI CD-ROM drives without that delay - at least for
> PATA. As in power cycle required to get it back.
> 
> Perhaps we should check cable type here ?

No, no, the five secs is still there.

e.g. Previously:

	reset (fail) - 5s retry wait - reset
	reset - IDENTIFY (30s timeout) - 5s retry wait - reset

Now:

	reset (fail) - 5s retry wait - reset
	reset - IDENTIFY (30s timeout) - reset

So, the inter-reset delay is never shorter than 5s.

-- 
tejun