From: Joel Becker <Joel.Becker@oracle.com>
To: Arjan van de Ven <arjan@infradead.org>
Cc: Louis Rilling <Louis.Rilling@kerlabs.com>,
linux-kernel@vger.kernel.org, ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [RFC][PATCH 0/3] configfs: Make nested default groups lockdep-friendly
Date: Tue, 20 May 2008 16:51:38 -0700 [thread overview]
Message-ID: <20080520235138.GL26609@mail.oracle.com> (raw)
In-Reply-To: <20080520153543.4bafcac9@infradead.org>
On Tue, May 20, 2008 at 03:35:43PM -0700, Arjan van de Ven wrote:
> not quite what I meant; what I meant is more like how sched.c deals
> with per cpu queues:
>
> (from sched.c)
>
> spin_lock_init(&rq->lock);
> lockdep_set_class(&rq->lock, &rq->rq_lock_key);
Looking at this, it's taking the address of the struct
lock_class_key as the actual key. Thus, if we tie one of these guys to
the structure we're representing, we get lock safety...except that we're
talking about i_mutex here, and we want to interact with the VFS's use
thereof.
Joel
--
"There is no sincerer love than the love of food."
- George Bernard Shaw
Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127
WARNING: multiple messages have this Message-ID (diff)
From: Joel Becker <Joel.Becker@oracle.com>
To: Arjan van de Ven <arjan@infradead.org>
Cc: Louis Rilling <Louis.Rilling@kerlabs.com>,
linux-kernel@vger.kernel.org, ocfs2-devel@oss.oracle.com
Subject: Re: [RFC][PATCH 0/3] configfs: Make nested default groups lockdep-friendly
Date: Tue, 20 May 2008 16:51:38 -0700 [thread overview]
Message-ID: <20080520235138.GL26609@mail.oracle.com> (raw)
In-Reply-To: <20080520153543.4bafcac9@infradead.org>
On Tue, May 20, 2008 at 03:35:43PM -0700, Arjan van de Ven wrote:
> not quite what I meant; what I meant is more like how sched.c deals
> with per cpu queues:
>
> (from sched.c)
>
> spin_lock_init(&rq->lock);
> lockdep_set_class(&rq->lock, &rq->rq_lock_key);
Looking at this, it's taking the address of the struct
lock_class_key as the actual key. Thus, if we tie one of these guys to
the structure we're representing, we get lock safety...except that we're
talking about i_mutex here, and we want to interact with the VFS's use
thereof.
Joel
--
"There is no sincerer love than the love of food."
- George Bernard Shaw
Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker@oracle.com
Phone: (650) 506-8127
next prev parent reply other threads:[~2008-05-20 23:51 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-20 16:33 [Ocfs2-devel] [RFC][PATCH 0/3] configfs: Make nested default groups lockdep-friendly Louis Rilling
2008-05-20 16:33 ` Louis Rilling
2008-05-20 16:33 ` [Ocfs2-devel] [RFC][PATCH 1/3] configfs: set CONFIGFS_USET_DEFAULT earlier in configfs_attach_group() Louis Rilling
2008-05-20 16:33 ` Louis Rilling
2008-05-20 16:33 ` [Ocfs2-devel] [RFC][PATCH 2/3] configfs: Silence lockdep when creating nested default groups Louis Rilling
2008-05-20 16:33 ` Louis Rilling
2008-05-20 16:33 ` [Ocfs2-devel] [RFC][PATCH 3/3] configfs: Silence lockdep when destroying " Louis Rilling
2008-05-20 16:33 ` Louis Rilling
2008-05-20 16:58 ` [RFC][PATCH 0/3] configfs: Make nested default groups lockdep-friendly Arjan van de Ven
2008-05-20 16:58 ` [Ocfs2-devel] " Arjan van de Ven
2008-05-20 17:08 ` Louis Rilling
2008-05-20 17:08 ` Louis Rilling
2008-05-20 21:56 ` [Ocfs2-devel] " Joel Becker
2008-05-20 21:56 ` Joel Becker
2008-05-20 22:13 ` Arjan van de Ven
2008-05-20 22:14 ` [Ocfs2-devel] " Arjan van de Ven
2008-05-20 22:27 ` Joel Becker
2008-05-20 22:27 ` Joel Becker
2008-05-20 22:35 ` Arjan van de Ven
2008-05-20 22:36 ` [Ocfs2-devel] " Arjan van de Ven
2008-05-20 23:51 ` Joel Becker [this message]
2008-05-20 23:51 ` Joel Becker
2008-05-21 9:20 ` [Ocfs2-devel] " Peter Zijlstra
2008-05-21 9:20 ` Peter Zijlstra
2008-05-21 9:23 ` [Ocfs2-devel] " Peter Zijlstra
2008-05-21 9:23 ` Peter Zijlstra
2008-05-21 10:25 ` [Ocfs2-devel] " Louis Rilling
2008-05-21 10:25 ` Louis Rilling
2008-05-21 10:59 ` [Ocfs2-devel] " Peter Zijlstra
2008-05-21 10:59 ` Peter Zijlstra
2008-05-21 12:54 ` [Ocfs2-devel] " Louis Rilling
2008-05-21 12:54 ` Louis Rilling
2008-05-21 22:09 ` [Ocfs2-devel] " Joel Becker
2008-05-21 22:09 ` Joel Becker
2008-05-21 8:13 ` [Ocfs2-devel] " Louis Rilling
2008-05-21 8:13 ` Louis Rilling
2008-05-20 21:41 ` [Ocfs2-devel] " Joel Becker
2008-05-20 21:41 ` Joel Becker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080520235138.GL26609@mail.oracle.com \
--to=joel.becker@oracle.com \
--cc=Louis.Rilling@kerlabs.com \
--cc=arjan@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.