* BUG: Ecryptfs ioctl handling
@ 2008-05-22 10:17 Alan Cox
2008-05-22 11:53 ` Arnd Bergmann
0 siblings, 1 reply; 2+ messages in thread
From: Alan Cox @ 2008-05-22 10:17 UTC (permalink / raw)
To: mahalcro, linux-kernel
Ecryptfs has an ioctl method that checks for the underlying fs ioctl
method and can call down into. Unfortunately however it doesn't check for
an underlying unlocked_ioctl method and call that if present.
Notices while removing the remaining users of ->ioctl from my dev tree.
Really ecryptfs needs its own ->unlocked_ioctl op to call into either
unlocked ioctl below or lock_kernel/ioctl/unlock_kernel below.
Alan
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: BUG: Ecryptfs ioctl handling
2008-05-22 10:17 BUG: Ecryptfs ioctl handling Alan Cox
@ 2008-05-22 11:53 ` Arnd Bergmann
0 siblings, 0 replies; 2+ messages in thread
From: Arnd Bergmann @ 2008-05-22 11:53 UTC (permalink / raw)
To: Alan Cox; +Cc: mahalcro, linux-kernel
On Thursday 22 May 2008, Alan Cox wrote:
>
> Ecryptfs has an ioctl method that checks for the underlying fs ioctl
> method and can call down into. Unfortunately however it doesn't check for
> an underlying unlocked_ioctl method and call that if present.
>
> Notices while removing the remaining users of ->ioctl from my dev tree.
>
> Really ecryptfs needs its own ->unlocked_ioctl op to call into either
> unlocked ioctl below or lock_kernel/ioctl/unlock_kernel below.
Similarly, ecryptfs doesn't provide a ->compat_ioctl op that calls into
the file system's ->compat_ioctl operation if present.
This will be needed to make ioctl handling work on file systems that
rely on ->compat_ioctl for 32 bit processes.
I wonder if there are other places in the kernel that just pass down
ioctl calls to a slave file system or driver and need to have this
added.
Arnd <><
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-05-22 11:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-05-22 10:17 BUG: Ecryptfs ioctl handling Alan Cox
2008-05-22 11:53 ` Arnd Bergmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.