From: Theodore Tso <tytso@MIT.EDU>
To: "Jörn Engel" <joern@logfs.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [Bug 421482] Firefox 3 uses fsync excessively
Date: Mon, 26 May 2008 07:38:46 -0400 [thread overview]
Message-ID: <20080526113846.GE24507@mit.edu> (raw)
In-Reply-To: <20080526111015.GB20623@logfs.org>
On Mon, May 26, 2008 at 01:10:16PM +0200, Jörn Engel wrote:
> Don't we already have this bit since Linux 2.4.0-test12? I_DIRTY_SYNC
> is admittedly not well-named for "smudged". But it used to mean just
> that. I_DIRTY_DATASYNC was the real dirty bit. Which, in I_DIRTY_PAGES,
> has been split into I_DIRTY_DATASYNC and I_DIRTY_PAGES.
>
> Now we just have to use sane names.
We're currently forcing a new commit if I_DIRTY_SYNC or
I_DIRTY_DATASYNC (but not necessarily I_DIRTY_PAGES) is set. If
I_DIRTY_SYNC really means "smudged" (I believe you but I'll want to go
through the code and prove it to myself :-), then this might be a very
easy fix. We'll need to make sure that unmount time we do actually
force out all inodes even if only I_DIRTY_SYNC is set.
(And then, we should rename things to more sane names. :-)
- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2008-05-26 11:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bug-421482-310856@https.bugzilla.mozilla.org/>
[not found] ` <200805260513.m4Q5DAU8018498@mrapp54.mozilla.org>
2008-05-26 7:05 ` [Bug 421482] Firefox 3 uses fsync excessively Andrew Morton
2008-05-26 10:07 ` Theodore Tso
2008-05-26 11:10 ` Jörn Engel
2008-05-26 11:38 ` Theodore Tso [this message]
2008-05-26 12:52 ` Jörn Engel
2008-05-26 20:22 ` Jamie Lokier
2008-05-29 17:08 ` fdatasync/barriers (was : [Bug 421482] Firefox 3 uses fsync excessively) Bryan Henderson
2008-05-29 18:46 ` jim owens
2008-05-29 23:15 ` Bryan Henderson
2008-05-30 4:00 ` Timothy Shimmin
2008-05-30 14:14 ` jim owens
2008-05-30 16:25 ` Bryan Henderson
2008-05-30 18:48 ` jim owens
2008-06-02 17:31 ` Bryan Henderson
2008-05-26 18:49 ` [Bug 421482] Firefox 3 uses fsync excessively Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080526113846.GE24507@mit.edu \
--to=tytso@mit.edu \
--cc=akpm@linux-foundation.org \
--cc=joern@logfs.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.