All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Gorven <michael@gorven.za.net>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: [PATCH] vt100 cursor on and off sequences
Date: Sat, 31 May 2008 16:42:14 +0200	[thread overview]
Message-ID: <200805311642.14955.michael@gorven.za.net> (raw)


[-- Attachment #1.1: Type: text/plain, Size: 459 bytes --]

I've been testing GRUB using the serial terminal and noticed that there was no 
cursor (and that my terminal window also lost its cursor after running GRUB). 
I looked into this today and found that the escape sequences for turning the 
cursor on and off were the wrong way round. The attached patch fixes this so 
that the serial terminal now has a cursor :-)

Michael

-- 
http://michael.gorven.za.net
PGP Key ID 6612FE85
S/MIME Key ID D33AEB31

[-- Attachment #1.2: vt100-cursor.diff --]
[-- Type: text/x-diff, Size: 1173 bytes --]

diff -rN -u old-grub-devel/ChangeLog new-grub-devel/ChangeLog
--- old-grub-devel/ChangeLog	2008-05-31 16:31:29.000000000 +0200
+++ new-grub-devel/ChangeLog	2008-05-31 16:31:29.000000000 +0200
@@ -1,3 +1,8 @@
+2008-05-31  Michael Gorven  <michael@gorven.za.net>
+
+	* term/terminfo.c (grub_terminfo_set_current): Correct vt100 cursor
+	on and off sequences.
+
 2008-05-31  Robert Millan  <rmh@aybabtu.com>
 
 	* util/update-grub_lib.in: Replace `grub-probe' with `${grub_probe}'.
diff -rN -u old-grub-devel/term/terminfo.c new-grub-devel/term/terminfo.c
--- old-grub-devel/term/terminfo.c	2008-05-31 16:31:29.000000000 +0200
+++ new-grub-devel/term/terminfo.c	2008-05-31 16:31:29.000000000 +0200
@@ -98,8 +98,8 @@
       term.cls               = grub_strdup ("\e[H\e[J");
       term.reverse_video_on  = grub_strdup ("\e[7m");
       term.reverse_video_off = grub_strdup ("\e[m");
-      term.cursor_on         = grub_strdup ("\e[?25l");
-      term.cursor_off        = grub_strdup ("\e[?25h");
+      term.cursor_on         = grub_strdup ("\e[?25h");
+      term.cursor_off        = grub_strdup ("\e[?25l");
       return grub_errno;
     }
   


[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

             reply	other threads:[~2008-05-31 14:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-31 14:42 Michael Gorven [this message]
2008-05-31 15:46 ` [PATCH] vt100 cursor on and off sequences Robert Millan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200805311642.14955.michael@gorven.za.net \
    --to=michael@gorven.za.net \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.