[PATCH] vt100 cursor on and off sequences

[PATCH] vt100 cursor on and off sequences

[Michael Gorven]

[-- Attachment #1.1: Type: text/plain, Size: 459 bytes --]

I've been testing GRUB using the serial terminal and noticed that there was no 
cursor (and that my terminal window also lost its cursor after running GRUB). 
I looked into this today and found that the escape sequences for turning the 
cursor on and off were the wrong way round. The attached patch fixes this so 
that the serial terminal now has a cursor :-)

Michael

-- 
http://michael.gorven.za.net
PGP Key ID 6612FE85
S/MIME Key ID D33AEB31

[-- Attachment #1.2: vt100-cursor.diff --]
[-- Type: text/x-diff, Size: 1173 bytes --]

diff -rN -u old-grub-devel/ChangeLog new-grub-devel/ChangeLog
--- old-grub-devel/ChangeLog	2008-05-31 16:31:29.000000000 +0200
+++ new-grub-devel/ChangeLog	2008-05-31 16:31:29.000000000 +0200
@@ -1,3 +1,8 @@
+2008-05-31  Michael Gorven  <michael@gorven.za.net>
+
+	* term/terminfo.c (grub_terminfo_set_current): Correct vt100 cursor
+	on and off sequences.
+
 2008-05-31  Robert Millan  <rmh@aybabtu.com>
 
 	* util/update-grub_lib.in: Replace `grub-probe' with `${grub_probe}'.
diff -rN -u old-grub-devel/term/terminfo.c new-grub-devel/term/terminfo.c
--- old-grub-devel/term/terminfo.c	2008-05-31 16:31:29.000000000 +0200
+++ new-grub-devel/term/terminfo.c	2008-05-31 16:31:29.000000000 +0200
@@ -98,8 +98,8 @@
       term.cls               = grub_strdup ("\e[H\e[J");
       term.reverse_video_on  = grub_strdup ("\e[7m");
       term.reverse_video_off = grub_strdup ("\e[m");
-      term.cursor_on         = grub_strdup ("\e[?25l");
-      term.cursor_off        = grub_strdup ("\e[?25h");
+      term.cursor_on         = grub_strdup ("\e[?25h");
+      term.cursor_off        = grub_strdup ("\e[?25l");
       return grub_errno;
     }
   


[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: [PATCH] vt100 cursor on and off sequences

[Robert Millan]

On Sat, May 31, 2008 at 04:42:14PM +0200, Michael Gorven wrote:
> I've been testing GRUB using the serial terminal and noticed that there was no 
> cursor (and that my terminal window also lost its cursor after running GRUB). 
> I looked into this today and found that the escape sequences for turning the 
> cursor on and off were the wrong way round. The attached patch fixes this so 
> that the serial terminal now has a cursor :-)

Committed; thanks!

-- 
Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What good is a phone call… if you are unable to speak?
(as seen on /.)