From: Al Viro <viro@ZenIV.linux.org.uk>
To: Manish Katiyar <mkatiyar@gmail.com>
Cc: linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] ext3 : Remove redundant condition in
Date: Sat, 31 May 2008 19:05:27 +0000 [thread overview]
Message-ID: <20080531190527.GG28946@ZenIV.linux.org.uk> (raw)
In-Reply-To: <ea11fea30805311156q7488714ftf8b0b8b8cea85b76@mail.gmail.com>
On Sun, Jun 01, 2008 at 12:26:41AM +0530, Manish Katiyar wrote:
> For two unsigned values the check "block+count < block" is always
> false. Thus the below patch removes that condition.
Really? Always?
unsigned block = 1;
unsigned count = ~0U;
What will be the value and type of block + count? What will be the
value of block + count < block?
WARNING: multiple messages have this Message-ID (diff)
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Manish Katiyar <mkatiyar@gmail.com>
Cc: linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] ext3 : Remove redundant condition in ext3_free_blocks_sb()
Date: Sat, 31 May 2008 20:05:27 +0100 [thread overview]
Message-ID: <20080531190527.GG28946@ZenIV.linux.org.uk> (raw)
In-Reply-To: <ea11fea30805311156q7488714ftf8b0b8b8cea85b76@mail.gmail.com>
On Sun, Jun 01, 2008 at 12:26:41AM +0530, Manish Katiyar wrote:
> For two unsigned values the check "block+count < block" is always
> false. Thus the below patch removes that condition.
Really? Always?
unsigned block = 1;
unsigned count = ~0U;
What will be the value and type of block + count? What will be the
value of block + count < block?
next prev parent reply other threads:[~2008-05-31 19:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-31 18:56 [PATCH] ext3 : Remove redundant condition in ext3_free_blocks_sb() Manish Katiyar
2008-05-31 19:08 ` Manish Katiyar
2008-05-31 19:05 ` Al Viro [this message]
2008-05-31 19:05 ` Al Viro
2008-05-31 19:10 ` Manish Katiyar
2008-05-31 19:22 ` Manish Katiyar
2008-06-03 13:20 ` Matthew Wilcox
2008-06-03 13:20 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080531190527.GG28946@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=mkatiyar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.