From: Matthew Wilcox <matthew@wil.cx>
To: Manish Katiyar <mkatiyar@gmail.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] ext3 : Remove redundant condition in ext3_free_blocks_sb()
Date: Tue, 03 Jun 2008 13:20:30 +0000 [thread overview]
Message-ID: <20080603132030.GD8434@parisc-linux.org> (raw)
In-Reply-To: <ea11fea30805311210o15de2373m71d91228356f9bfd@mail.gmail.com>
On Sun, Jun 01, 2008 at 12:40:32AM +0530, Manish Katiyar wrote:
> Oooops....my bad, but I doubt if we pass such values in ext* code anywhere.
If we have a corrupt filesystem, we can pass total garbage here. This
check prevents that from corrupting the filesystem further. Patch NAKed
with extreme prejudice.
--
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
WARNING: multiple messages have this Message-ID (diff)
From: Matthew Wilcox <matthew@wil.cx>
To: Manish Katiyar <mkatiyar@gmail.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] ext3 : Remove redundant condition in ext3_free_blocks_sb()
Date: Tue, 3 Jun 2008 07:20:30 -0600 [thread overview]
Message-ID: <20080603132030.GD8434@parisc-linux.org> (raw)
In-Reply-To: <ea11fea30805311210o15de2373m71d91228356f9bfd@mail.gmail.com>
On Sun, Jun 01, 2008 at 12:40:32AM +0530, Manish Katiyar wrote:
> Oooops....my bad, but I doubt if we pass such values in ext* code anywhere.
If we have a corrupt filesystem, we can pass total garbage here. This
check prevents that from corrupting the filesystem further. Patch NAKed
with extreme prejudice.
--
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
next prev parent reply other threads:[~2008-06-03 13:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-31 18:56 [PATCH] ext3 : Remove redundant condition in ext3_free_blocks_sb() Manish Katiyar
2008-05-31 19:08 ` Manish Katiyar
2008-05-31 19:05 ` [PATCH] ext3 : Remove redundant condition in Al Viro
2008-05-31 19:05 ` [PATCH] ext3 : Remove redundant condition in ext3_free_blocks_sb() Al Viro
2008-05-31 19:10 ` Manish Katiyar
2008-05-31 19:22 ` Manish Katiyar
2008-06-03 13:20 ` Matthew Wilcox [this message]
2008-06-03 13:20 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080603132030.GD8434@parisc-linux.org \
--to=matthew@wil.cx \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=mkatiyar@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.