Re: [PATCH e2fsprogs] Add ZFS detection to libblkid

[Karel Zak <kzak@redhat.com>]

On Fri, May 30, 2008 at 07:20:47PM +0100, Ricardo M. Correia wrote:
> This patch adds ZFS filesystem detection to libblkid.

 It'd be nice to add ZFS detection to libvolume_id from udev package.

> Unfortunately the probe table doesn't support probing from the end of
> the device, otherwise we could also probe in the 3rd and 4th labels (in
> case the first 2 labels were accidentally overwritten)..

 This shouldn't be a problem in libvolume_id.

> +static int probe_zfs(struct blkid_probe *probe, struct blkid_magic *id,
> +		     unsigned char *buf)
> +{
> +	char *vdev_label;
> +	const char *pool_name = 0;
> +
> +	/* read nvpair data for pool name, pool GUID (complex) */
> +	//blkid_set_tag(probe->dev, "LABEL", pool_name, sizeof(pool_name));
> +	//set_uuid(probe->dev, pool_guid, 0);

 C++ ?

> -		if (memcmp(id->bim_magic, buf + (id->bim_sboff&0x3ff),
> +		if (memcmp(id->bim_magic, buf + (id->bim_sboff & 0x3ff),

 ???

    Karel

-- 
 Karel Zak  <kzak@redhat.com>