All of lore.kernel.org
 help / color / mirror / Atom feed
From: Karel Zak <kzak@redhat.com>
To: "Ricardo M. Correia" <Ricardo.M.Correia@Sun.COM>
Cc: Andreas Dilger <adilger@Sun.COM>,
	Eric Sandeen <sandeen@redhat.com>,
	"Theodore Ts'o" <tytso@mit.edu>,
	linux-ext4@vger.kernel.org
Subject: Re: [PATCH e2fsprogs] Add ZFS detection to libblkid
Date: Fri, 17 Apr 2009 11:51:36 +0200	[thread overview]
Message-ID: <20090417095136.GA12255@nb.net.home> (raw)
In-Reply-To: <1239650962.18123.44.camel@localhost>

On Mon, Apr 13, 2009 at 08:29:22PM +0100, Ricardo M. Correia wrote:
> On Ter, 2009-04-07 at 00:40 -0700, Andreas Dilger wrote:
> > > However, even though currently it's txg nr 4 that gets written first,
> > > this is an implementation-specific detail that we cannot (or should not)
> > > rely upon.
> > 
> > So my proposal to check the 0th, 4th, and 8th überblock in both
> > the first and second VDEV label should be pretty safe.
> 
> Yes, that should be relatively safe :)
> 
> Where should I be sending patches for this? e2fsprogs, util-linux-ng,
> libvolume_id in udev, ... all of them?

Please,

  git://git.kernel.org/pub/scm/utils/util-linux-ng/util-linux-ng.git

currently the libs/blkid/src/probers/zfs.c file contains the original
Andreas's probing code. Note that you needn't to use hard-coded
offsets (see for example ufs.c).

I'll eventually port your patch to libvolume_id and e2fsprogs.

Thanks.

    Karel

-- 
 Karel Zak  <kzak@redhat.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

      reply	other threads:[~2009-04-17  9:51 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-30 18:20 [PATCH e2fsprogs] Add ZFS detection to libblkid Ricardo M. Correia
2008-06-02  7:41 ` Karel Zak
2008-06-02 15:03   ` Ricardo M. Correia
     [not found]   ` <1212418863.7337.34.camel@localhost>
2008-06-02 20:58     ` Karel Zak
2008-06-02 21:38       ` Andreas Dilger
2008-06-02 22:31         ` Karel Zak
2008-06-02 23:11           ` Andreas Dilger
2008-06-03  0:05       ` Theodore Tso
2008-06-03  1:11 ` Theodore Tso
2009-04-04  2:39 ` Eric Sandeen
2009-04-04 13:04   ` Eric Sandeen
2009-04-04 21:25     ` Andreas Dilger
2009-04-04 21:46       ` Eric Sandeen
2009-04-06  6:25         ` Andreas Dilger
2009-04-06 19:22       ` Ricardo M. Correia
2009-04-06 20:13         ` Eric Sandeen
2009-04-13 19:18           ` Ricardo M. Correia
2009-04-13 19:27             ` Eric Sandeen
2009-04-06 20:35         ` Karel Zak
2009-04-07  7:40         ` Andreas Dilger
2009-04-13 19:29           ` Ricardo M. Correia
2009-04-17  9:51             ` Karel Zak [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090417095136.GA12255@nb.net.home \
    --to=kzak@redhat.com \
    --cc=Ricardo.M.Correia@Sun.COM \
    --cc=adilger@Sun.COM \
    --cc=linux-ext4@vger.kernel.org \
    --cc=sandeen@redhat.com \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.