Re: [PATCH e2fsprogs] Add ZFS detection to libblkid

[Eric Sandeen <sandeen@redhat.com>]

Andreas Dilger wrote:
> On Apr 04, 2009  08:04 -0500, Eric Sandeen wrote:
>> And from another report, another user's zfs partition:
>>
>> # hexdump -C first_400K | grep "0c b1 07 b0 f5 02 00 00"
>> # hexdump -C first_400K | grep "00 00 02 f5 b0 07 b1 0c"
>> # hexdump -C first_400K | grep "0c b1 ba 00"
>> 00015e30  30 e8 ff ff 85 c0 5b 75  48 8b 06 35 0c b1 ba 00
>>
>> Should we be looking for 0x00babloc at offset 00015e30?
> 
> In probe.c I see the magic (that I've been assuming is correct, because
> it isn't really that easy to read):
> 
>   { "zfs",       8,      0,  8, "\0\0\x02\xf5\xb0\x07\xb1\x0c", probe_zfs },
>   { "zfs",       8,      0,  8, "\x0c\xb1\x07\xb0\xf5\x02\0\0", probe_zfs },
>   { "zfs",     264,      0,  8, "\0\0\x02\xf5\xb0\x07\xb1\x0c", probe_zfs },
>   { "zfs",     264,      0,  8, "\x0c\xb1\x07\xb0\xf5\x02\0\0", probe_zfs },

Yep and that's different from the patch you originally submitted, Andreas...

> but looking at this I have no idea what this magic value is supposed
> to represent, from reading the ondiskformat0822.pdf (ZFS spec) document.

VDEV_BOOT_MAGIC ...

  333 /* ZFS boot block */
  334 #define VDEV_BOOT_MAGIC         0x2f5b007b10cULL

but I can't find much in that spec about where it's supposed to be, at
least from a very quick skim.

I'll let you IBM er... SUN guys sort it out  ;)

-Eric