All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joachim Fenkes <fenkes@de.ibm.com>
To: "LinuxPPC-Dev" <linuxppc-dev@ozlabs.org>,
	LKML <linux-kernel@vger.kernel.org>,
	"OF-General" <general@lists.openfabrics.org>,
	Roland Dreier <rolandd@cisco.com>,
	"OF-EWG" <ewg@lists.openfabrics.org>
Cc: Stefan Roscher <stefan.roscher@de.ibm.com>,
	Christoph Raisch <raisch@de.ibm.com>
Subject: IB/ehca: Reject send WRs only for RESET, INIT and RTR state
Date: Fri, 6 Jun 2008 18:35:43 +0200	[thread overview]
Message-ID: <200806061835.43802.fenkes@de.ibm.com> (raw)

Signed-off-by: Joachim Fenkes <fenkes@de.ibm.com>
---
 drivers/infiniband/hw/ehca/ehca_reqs.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/infiniband/hw/ehca/ehca_reqs.c b/drivers/infiniband/hw/ehca/ehca_reqs.c
index bbe0436..f093b00 100644
--- a/drivers/infiniband/hw/ehca/ehca_reqs.c
+++ b/drivers/infiniband/hw/ehca/ehca_reqs.c
@@ -421,8 +421,10 @@ int ehca_post_send(struct ib_qp *qp,
 	int ret = 0;
 	unsigned long flags;
 
-	if (unlikely(my_qp->state != IB_QPS_RTS)) {
-		ehca_err(qp->device, "QP not in RTS state  qpn=%x", qp->qp_num);
+	/* Reject WR if QP is in RESET, INIT or RTR state */
+	if (unlikely(my_qp->state < IB_QPS_RTS)) {
+		ehca_err(qp->device, "Invalid QP state  qp_state=%d qpn=%x",
+			 my_qp->state, qp->qp_num);
 		return -EINVAL;
 	}
 
-- 
1.5.5

WARNING: multiple messages have this Message-ID (diff)
From: Joachim Fenkes <fenkes@de.ibm.com>
To: "LinuxPPC-Dev" <linuxppc-dev@ozlabs.org>,
	LKML <linux-kernel@vger.kernel.org>,
	"OF-General" <general@lists.openfabrics.org>,
	Roland Dreier <rolandd@cisco.com>,
	"OF-EWG" <ewg@lists.openfabrics.org>
Cc: "Hoang-Nam Nguyen" <hnguyen@de.ibm.com>,
	Christoph Raisch <raisch@de.ibm.com>,
	Stefan Roscher <stefan.roscher@de.ibm.com>
Subject: IB/ehca: Reject send WRs only for RESET, INIT and RTR state
Date: Fri, 6 Jun 2008 18:35:43 +0200	[thread overview]
Message-ID: <200806061835.43802.fenkes@de.ibm.com> (raw)

Signed-off-by: Joachim Fenkes <fenkes@de.ibm.com>
---
 drivers/infiniband/hw/ehca/ehca_reqs.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/infiniband/hw/ehca/ehca_reqs.c b/drivers/infiniband/hw/ehca/ehca_reqs.c
index bbe0436..f093b00 100644
--- a/drivers/infiniband/hw/ehca/ehca_reqs.c
+++ b/drivers/infiniband/hw/ehca/ehca_reqs.c
@@ -421,8 +421,10 @@ int ehca_post_send(struct ib_qp *qp,
 	int ret = 0;
 	unsigned long flags;
 
-	if (unlikely(my_qp->state != IB_QPS_RTS)) {
-		ehca_err(qp->device, "QP not in RTS state  qpn=%x", qp->qp_num);
+	/* Reject WR if QP is in RESET, INIT or RTR state */
+	if (unlikely(my_qp->state < IB_QPS_RTS)) {
+		ehca_err(qp->device, "Invalid QP state  qp_state=%d qpn=%x",
+			 my_qp->state, qp->qp_num);
 		return -EINVAL;
 	}
 
-- 
1.5.5



             reply	other threads:[~2008-06-06 16:35 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-06 16:35 Joachim Fenkes [this message]
2008-06-06 16:35 ` IB/ehca: Reject send WRs only for RESET, INIT and RTR state Joachim Fenkes
2008-06-06 18:22 ` Roland Dreier
2008-06-06 18:22   ` Roland Dreier
2008-06-06 20:20 ` [ofa-general] " Dotan Barak
2008-06-06 20:20   ` Dotan Barak
2008-06-09 11:24   ` [PATCH] IB/ehca: Reject recv WRs if QP is in RESET state Joachim Fenkes
2008-06-09 11:24     ` Joachim Fenkes
2008-06-20 17:26     ` Roland Dreier
2008-06-20 17:26       ` Roland Dreier
2008-07-01 14:14   ` [PATCH] IB/ehca: Make device table externally visible Joachim Fenkes
2008-07-01 14:14     ` Joachim Fenkes
2008-07-01 17:55     ` Roland Dreier
2008-07-01 17:55       ` Roland Dreier
2008-11-07 16:42   ` [PATCH] IB/ehca: Fix suppression of port activation events Joachim Fenkes
2008-11-07 16:42     ` Joachim Fenkes
2008-11-10 20:36     ` Roland Dreier
2008-11-10 20:36       ` Roland Dreier
2008-11-11  9:04       ` Joachim Fenkes
2008-11-11  9:04         ` Joachim Fenkes
2008-11-21 15:37   ` [PATCH] IB/ehca: Fix lockdep failures for shca_list_lock Joachim Fenkes
2008-11-21 15:37     ` Joachim Fenkes
2008-11-21 16:02     ` Johannes Berg
2008-11-21 16:02       ` Johannes Berg
2008-11-21 16:18       ` [PATCH] IB/ehca: Fix locking " Joachim Fenkes
2008-11-21 16:18         ` Joachim Fenkes
2008-11-21 18:28         ` Roland Dreier
2008-11-21 18:28           ` Roland Dreier
2008-11-22  3:41       ` [PATCH] IB/ehca: Fix lockdep failures " Michael Ellerman
2008-11-25 12:58   ` [PATCH] IB/ehca: Change misleading error message Joachim Fenkes
2008-11-25 12:58     ` Joachim Fenkes
2008-11-25 23:13     ` Roland Dreier
2008-11-25 23:13       ` Roland Dreier
2008-11-26 13:44       ` Joachim Fenkes
2008-11-26 13:44         ` Joachim Fenkes
2009-06-03 14:28   ` [PATCH] IB/ehca: Remove superfluous bitmasks from QP control block Joachim Fenkes
2009-06-03 14:28     ` Joachim Fenkes
2009-06-03 20:26     ` Roland Dreier
2009-06-03 20:26       ` Roland Dreier
2009-09-01 11:55   ` [PATCH] IB/ehca: Fix CQE flags reporting Joachim Fenkes
2009-09-01 11:55     ` Joachim Fenkes
2009-09-01 19:55     ` Roland Dreier
2009-09-01 19:55       ` Roland Dreier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200806061835.43802.fenkes@de.ibm.com \
    --to=fenkes@de.ibm.com \
    --cc=ewg@lists.openfabrics.org \
    --cc=general@lists.openfabrics.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=raisch@de.ibm.com \
    --cc=rolandd@cisco.com \
    --cc=stefan.roscher@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.