All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: npiggin@suse.de
Cc: torvalds@linux-foundation.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org, benh@kernel.crashing.org,
	paulus@samba.org
Subject: Re: [patch 7/7] powerpc: lockless get_user_pages_fast
Date: Mon, 9 Jun 2008 01:32:04 -0700	[thread overview]
Message-ID: <20080609013204.7c291b68.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080605094826.128415000@nick.local0.net>

On Thu, 05 Jun 2008 19:43:07 +1000 npiggin@suse.de wrote:

> Implement lockless get_user_pages_fast for powerpc. Page table existence is
> guaranteed with RCU, and speculative page references are used to take a
> reference to the pages without having a prior existence guarantee on them.
> 

arch/powerpc/mm/gup.c: In function `get_user_pages_fast':
arch/powerpc/mm/gup.c:156: error: `SLICE_LOW_TOP' undeclared (first use in this function)
arch/powerpc/mm/gup.c:156: error: (Each undeclared identifier is reported only once
arch/powerpc/mm/gup.c:156: error: for each function it appears in.)
arch/powerpc/mm/gup.c:178: error: implicit declaration of function `get_slice_psize'
arch/powerpc/mm/gup.c:178: error: `mmu_huge_psize' undeclared (first use in this function)
arch/powerpc/mm/gup.c:182: error: implicit declaration of function `huge_pte_offset'
arch/powerpc/mm/gup.c:182: warning: assignment makes pointer from integer without a cast

with

http://userweb.kernel.org/~akpm/config-g5.txt

I don't immediately know why - adding asm/page.h to gup.c doesn't help.
I'm suspecting a recursive include problem somewhere.

I'll drop it, sorry - too much other stuff to fix over here.

WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: npiggin@suse.de
Cc: torvalds@linux-foundation.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org, benh@kernel.crashing.org,
	paulus@samba.org
Subject: Re: [patch 7/7] powerpc: lockless get_user_pages_fast
Date: Mon, 9 Jun 2008 01:32:04 -0700	[thread overview]
Message-ID: <20080609013204.7c291b68.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080605094826.128415000@nick.local0.net>

On Thu, 05 Jun 2008 19:43:07 +1000 npiggin@suse.de wrote:

> Implement lockless get_user_pages_fast for powerpc. Page table existence is
> guaranteed with RCU, and speculative page references are used to take a
> reference to the pages without having a prior existence guarantee on them.
> 

arch/powerpc/mm/gup.c: In function `get_user_pages_fast':
arch/powerpc/mm/gup.c:156: error: `SLICE_LOW_TOP' undeclared (first use in this function)
arch/powerpc/mm/gup.c:156: error: (Each undeclared identifier is reported only once
arch/powerpc/mm/gup.c:156: error: for each function it appears in.)
arch/powerpc/mm/gup.c:178: error: implicit declaration of function `get_slice_psize'
arch/powerpc/mm/gup.c:178: error: `mmu_huge_psize' undeclared (first use in this function)
arch/powerpc/mm/gup.c:182: error: implicit declaration of function `huge_pte_offset'
arch/powerpc/mm/gup.c:182: warning: assignment makes pointer from integer without a cast

with

http://userweb.kernel.org/~akpm/config-g5.txt

I don't immediately know why - adding asm/page.h to gup.c doesn't help.
I'm suspecting a recursive include problem somewhere.

I'll drop it, sorry - too much other stuff to fix over here.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2008-06-09  8:32 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-05  9:43 [patch 0/7] speculative page references, lockless pagecache, lockless gup npiggin
2008-06-05  9:43 ` npiggin
2008-06-05  9:43 ` [patch 1/7] mm: readahead scan lockless npiggin
2008-06-05  9:43   ` npiggin
2008-06-05  9:43 ` [patch 2/7] radix-tree: add gang_lookup_slot, gang_lookup_slot_tag npiggin
2008-06-05  9:43   ` npiggin
2008-06-05  9:43 ` [patch 3/7] mm: speculative page references npiggin
2008-06-05  9:43   ` npiggin
2008-06-06 14:20   ` Peter Zijlstra
2008-06-06 14:20     ` Peter Zijlstra
2008-06-06 16:26     ` Nick Piggin
2008-06-06 16:26       ` Nick Piggin
2008-06-06 16:27     ` Nick Piggin
2008-06-06 16:27       ` Nick Piggin
2008-06-09  4:48   ` Tim Pepper
2008-06-09  4:48     ` Tim Pepper
2008-06-10 19:08   ` Christoph Lameter
2008-06-10 19:08     ` Christoph Lameter
2008-06-11  3:19     ` Nick Piggin
2008-06-11  3:19       ` Nick Piggin
2008-06-05  9:43 ` [patch 4/7] mm: lockless pagecache npiggin
2008-06-05  9:43   ` npiggin
2008-06-05  9:43 ` [patch 5/7] mm: spinlock tree_lock npiggin
2008-06-05  9:43   ` npiggin
2008-06-05  9:43 ` [patch 6/7] powerpc: implement pte_special npiggin
2008-06-05  9:43   ` npiggin
2008-06-06  4:04   ` Benjamin Herrenschmidt
2008-06-06  4:04     ` Benjamin Herrenschmidt
2008-06-05  9:43 ` [patch 7/7] powerpc: lockless get_user_pages_fast npiggin
2008-06-05  9:43   ` npiggin
2008-06-09  8:32   ` Andrew Morton [this message]
2008-06-09  8:32     ` Andrew Morton
2008-06-10  3:15     ` Nick Piggin
2008-06-10  3:15       ` Nick Piggin
2008-06-10 19:00   ` Christoph Lameter
2008-06-10 19:00     ` Christoph Lameter
2008-06-11  3:18     ` Nick Piggin
2008-06-11  3:18       ` Nick Piggin
2008-06-11  4:40       ` Christoph Lameter
2008-06-11  4:40         ` Christoph Lameter
2008-06-11  4:41         ` Christoph Lameter
2008-06-11  4:41           ` Christoph Lameter
2008-06-11  4:49           ` Nick Piggin
2008-06-11  4:49             ` Nick Piggin
2008-06-11  6:06             ` Andrew Morton
2008-06-11  6:06               ` Andrew Morton
2008-06-11  6:24               ` Nick Piggin
2008-06-11  6:24                 ` Nick Piggin
2008-06-11  6:50                 ` Andrew Morton
2008-06-11  6:50                   ` Andrew Morton
2008-06-11 23:20               ` Christoph Lameter
2008-06-11 23:20                 ` Christoph Lameter
2008-06-11  4:47         ` Nick Piggin
2008-06-11  4:47           ` Nick Piggin
2008-06-05 11:53 ` [patch 0/7] speculative page references, lockless pagecache, lockless gup Nick Piggin
2008-06-05 11:53   ` Nick Piggin
2008-06-05 17:33 ` Linus Torvalds
2008-06-05 17:33   ` Linus Torvalds
2008-06-06  0:08   ` Nick Piggin
2008-06-06  0:08     ` Nick Piggin
2008-06-06 21:32 ` Peter Zijlstra
2008-06-06 21:32   ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080609013204.7c291b68.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=benh@kernel.crashing.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=npiggin@suse.de \
    --cc=paulus@samba.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.