All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Shawn O. Pearce" <spearce@spearce.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	Olivier Marin <dkr+ml.git@free.fr>,
	git@vger.kernel.org
Subject: Re: [PATCH v2] remote show: fix the -n option
Date: Mon, 9 Jun 2008 21:19:13 -0400	[thread overview]
Message-ID: <20080610011913.GA11793@spearce.org> (raw)
In-Reply-To: <7vd4mqdrhi.fsf@gitster.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> wrote:
> At least I care enough to point out that I think you are wrong in this
> case.  "show -n" in the scripted version was never about "dry-run" but
> was about "no-query".
...
> I am CC'ing Shawn who authored 859607d (Teach 'git remote' how to cleanup
> stale tracking branches., 2007-02-02) to give him a chance to point out
> why I am wrong in saying "prune -n" is nonsense.  Maybe there is a valid
> use case for that option, even though I do not see one.

I agree with you Junio.  "prune -n" is nonsense.  You cannot know
what to remove locally that the remote no longer advertises without
querying the remote.

So "prune -n" is nonsense and should issue an error.  "prune --dry-run"
is different and means "query, show what you would delete, but don't
actually delete".

Likewise "show --dry-run" is nonsense.  What does it mean to show
what would show without showing it?  Just show it.   :)

-- 
Shawn.

  reply	other threads:[~2008-06-10  1:20 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-08  0:54 remote show/prune: strange -n(--dry-run) option Olivier Marin
2008-06-08 11:03 ` [PATCH] Documentation/git-remote.txt: remove description for useless -n option Olivier Marin
2008-06-08 12:22 ` dkr+ml.git
2008-06-08 20:27   ` Junio C Hamano
2008-06-09  0:43     ` Olivier Marin
2008-06-09  0:48       ` [PATCH] remote show: fix the " Olivier Marin
2008-06-09  1:16         ` Johannes Schindelin
2008-06-09  2:06           ` Olivier Marin
2008-06-09  2:35             ` Johannes Schindelin
2008-06-09  4:16               ` Olivier Marin
2008-06-09  4:53                 ` Johannes Schindelin
2008-06-09 14:22                   ` Olivier Marin
2008-06-09 15:43                     ` Olivier Marin
2008-06-09 16:31                       ` Johannes Schindelin
2008-06-09 15:58         ` [PATCH v2] " Olivier Marin
2008-06-09 16:35           ` Johannes Schindelin
2008-06-09 16:58             ` Olivier Marin
2008-06-09 17:56               ` Johannes Schindelin
2008-06-09 18:37                 ` Olivier Marin
2008-06-09 20:11                   ` [PATCH] builtin-remote: make reuse of code easier by not die()ing Johannes Schindelin
2008-06-09 20:43                     ` Olivier Marin
2008-06-10  1:10             ` [PATCH v2] remote show: fix the -n option Junio C Hamano
2008-06-10  1:19               ` Shawn O. Pearce [this message]
2008-06-10  2:39                 ` Johannes Schindelin
2008-06-10 14:50               ` [PATCH 0/4] remote show/prune improvement Olivier Marin
2008-06-10 14:51                 ` [PATCH 1/4] remote show: fix the -n option Olivier Marin
2008-06-10 14:51                 ` [PATCH 2/4] builtin-remote: split show_or_prune() in two separate functions Olivier Marin
2008-06-10 14:51                 ` [PATCH 3/4] remote prune: print the list of pruned branches Olivier Marin
2008-06-12  7:00                   ` Junio C Hamano
2008-06-12 11:07                     ` Olivier Marin
2008-06-10 14:51                 ` [PATCH 4/4] remote show: list tracked remote branches with -n Olivier Marin
2008-06-10 19:12                   ` Junio C Hamano
2008-06-10 22:54                     ` [PATCH v2 " Olivier Marin
2008-06-10 15:09                 ` [PATCH 0/4] remote show/prune improvement Jakub Narebski
2008-06-10 16:10                   ` Olivier Marin
2008-06-10 17:11                     ` Jakub Narebski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080610011913.GA11793@spearce.org \
    --to=spearce@spearce.org \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=dkr+ml.git@free.fr \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.