All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Olivier Marin <dkr+ml.git@free.fr>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	"Shawn O. Pearce" <spearce@spearce.org>,
	git@vger.kernel.org, Olivier Marin <dkr@freesurf.fr>
Subject: Re: [PATCH 4/4] remote show: list tracked remote branches with -n
Date: Tue, 10 Jun 2008 12:12:28 -0700	[thread overview]
Message-ID: <7vod69cder.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <1213109509-7013-1-git-send-email-dkr+ml.git@free.fr> (Olivier Marin's message of "Tue, 10 Jun 2008 16:51:49 +0200")

Olivier Marin <dkr+ml.git@free.fr> writes:

> From: Olivier Marin <dkr@freesurf.fr>
>
> Signed-off-by: Olivier Marin <dkr@freesurf.fr>
> ---
>  builtin-remote.c  |   25 +++++++++++++++++++++++--
>  t/t5505-remote.sh |    3 ++-
>  2 files changed, 25 insertions(+), 3 deletions(-)
>
> diff --git a/builtin-remote.c b/builtin-remote.c
> index 851bdde..de4a4f2 100644
> --- a/builtin-remote.c
> +++ b/builtin-remote.c
> @@ -444,6 +444,25 @@ static int get_remote_ref_states(const char *name,
>  	return 0;
>  }
>  
> +static int append_ref_to_tracked_list(const char *refname,
> +	const unsigned char *sha1, int flags, void *cb_data)
> +{
> +	struct ref_states *states = cb_data;
> +	struct strbuf buf;
> +
> +	strbuf_init(&buf, 0);
> +	strbuf_addf(&buf, "%s/", states->remote->name);
> +	if (strncmp(buf.buf, refname, buf.len)) {
> +		strbuf_release(&buf);
> +		return 0;
> +	}

Doesn't this have the same issue Shawn fixed in 7ad2458 (Make "git-remote
rm" delete refs acccording to fetch specs, 2008-06-01)?

  reply	other threads:[~2008-06-10 19:13 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-08  0:54 remote show/prune: strange -n(--dry-run) option Olivier Marin
2008-06-08 11:03 ` [PATCH] Documentation/git-remote.txt: remove description for useless -n option Olivier Marin
2008-06-08 12:22 ` dkr+ml.git
2008-06-08 20:27   ` Junio C Hamano
2008-06-09  0:43     ` Olivier Marin
2008-06-09  0:48       ` [PATCH] remote show: fix the " Olivier Marin
2008-06-09  1:16         ` Johannes Schindelin
2008-06-09  2:06           ` Olivier Marin
2008-06-09  2:35             ` Johannes Schindelin
2008-06-09  4:16               ` Olivier Marin
2008-06-09  4:53                 ` Johannes Schindelin
2008-06-09 14:22                   ` Olivier Marin
2008-06-09 15:43                     ` Olivier Marin
2008-06-09 16:31                       ` Johannes Schindelin
2008-06-09 15:58         ` [PATCH v2] " Olivier Marin
2008-06-09 16:35           ` Johannes Schindelin
2008-06-09 16:58             ` Olivier Marin
2008-06-09 17:56               ` Johannes Schindelin
2008-06-09 18:37                 ` Olivier Marin
2008-06-09 20:11                   ` [PATCH] builtin-remote: make reuse of code easier by not die()ing Johannes Schindelin
2008-06-09 20:43                     ` Olivier Marin
2008-06-10  1:10             ` [PATCH v2] remote show: fix the -n option Junio C Hamano
2008-06-10  1:19               ` Shawn O. Pearce
2008-06-10  2:39                 ` Johannes Schindelin
2008-06-10 14:50               ` [PATCH 0/4] remote show/prune improvement Olivier Marin
2008-06-10 14:51                 ` [PATCH 1/4] remote show: fix the -n option Olivier Marin
2008-06-10 14:51                 ` [PATCH 2/4] builtin-remote: split show_or_prune() in two separate functions Olivier Marin
2008-06-10 14:51                 ` [PATCH 3/4] remote prune: print the list of pruned branches Olivier Marin
2008-06-12  7:00                   ` Junio C Hamano
2008-06-12 11:07                     ` Olivier Marin
2008-06-10 14:51                 ` [PATCH 4/4] remote show: list tracked remote branches with -n Olivier Marin
2008-06-10 19:12                   ` Junio C Hamano [this message]
2008-06-10 22:54                     ` [PATCH v2 " Olivier Marin
2008-06-10 15:09                 ` [PATCH 0/4] remote show/prune improvement Jakub Narebski
2008-06-10 16:10                   ` Olivier Marin
2008-06-10 17:11                     ` Jakub Narebski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vod69cder.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=dkr+ml.git@free.fr \
    --cc=dkr@freesurf.fr \
    --cc=git@vger.kernel.org \
    --cc=spearce@spearce.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.