From: Olivier Marin <dkr+ml.git@free.fr>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH v2] remote show: fix the -n option
Date: Mon, 09 Jun 2008 20:37:20 +0200 [thread overview]
Message-ID: <484D7860.6050301@free.fr> (raw)
In-Reply-To: <alpine.DEB.1.00.0806091856180.1783@racer>
Johannes Schindelin a écrit :
>
> But did you not now make it harder to fix "that"? By relying on the die()
> behaviour in your regression fix?
If I change return path for some functions, I will have to check all the
callers anyway. So, no I don't think it make things harder to fix. Also
I don't like to add dead code.
Please, let me do this fix so that I can post my next patches. After that
I will be happy to work on what you asked.
Olivier.
next prev parent reply other threads:[~2008-06-09 18:38 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-08 0:54 remote show/prune: strange -n(--dry-run) option Olivier Marin
2008-06-08 11:03 ` [PATCH] Documentation/git-remote.txt: remove description for useless -n option Olivier Marin
2008-06-08 12:22 ` dkr+ml.git
2008-06-08 20:27 ` Junio C Hamano
2008-06-09 0:43 ` Olivier Marin
2008-06-09 0:48 ` [PATCH] remote show: fix the " Olivier Marin
2008-06-09 1:16 ` Johannes Schindelin
2008-06-09 2:06 ` Olivier Marin
2008-06-09 2:35 ` Johannes Schindelin
2008-06-09 4:16 ` Olivier Marin
2008-06-09 4:53 ` Johannes Schindelin
2008-06-09 14:22 ` Olivier Marin
2008-06-09 15:43 ` Olivier Marin
2008-06-09 16:31 ` Johannes Schindelin
2008-06-09 15:58 ` [PATCH v2] " Olivier Marin
2008-06-09 16:35 ` Johannes Schindelin
2008-06-09 16:58 ` Olivier Marin
2008-06-09 17:56 ` Johannes Schindelin
2008-06-09 18:37 ` Olivier Marin [this message]
2008-06-09 20:11 ` [PATCH] builtin-remote: make reuse of code easier by not die()ing Johannes Schindelin
2008-06-09 20:43 ` Olivier Marin
2008-06-10 1:10 ` [PATCH v2] remote show: fix the -n option Junio C Hamano
2008-06-10 1:19 ` Shawn O. Pearce
2008-06-10 2:39 ` Johannes Schindelin
2008-06-10 14:50 ` [PATCH 0/4] remote show/prune improvement Olivier Marin
2008-06-10 14:51 ` [PATCH 1/4] remote show: fix the -n option Olivier Marin
2008-06-10 14:51 ` [PATCH 2/4] builtin-remote: split show_or_prune() in two separate functions Olivier Marin
2008-06-10 14:51 ` [PATCH 3/4] remote prune: print the list of pruned branches Olivier Marin
2008-06-12 7:00 ` Junio C Hamano
2008-06-12 11:07 ` Olivier Marin
2008-06-10 14:51 ` [PATCH 4/4] remote show: list tracked remote branches with -n Olivier Marin
2008-06-10 19:12 ` Junio C Hamano
2008-06-10 22:54 ` [PATCH v2 " Olivier Marin
2008-06-10 15:09 ` [PATCH 0/4] remote show/prune improvement Jakub Narebski
2008-06-10 16:10 ` Olivier Marin
2008-06-10 17:11 ` Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=484D7860.6050301@free.fr \
--to=dkr+ml.git@free.fr \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.