All of lore.kernel.org
 help / color / mirror / Atom feed
From: wysochanski@sourceware.org <wysochanski@sourceware.org>
To: lvm-devel@redhat.com
Subject: LVM2 ./WHATS_NEW tools/toollib.c
Date: 10 Jun 2008 15:25:38 -0000	[thread overview]
Message-ID: <20080610152538.31322.qmail@sourceware.org> (raw)

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	wysochanski at sourceware.org	2008-06-10 15:25:38

Modified files:
	.              : WHATS_NEW 
	tools          : toollib.c 

Log message:
	Add ommitted unlock_vg() call when sigint_caught() during vg processing.
	
	Specific test case:
	1. pvcreate /dev/loop1; vgcreate vg1 /dev/loop1; lvcreate -L 64M -n lv1 vg1
	2. vgremove vg1 (will prompt user)
	3. CTRL-C
	Code will exit with:
	Do you really want to remove volume group "vg2" containing 2 logical volumes? [y/n]:
	Volume group "vg2" not removed
	Command failed with status code 5.
	Internal error: Volume Group vg2 was not unlocked
	Device '/dev/loop1' has been left open.
	
	After change:
	Do you really want to remove volume group "vg2" containing 2 logical volumes? [y/n]:
	Volume group "vg2" not removed
	Command failed with status code 5.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.894&r2=1.895
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/toollib.c.diff?cvsroot=lvm2&r1=1.133&r2=1.134

--- LVM2/WHATS_NEW	2008/06/10 14:55:14	1.894
+++ LVM2/WHATS_NEW	2008/06/10 15:25:37	1.895
@@ -1,5 +1,6 @@
 Version 2.02.38 - 
 =================================
+  Add omitted unlock_vg() call when sigint_caught() during vg processing.
   Fix wrong free_count on imported vg from pool device
   Fix segfault when calling pvcreate on the pool device
   Fix segfault after _free_vginfo by remembering to remove vginfo from list.
--- LVM2/tools/toollib.c	2008/04/10 19:59:43	1.133
+++ LVM2/tools/toollib.c	2008/06/10 15:25:38	1.134
@@ -514,9 +514,6 @@
 		ret_max = ret;
 	}
 
-	if (sigint_caught())
-		return ret_max;
-
 	unlock_vg(cmd, vg_name);
 
 	return ret_max;



             reply	other threads:[~2008-06-10 15:25 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-10 15:25 wysochanski [this message]
  -- strict thread matches above, loose matches on Subject: below --
2012-01-25 21:52 LVM2 ./WHATS_NEW tools/toollib.c zkabelac
2011-11-18 19:19 zkabelac
2011-02-18 15:02 zkabelac
2010-11-23 20:39 zkabelac
2010-05-21 14:15 zkabelac
2010-05-21 14:11 zkabelac
2010-05-21 12:19 zkabelac
2010-04-14  2:19 agk
2010-04-23 15:39 ` Mike Snitzer
2010-04-23 18:19   ` Mike Snitzer
2010-04-23 18:49     ` Alasdair G Kergon
2009-11-24 16:13 mbroz
2009-09-29 20:33 agk
2009-08-24 11:37 mbroz
2009-07-21 11:10 agk
2009-05-27 13:23 agk
2009-04-10  9:54 mbroz
2008-02-06 16:09 agk
2008-01-03 19:03 agk
2007-09-11 20:12 meyering
2007-07-10 17:51 agk
2006-10-24 18:25 agk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080610152538.31322.qmail@sourceware.org \
    --to=wysochanski@sourceware.org \
    --cc=lvm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.