All of lore.kernel.org
 help / color / mirror / Atom feed
From: zkabelac@sourceware.org <zkabelac@sourceware.org>
To: lvm-devel@redhat.com
Subject: LVM2 ./WHATS_NEW tools/toollib.c
Date: 21 May 2010 12:19:23 -0000	[thread overview]
Message-ID: <20100521121923.4031.qmail@sourceware.org> (raw)

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	zkabelac at sourceware.org	2010-05-21 12:19:23

Modified files:
	.              : WHATS_NEW 
	tools          : toollib.c 

Log message:
	Return ECMD_FAILED for break in process_each_lv() and process_each_segment_in_lv()

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.1574&r2=1.1575
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/toollib.c.diff?cvsroot=lvm2&r1=1.197&r2=1.198

--- LVM2/WHATS_NEW	2010/05/20 23:21:53	1.1574
+++ LVM2/WHATS_NEW	2010/05/21 12:19:22	1.1575
@@ -1,5 +1,6 @@
 Version 2.02.67 -
 ===============================
+  Return ECMD_FAILED for break in process_each_lv() and process_each_segment_in_lv().
 
 Version 2.02.66 - 20th May 2010
 ===============================
--- LVM2/tools/toollib.c	2010/05/06 11:15:56	1.197
+++ LVM2/tools/toollib.c	2010/05/21 12:19:22	1.198
@@ -329,8 +329,9 @@
 		unlock_and_release_vg(cmd, vg, vgname);
 		if (ret > ret_max)
 			ret_max = ret;
+		/* FIXME: logic for breaking command is not consistent */
 		if (sigint_caught())
-			break;
+			return ECMD_FAILED;
 	}
 
 	return ret_max;
@@ -408,8 +409,9 @@
 		ret = process_single_seg(cmd, seg, handle);
 		if (ret > ret_max)
 			ret_max = ret;
+		/* FIXME: logic for breaking command is not consistent */
 		if (sigint_caught())
-			break;
+			return ECMD_FAILED;
 	}
 
 	return ret_max;



             reply	other threads:[~2010-05-21 12:19 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-21 12:19 zkabelac [this message]
  -- strict thread matches above, loose matches on Subject: below --
2012-01-25 21:52 LVM2 ./WHATS_NEW tools/toollib.c zkabelac
2011-11-18 19:19 zkabelac
2011-02-18 15:02 zkabelac
2010-11-23 20:39 zkabelac
2010-05-21 14:15 zkabelac
2010-05-21 14:11 zkabelac
2010-04-14  2:19 agk
2010-04-23 15:39 ` Mike Snitzer
2010-04-23 18:19   ` Mike Snitzer
2010-04-23 18:49     ` Alasdair G Kergon
2009-11-24 16:13 mbroz
2009-09-29 20:33 agk
2009-08-24 11:37 mbroz
2009-07-21 11:10 agk
2009-05-27 13:23 agk
2009-04-10  9:54 mbroz
2008-06-10 15:25 wysochanski
2008-02-06 16:09 agk
2008-01-03 19:03 agk
2007-09-11 20:12 meyering
2007-07-10 17:51 agk
2006-10-24 18:25 agk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100521121923.4031.qmail@sourceware.org \
    --to=zkabelac@sourceware.org \
    --cc=lvm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.