From: agk@sourceware.org <agk@sourceware.org>
To: lvm-devel@redhat.com
Subject: LVM2 ./WHATS_NEW tools/toollib.c
Date: 21 Jul 2009 11:10:50 -0000 [thread overview]
Message-ID: <20090721111050.25719.qmail@sourceware.org> (raw)
CVSROOT: /cvs/lvm2
Module name: LVM2
Changes by: agk at sourceware.org 2009-07-21 11:10:49
Modified files:
. : WHATS_NEW
tools : toollib.c
Log message:
Return EINVALID_CMD_LINE not success when invalid VG name format is used.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.1193&r2=1.1194
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/toollib.c.diff?cvsroot=lvm2&r1=1.165&r2=1.166
--- LVM2/WHATS_NEW 2009/07/16 03:25:26 1.1193
+++ LVM2/WHATS_NEW 2009/07/21 11:10:49 1.1194
@@ -1,5 +1,6 @@
Version 2.02.50 -
================================
+ Return EINVALID_CMD_LINE not success when invalid VG name format is used.
Remove unnecessary messages after vgcreate/vgsplit refactor (2.02.49).
Add log_errno to set a specific errno and replace log_error in due course.
Add lvm_errno and lvm_errmsg to liblvm to obtain failure information.
--- LVM2/tools/toollib.c 2009/07/15 20:02:48 1.165
+++ LVM2/tools/toollib.c 2009/07/21 11:10:49 1.166
@@ -482,6 +482,8 @@
if (!validate_name(vg_name + 1)) {
log_error("Skipping invalid tag %s",
vg_name);
+ if (ret_max < EINVALID_CMD_LINE)
+ ret_max = EINVALID_CMD_LINE;
continue;
}
if (!str_list_add(cmd->mem, &tags,
@@ -497,6 +499,8 @@
if (strchr(vg_name, '/')) {
log_error("Invalid volume group name: %s",
vg_name);
+ if (ret_max < EINVALID_CMD_LINE)
+ ret_max = EINVALID_CMD_LINE;
continue;
}
if (!str_list_add(cmd->mem, &arg_vgnames,
next reply other threads:[~2009-07-21 11:10 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-21 11:10 agk [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-01-25 21:52 LVM2 ./WHATS_NEW tools/toollib.c zkabelac
2011-11-18 19:19 zkabelac
2011-02-18 15:02 zkabelac
2010-11-23 20:39 zkabelac
2010-05-21 14:15 zkabelac
2010-05-21 14:11 zkabelac
2010-05-21 12:19 zkabelac
2010-04-14 2:19 agk
2010-04-23 15:39 ` Mike Snitzer
2010-04-23 18:19 ` Mike Snitzer
2010-04-23 18:49 ` Alasdair G Kergon
2009-11-24 16:13 mbroz
2009-09-29 20:33 agk
2009-08-24 11:37 mbroz
2009-05-27 13:23 agk
2009-04-10 9:54 mbroz
2008-06-10 15:25 wysochanski
2008-02-06 16:09 agk
2008-01-03 19:03 agk
2007-09-11 20:12 meyering
2007-07-10 17:51 agk
2006-10-24 18:25 agk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090721111050.25719.qmail@sourceware.org \
--to=agk@sourceware.org \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.