From: Joel Becker <Joel.Becker@oracle.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] Re: [Ocfs2-devel] [RFC] configfs: Pin configfs subsystems separately from new config_items.
Date: Mon, 23 Jun 2008 12:10:28 -0700 [thread overview]
Message-ID: <20080623191027.GF592@mail.oracle.com> (raw)
In-Reply-To: <20080623154457.GW30804@localhost>
On Mon, Jun 23, 2008 at 05:44:57PM +0200, Louis Rilling wrote:
> make_item()
> new_item = kmalloc();
> config_item_init_type_long_name();
> return new_item;
>
> drop_item(item)
> config_item_put(item);
> kfree(item);
This is never, ever safe. Consider that someone has an
attribute file open - it has a reference to the item. You can still
rmdir() the item - doing stuff to the attribute after drop_item() will
just get ignored. But you can't free it in drop_item().
Joel
--
"Vote early and vote often."
- Al Capone
Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127
WARNING: multiple messages have this Message-ID (diff)
From: Joel Becker <Joel.Becker@oracle.com>
To: Louis Rilling <Louis.Rilling@kerlabs.com>
Cc: linux-fsdevel@vger.kernel.org, cluster-devel@redhat.com,
ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [RFC] configfs: Pin configfs subsystems separately from new config_items.
Date: Mon, 23 Jun 2008 12:10:28 -0700 [thread overview]
Message-ID: <20080623191027.GF592@mail.oracle.com> (raw)
In-Reply-To: <20080623154457.GW30804@localhost>
On Mon, Jun 23, 2008 at 05:44:57PM +0200, Louis Rilling wrote:
> make_item()
> new_item = kmalloc();
> config_item_init_type_long_name();
> return new_item;
>
> drop_item(item)
> config_item_put(item);
> kfree(item);
This is never, ever safe. Consider that someone has an
attribute file open - it has a reference to the item. You can still
rmdir() the item - doing stuff to the attribute after drop_item() will
just get ignored. But you can't free it in drop_item().
Joel
--
"Vote early and vote often."
- Al Capone
Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127
WARNING: multiple messages have this Message-ID (diff)
From: Joel Becker <Joel.Becker@oracle.com>
To: Louis Rilling <Louis.Rilling@kerlabs.com>
Cc: linux-fsdevel@vger.kernel.org, cluster-devel@redhat.com,
ocfs2-devel@oss.oracle.com
Subject: Re: [Ocfs2-devel] [RFC] configfs: Pin configfs subsystems separately from new config_items.
Date: Mon, 23 Jun 2008 12:10:28 -0700 [thread overview]
Message-ID: <20080623191027.GF592@mail.oracle.com> (raw)
In-Reply-To: <20080623154457.GW30804@localhost>
On Mon, Jun 23, 2008 at 05:44:57PM +0200, Louis Rilling wrote:
> make_item()
> new_item = kmalloc();
> config_item_init_type_long_name();
> return new_item;
>
> drop_item(item)
> config_item_put(item);
> kfree(item);
This is never, ever safe. Consider that someone has an
attribute file open - it has a reference to the item. You can still
rmdir() the item - doing stuff to the attribute after drop_item() will
just get ignored. But you can't free it in drop_item().
Joel
--
"Vote early and vote often."
- Al Capone
Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker@oracle.com
Phone: (650) 506-8127
next prev parent reply other threads:[~2008-06-23 19:10 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-17 22:41 [Cluster-devel] [RFC] configfs: Pin configfs subsystems separately from new config_items Joel Becker
2008-06-17 22:41 ` Joel Becker
2008-06-17 22:41 ` [Ocfs2-devel] " Joel Becker
2008-06-18 12:31 ` Louis Rilling
2008-06-18 12:31 ` Louis Rilling
2008-06-18 16:12 ` [Cluster-devel] " Joel Becker
2008-06-18 16:12 ` Joel Becker
2008-06-18 16:12 ` Joel Becker
2008-06-18 16:51 ` Louis Rilling
2008-06-18 16:51 ` Louis Rilling
2008-06-18 20:07 ` [Cluster-devel] " Joel Becker
2008-06-18 20:07 ` Joel Becker
2008-06-18 20:07 ` [Ocfs2-devel] " Joel Becker
2008-06-19 11:13 ` Louis Rilling
2008-06-19 11:13 ` Louis Rilling
2008-06-19 22:07 ` [Cluster-devel] " Joel Becker
2008-06-19 22:07 ` Joel Becker
2008-06-19 22:07 ` Joel Becker
2008-06-20 12:46 ` Louis Rilling
2008-06-20 12:46 ` Louis Rilling
2008-06-20 22:36 ` [Cluster-devel] " Joel Becker
2008-06-20 22:36 ` Joel Becker
2008-06-20 22:36 ` Joel Becker
2008-06-23 15:44 ` Louis Rilling
2008-06-23 15:44 ` Louis Rilling
2008-06-23 19:10 ` Joel Becker [this message]
2008-06-23 19:10 ` Joel Becker
2008-06-23 19:10 ` Joel Becker
2008-06-24 5:04 ` Louis Rilling
2008-06-24 5:04 ` Louis Rilling
2008-06-24 17:03 ` [Cluster-devel] " Joel Becker
2008-06-24 17:03 ` Joel Becker
2008-06-24 17:03 ` [Ocfs2-devel] " Joel Becker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080623191027.GF592@mail.oracle.com \
--to=joel.becker@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.