All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@suse.cz>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Len Brown <lenb@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
	Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>,
	pm list <linux-pm@lists.linux-foundation.org>
Subject: Re: [PATCH] x86 ACPI: normalize segment descriptor register on resume
Date: Tue, 24 Jun 2008 23:46:10 +0200	[thread overview]
Message-ID: <20080624214610.GC18679@elf.ucw.cz> (raw)
In-Reply-To: <200806242303.49498.rjw@sisk.pl>

Hi!

> From: H. Peter Anvin <hpa@zytor.com>
> 
> x86 ACPI: normalize segment descriptor register on resume
> 
> Some Dell laptops enter resume with apparent garbage in the segment
> descriptor registers (almost certainly the result of a botched
> transition from protected to real mode.)  The only way to clean that
> up is to enter protected mode ourselves and clean out the descriptor
> registers.
> 
> This fixes resume on Dell XPS M1210 and Dell D620.
> 
> Reference: http://bugzilla.kernel.org/show_bug.cgi?id=10927
> 
> Signed-off-by: H. Peter Anvin <hpa@zytor.com>
> Tested-by: Kirill A. Shutemov <kirill@shutemov.name>
> Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>

Thanks for great work.

I still consider this one slightly risky, and would like to get it as
much testing as possible, but all the risks are hypothetical and
regression from 2.6.25 is real, so...

Acked-by: Pavel Machek <pavel@suse.cz>

If this could be sneaked into Ingo's tree for some automated testing,
that would be good.

									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

  parent reply	other threads:[~2008-06-24 21:45 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-24 21:03 [PATCH] x86 ACPI: normalize segment descriptor register on resume Rafael J. Wysocki
2008-06-24 21:46 ` Pavel Machek
2008-06-24 21:46 ` Pavel Machek [this message]
2008-06-25 17:01   ` Ingo Molnar
2008-06-25 17:01   ` Ingo Molnar
2008-06-25 20:17     ` Rafael J. Wysocki
2008-06-25 20:17     ` Rafael J. Wysocki
2008-06-26  8:17       ` Andrew Morton
2008-06-26  8:29         ` Ingo Molnar
2008-06-26  8:39           ` Rafael J. Wysocki
2008-06-26  8:39           ` Rafael J. Wysocki
2008-06-26  8:51             ` Ingo Molnar
2008-06-26  8:56               ` Rafael J. Wysocki
2008-06-26  8:56               ` Rafael J. Wysocki
2008-06-26  8:51             ` Ingo Molnar
2008-06-26  8:29         ` Ingo Molnar
2008-06-26  8:35         ` Rafael J. Wysocki
2008-06-26  8:35         ` Rafael J. Wysocki
2008-06-26  8:17       ` Andrew Morton
2008-06-24 21:47 ` Len Brown
2008-06-24 21:47 ` Len Brown
  -- strict thread matches above, loose matches on Subject: below --
2008-06-24 21:03 Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080624214610.GC18679@elf.ucw.cz \
    --to=pavel@suse.cz \
    --cc=akpm@linux-foundation.org \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=mingo@elte.hu \
    --cc=rjw@sisk.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.