All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Pavel Machek <pavel@suse.cz>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>, Len Brown <lenb@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	pm list <linux-pm@lists.linux-foundation.org>
Subject: Re: [PATCH] x86 ACPI: normalize segment descriptor register on resume
Date: Wed, 25 Jun 2008 19:01:26 +0200	[thread overview]
Message-ID: <20080625170126.GA2482@elte.hu> (raw)
In-Reply-To: <20080624214610.GC18679@elf.ucw.cz>


* Pavel Machek <pavel@suse.cz> wrote:

> Acked-by: Pavel Machek <pavel@suse.cz>
> 
> If this could be sneaked into Ingo's tree for some automated testing, 
> that would be good.

sure - i have applied it to tip/out-of-tree. I'm equally nervous about 
this change - it affects every suspend+resume cycle that people do on 
those boxes which are working just fine currently.

btw., it would get a lot more coverage on my test-systems if this commit 
in tip/out-of-tree:

| commit 01259383c345d13b70efcc549439927ae64dc66d
| Author: David Brownell <david-b@pacbell.net>
| Date:   Fri May 16 10:12:36 2008 +0200
|
|     sleepy linux self-test

was upstream and if it was enabled more prominently, instead of hidden 
behind the rather obscure condition of:

  config PM_TEST_SUSPEND
        bool "Test suspend/resume and wakealarm during bootup"
        depends on SUSPEND && PM_DEBUG && RTC_LIB=y

and even then it needs certain other config options related to RTC_LIB 
to actually work during bootup.

As a result of all this obstruction, the automated testing i do, which 
builds and boots more than 1 random kernel per minute, will only run 
this self-test once every hour or so.

I dont mind if this option breaks boxes (that its purpose: it does the 
same thing that a real suspend+resume does and suspend+resume frequently 
breaks boxes), but right now it's all obscured so heavily which makes 
automated testing a lot harder than it should be.

it would be wonderful if this excellent suspend+resume self-test was 
upstream and was more prominent! :-)

	Ingo

  reply	other threads:[~2008-06-25 17:01 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-24 21:03 [PATCH] x86 ACPI: normalize segment descriptor register on resume Rafael J. Wysocki
2008-06-24 21:46 ` Pavel Machek
2008-06-25 17:01   ` Ingo Molnar [this message]
2008-06-25 20:17     ` Rafael J. Wysocki
2008-06-26  8:17       ` Andrew Morton
2008-06-26  8:17       ` Andrew Morton
2008-06-26  8:29         ` Ingo Molnar
2008-06-26  8:39           ` Rafael J. Wysocki
2008-06-26  8:39           ` Rafael J. Wysocki
2008-06-26  8:51             ` Ingo Molnar
2008-06-26  8:56               ` Rafael J. Wysocki
2008-06-26  8:56               ` Rafael J. Wysocki
2008-06-26  8:51             ` Ingo Molnar
2008-06-26  8:29         ` Ingo Molnar
2008-06-26  8:35         ` Rafael J. Wysocki
2008-06-26  8:35         ` Rafael J. Wysocki
2008-06-25 20:17     ` Rafael J. Wysocki
2008-06-25 17:01   ` Ingo Molnar
2008-06-24 21:46 ` Pavel Machek
2008-06-24 21:47 ` Len Brown
2008-06-24 21:47 ` Len Brown
  -- strict thread matches above, loose matches on Subject: below --
2008-06-24 21:03 Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080625170126.GA2482@elte.hu \
    --to=mingo@elte.hu \
    --cc=akpm@linux-foundation.org \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=pavel@suse.cz \
    --cc=rjw@sisk.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.