All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sylvain Joyeux <sylvain.joyeux@dfki.de>
To: Avery Pennarun <apenwarr@gmail.com>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	Junio C Hamano <gitster@pobox.com>,
	Lars Hjemli <hjemli@gmail.com>, Ping Yin <pkufranky@gmail.com>,
	Mark Levedahl <mlevedahl@gmail.com>,
	git@vger.kernel.org
Subject: Re: [PATCH] better git-submodule status output
Date: Mon, 7 Jul 2008 17:00:23 +0200	[thread overview]
Message-ID: <20080707150023.GJ3696@joyeux> (raw)
In-Reply-To: <32541b130807070725p6fa4d0dfne9f04bc857920dc7@mail.gmail.com>

> I haven't looked at your patch, so I don't know if you're calling
> fetch in such a way that it doesn't update any refs.
Frankly, I don't know either. But since the question is more on a design
level, it does not matter for now.

> Thus, I'd say the
> best fix would be to find a way to have "git pull" or "git fetch" in
> the supermodule also do a fetch in the submodule.  I think it's fair
> to expect "fetchy" operations like fetch and pull to perhaps do some
> extra fetches, but not fair to expect "status" to do extra work like
> that.
I do agree on the principle, it is just that I don't know where to do it
otherwise. Would the involved people be fine with a new "git submodule
fetch" command ?

> Also note that "your supermodule links to a commit that you haven't
> fetched yet" is a perfectly okay state to report to the user.  I might
> use a "?" or something to indicate that.
For now, my patch shows '!' ... But I'm open to other suggestions.

Sylvain

  parent reply	other threads:[~2008-07-07 15:01 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-01 15:01 [PATCH] better git-submodule status output Sylvain Joyeux
2008-07-06  6:19 ` Junio C Hamano
2008-07-06 12:57   ` Johannes Schindelin
2008-07-06 16:07     ` Sylvain Joyeux
2008-07-06 16:29       ` Johannes Schindelin
2008-07-07  6:21         ` Sylvain Joyeux
2008-07-07 14:25           ` Avery Pennarun
2008-07-07 14:34             ` Johannes Schindelin
2008-07-07 14:37               ` Johannes Schindelin
2008-07-07 14:57                 ` Sylvain Joyeux
2008-07-07 15:21                   ` Johannes Schindelin
2008-07-07 15:42                     ` Sylvain Joyeux
2008-07-07 18:20                   ` Junio C Hamano
2008-07-07 18:29                     ` Avery Pennarun
2008-07-07 19:51                       ` Junio C Hamano
2008-07-08  8:00                     ` Sylvain Joyeux
2008-07-08 11:21                       ` Johannes Schindelin
2008-07-08 12:22                         ` Sylvain Joyeux
2008-07-08 13:00                           ` Johannes Schindelin
2008-07-08 13:12                             ` Sylvain Joyeux
2008-07-07 14:57               ` Avery Pennarun
2008-07-07 15:23                 ` Johannes Schindelin
2008-07-07 15:36                   ` Avery Pennarun
2008-07-07 16:10                     ` Johannes Schindelin
2008-07-07 15:52                   ` Sylvain Joyeux
2008-07-07 15:00             ` Sylvain Joyeux [this message]
2008-07-06 13:14   ` Mark Levedahl
2008-07-09 10:13 ` Sylvain Joyeux
2008-07-09 10:25   ` Andreas Ericsson
2008-07-09 11:01     ` Sylvain Joyeux
2008-07-09 12:31   ` Johannes Schindelin
2008-07-09 13:46     ` Sylvain Joyeux
2008-07-09 13:54       ` Johannes Schindelin
2008-07-09 18:48   ` Junio C Hamano
  -- strict thread matches above, loose matches on Subject: below --
2008-07-01 14:57 Sylvain Joyeux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080707150023.GJ3696@joyeux \
    --to=sylvain.joyeux@dfki.de \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=apenwarr@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=hjemli@gmail.com \
    --cc=mlevedahl@gmail.com \
    --cc=pkufranky@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.