From: Ingo Molnar <mingo@elte.hu>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Nick Piggin <nickpiggin@yahoo.com.au>,
LKML <linux-kernel@vger.kernel.org>, Jens Axboe <axboe@kernel.dk>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Christoph Lameter <clameter@linux-foundation.org>,
Petr Tesarik <ptesarik@suse.cz>,
Virtualization <virtualization@lists.linux-foundation.org>,
Xen devel <xen-devel@lists.xensource.com>,
Thomas Friebel <thomas.friebel@amd.com>,
Avi Kivity <avi@qumranet.com>,
the arch/x86 maintainers <x86@kernel.org>
Subject: Re: [patch] x86, paravirt-spinlocks: fix boot hang
Date: Wed, 9 Jul 2008 21:26:30 +0200 [thread overview]
Message-ID: <20080709192630.GA4804@elte.hu> (raw)
In-Reply-To: <4874DF7F.4080204@goop.org>
* Jeremy Fitzhardinge <jeremy@goop.org> wrote:
>> should never
>> be built with -pg (which ftrace does). Marking paravirt.o as
>> non-pg and marking all spinlock ops as always-inline solve the
>> hang.
>>
>
> Thanks Ingo, that would have taken me a while to work out.
yeah, i figured i'd be the better candidate to debug ftrace related
problems ;-)
> Presumably that means that xen/smp.o should also be built without -pg.
> In fact, should I move the spinlock code into its own file, so that
> ftrace can cover as much as it can?
hm, yeah. Anything that can be called via the lowest level spinlock
functions should be either notrace, or, better, in a -pg-excluded .o
file. Putting it all into a separate file would cover it nicely i think.
Ingo
WARNING: multiple messages have this Message-ID (diff)
From: Ingo Molnar <mingo@elte.hu>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Jens Axboe <axboe@kernel.dk>,
Nick Piggin <nickpiggin@yahoo.com.au>,
Xen devel <xen-devel@lists.xensource.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Christoph Lameter <clameter@linux-foundation.org>,
the arch/x86 maintainers <x86@kernel.org>,
Petr Tesarik <ptesarik@suse.cz>,
LKML <linux-kernel@vger.kernel.org>,
Avi Kivity <avi@qumranet.com>,
Virtualization <virtualization@lists.linux-foundation.org>,
Thomas Friebel <thomas.friebel@amd.com>
Subject: Re: [patch] x86, paravirt-spinlocks: fix boot hang
Date: Wed, 9 Jul 2008 21:26:30 +0200 [thread overview]
Message-ID: <20080709192630.GA4804@elte.hu> (raw)
In-Reply-To: <4874DF7F.4080204@goop.org>
* Jeremy Fitzhardinge <jeremy@goop.org> wrote:
>> should never
>> be built with -pg (which ftrace does). Marking paravirt.o as
>> non-pg and marking all spinlock ops as always-inline solve the
>> hang.
>>
>
> Thanks Ingo, that would have taken me a while to work out.
yeah, i figured i'd be the better candidate to debug ftrace related
problems ;-)
> Presumably that means that xen/smp.o should also be built without -pg.
> In fact, should I move the spinlock code into its own file, so that
> ftrace can cover as much as it can?
hm, yeah. Anything that can be called via the lowest level spinlock
functions should be either notrace, or, better, in a -pg-excluded .o
file. Putting it all into a separate file would cover it nicely i think.
Ingo
next prev parent reply other threads:[~2008-07-09 19:27 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-07 19:07 [PATCH RFC 0/4] Paravirtual spinlocks Jeremy Fitzhardinge
2008-07-07 19:07 ` Jeremy Fitzhardinge
2008-07-07 19:07 ` [PATCH RFC 1/4] x86/paravirt: add hooks for spinlock operations Jeremy Fitzhardinge
2008-07-07 19:07 ` Jeremy Fitzhardinge
2008-07-07 19:07 ` Jeremy Fitzhardinge
2008-07-07 19:07 ` [PATCH RFC 2/4] paravirt: introduce a "lock-byte" spinlock implementation Jeremy Fitzhardinge
2008-07-07 19:07 ` Jeremy Fitzhardinge
2008-07-07 19:07 ` Jeremy Fitzhardinge
2008-07-07 19:07 ` [PATCH RFC 3/4] xen: use lock-byte " Jeremy Fitzhardinge
2008-07-07 19:07 ` Jeremy Fitzhardinge
2008-07-07 19:07 ` Jeremy Fitzhardinge
2008-07-07 19:07 ` [PATCH RFC 4/4] xen: implement Xen-specific spinlocks Jeremy Fitzhardinge
2008-07-07 19:07 ` Jeremy Fitzhardinge
2008-07-08 6:37 ` Johannes Weiner
2008-07-08 7:15 ` Jeremy Fitzhardinge
2008-07-08 7:15 ` Jeremy Fitzhardinge
2008-07-08 7:15 ` Jeremy Fitzhardinge
2008-07-08 7:30 ` Johannes Weiner
2008-07-08 7:30 ` Johannes Weiner
2008-07-08 6:37 ` Johannes Weiner
2008-07-08 0:29 ` [PATCH RFC 0/4] Paravirtual spinlocks Rusty Russell
2008-07-08 0:29 ` Rusty Russell
2008-07-08 0:37 ` Jeremy Fitzhardinge
2008-07-08 0:37 ` Jeremy Fitzhardinge
2008-07-08 1:01 ` Rusty Russell
2008-07-08 1:01 ` Rusty Russell
2008-07-08 0:37 ` Jeremy Fitzhardinge
2008-07-08 4:51 ` Nick Piggin
2008-07-08 4:51 ` Nick Piggin
2008-07-08 4:51 ` Nick Piggin
2008-07-08 5:28 ` Jeremy Fitzhardinge
2008-07-08 5:28 ` Jeremy Fitzhardinge
2008-07-08 5:28 ` Jeremy Fitzhardinge
2008-07-09 12:28 ` Ingo Molnar
2008-07-09 12:28 ` Ingo Molnar
2008-07-09 12:35 ` [patch] x86: paravirt spinlocks, !CONFIG_SMP build fixes (was: Re: [PATCH RFC 0/4] Paravirtual spinlocks) Ingo Molnar
2008-07-09 12:35 ` Ingo Molnar
2008-07-09 12:35 ` Ingo Molnar
2008-07-09 12:39 ` [patch] x86: paravirt spinlocks, modular build fix " Ingo Molnar
2008-07-09 12:39 ` Ingo Molnar
2008-07-09 12:39 ` Ingo Molnar
2008-07-09 13:33 ` [PATCH RFC 0/4] Paravirtual spinlocks Ingo Molnar
2008-07-09 13:33 ` Ingo Molnar
2008-07-09 13:33 ` Ingo Molnar
2008-07-09 13:49 ` [patch] x86, paravirt-spinlocks: fix boot hang (was: Re: [PATCH RFC 0/4] Paravirtual spinlocks) Ingo Molnar
2008-07-09 13:49 ` Ingo Molnar
2008-07-09 13:49 ` Ingo Molnar
2008-07-09 15:55 ` [patch] x86, paravirt-spinlocks: fix boot hang Jeremy Fitzhardinge
2008-07-09 19:26 ` Ingo Molnar [this message]
2008-07-09 19:26 ` Ingo Molnar
2008-07-09 19:26 ` Ingo Molnar
2008-07-09 15:55 ` Jeremy Fitzhardinge
2008-07-09 12:28 ` [PATCH RFC 0/4] Paravirtual spinlocks Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080709192630.GA4804@elte.hu \
--to=mingo@elte.hu \
--cc=a.p.zijlstra@chello.nl \
--cc=avi@qumranet.com \
--cc=axboe@kernel.dk \
--cc=clameter@linux-foundation.org \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nickpiggin@yahoo.com.au \
--cc=ptesarik@suse.cz \
--cc=thomas.friebel@amd.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.