From: Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>
To: penberg@cs.helsinki.fi
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: [RFC PATCH 3/5] kmemtrace: SLAB hooks.
Date: Thu, 10 Jul 2008 21:06:11 +0300 [thread overview]
Message-ID: <20080710210611.7c194a70@linux360.ro> (raw)
In-Reply-To: <1215712946-23572-3-git-send-email-eduard.munteanu@linux360.ro>
This adds hooks for the SLAB allocator, to allow tracing with kmemtrace.
Signed-off-by: Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>
---
include/linux/slab_def.h | 16 +++++++++++++---
mm/slab.c | 35 +++++++++++++++++++++++++++++------
2 files changed, 42 insertions(+), 9 deletions(-)
diff --git a/include/linux/slab_def.h b/include/linux/slab_def.h
index 39c3a5e..89d0cca 100644
--- a/include/linux/slab_def.h
+++ b/include/linux/slab_def.h
@@ -14,6 +14,7 @@
#include <asm/page.h> /* kmalloc_sizes.h needs PAGE_SIZE */
#include <asm/cache.h> /* kmalloc_sizes.h needs L1_CACHE_BYTES */
#include <linux/compiler.h>
+#include <linux/kmemtrace.h>
/* Size description struct for general caches. */
struct cache_sizes {
@@ -30,6 +31,8 @@ void *__kmalloc(size_t size, gfp_t flags);
static inline void *kmalloc(size_t size, gfp_t flags)
{
+ void *ret;
+
if (__builtin_constant_p(size)) {
int i = 0;
@@ -50,10 +53,17 @@ static inline void *kmalloc(size_t size, gfp_t flags)
found:
#ifdef CONFIG_ZONE_DMA
if (flags & GFP_DMA)
- return kmem_cache_alloc(malloc_sizes[i].cs_dmacachep,
- flags);
+ ret = kmem_cache_alloc(malloc_sizes[i].cs_dmacachep,
+ flags | __GFP_NOTRACE);
+ else
#endif
- return kmem_cache_alloc(malloc_sizes[i].cs_cachep, flags);
+ ret = kmem_cache_alloc(malloc_sizes[i].cs_cachep,
+ flags | __GFP_NOTRACE);
+
+ kmemtrace_mark_alloc(KMEMTRACE_KIND_KERNEL, _THIS_IP_, ret,
+ size, malloc_sizes[i].cs_size, flags);
+
+ return ret;
}
return __kmalloc(size, flags);
}
diff --git a/mm/slab.c b/mm/slab.c
index 046607f..29f0599 100644
--- a/mm/slab.c
+++ b/mm/slab.c
@@ -111,6 +111,7 @@
#include <linux/rtmutex.h>
#include <linux/reciprocal_div.h>
#include <linux/debugobjects.h>
+#include <linux/kmemtrace.h>
#include <asm/cacheflush.h>
#include <asm/tlbflush.h>
@@ -3621,7 +3622,12 @@ static inline void __cache_free(struct kmem_cache *cachep, void *objp)
*/
void *kmem_cache_alloc(struct kmem_cache *cachep, gfp_t flags)
{
- return __cache_alloc(cachep, flags, __builtin_return_address(0));
+ void *ret = __cache_alloc(cachep, flags, __builtin_return_address(0));
+
+ kmemtrace_mark_alloc(KMEMTRACE_KIND_CACHE, _RET_IP_, ret,
+ obj_size(cachep), obj_size(cachep), flags);
+
+ return ret;
}
EXPORT_SYMBOL(kmem_cache_alloc);
@@ -3669,8 +3675,14 @@ out:
#ifdef CONFIG_NUMA
void *kmem_cache_alloc_node(struct kmem_cache *cachep, gfp_t flags, int nodeid)
{
- return __cache_alloc_node(cachep, flags, nodeid,
- __builtin_return_address(0));
+ void *ret = __cache_alloc_node(cachep, flags, nodeid,
+ __builtin_return_address(0));
+
+ kmemtrace_mark_alloc_node(KMEMTRACE_KIND_CACHE, _RET_IP_, ret,
+ obj_size(cachep), obj_size(cachep),
+ flags, nodeid);
+
+ return ret;
}
EXPORT_SYMBOL(kmem_cache_alloc_node);
@@ -3718,6 +3730,7 @@ static __always_inline void *__do_kmalloc(size_t size, gfp_t flags,
void *caller)
{
struct kmem_cache *cachep;
+ void *ret;
/* If you want to save a few bytes .text space: replace
* __ with kmem_.
@@ -3726,12 +3739,18 @@ static __always_inline void *__do_kmalloc(size_t size, gfp_t flags,
*/
cachep = __find_general_cachep(size, flags);
if (unlikely(ZERO_OR_NULL_PTR(cachep)))
- return cachep;
- return __cache_alloc(cachep, flags, caller);
+ ret = cachep;
+ else {
+ ret = __cache_alloc(cachep, flags, caller);
+ kmemtrace_mark_alloc(KMEMTRACE_KIND_KERNEL, caller, ret,
+ size, cachep->buffer_size, flags);
+ }
+
+ return ret;
}
-#ifdef CONFIG_DEBUG_SLAB
+#if defined(CONFIG_DEBUG_SLAB) || defined(CONFIG_KMEMTRACE)
void *__kmalloc(size_t size, gfp_t flags)
{
return __do_kmalloc(size, flags, __builtin_return_address(0));
@@ -3770,6 +3789,8 @@ void kmem_cache_free(struct kmem_cache *cachep, void *objp)
debug_check_no_obj_freed(objp, obj_size(cachep));
__cache_free(cachep, objp);
local_irq_restore(flags);
+
+ kmemtrace_mark_free(KMEMTRACE_KIND_CACHE, _RET_IP_, objp);
}
EXPORT_SYMBOL(kmem_cache_free);
@@ -3796,6 +3817,8 @@ void kfree(const void *objp)
debug_check_no_obj_freed(objp, obj_size(c));
__cache_free(c, (void *)objp);
local_irq_restore(flags);
+
+ kmemtrace_mark_free(KMEMTRACE_KIND_KERNEL, _RET_IP_, objp);
}
EXPORT_SYMBOL(kfree);
--
1.5.6.1
WARNING: multiple messages have this Message-ID (diff)
From: Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>
To: penberg@cs.helsinki.fi
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: [RFC PATCH 3/5] kmemtrace: SLAB hooks.
Date: Thu, 10 Jul 2008 21:06:11 +0300 [thread overview]
Message-ID: <20080710210611.7c194a70@linux360.ro> (raw)
In-Reply-To: <1215712946-23572-3-git-send-email-eduard.munteanu@linux360.ro>
This adds hooks for the SLAB allocator, to allow tracing with kmemtrace.
Signed-off-by: Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>
---
include/linux/slab_def.h | 16 +++++++++++++---
mm/slab.c | 35 +++++++++++++++++++++++++++++------
2 files changed, 42 insertions(+), 9 deletions(-)
diff --git a/include/linux/slab_def.h b/include/linux/slab_def.h
index 39c3a5e..89d0cca 100644
--- a/include/linux/slab_def.h
+++ b/include/linux/slab_def.h
@@ -14,6 +14,7 @@
#include <asm/page.h> /* kmalloc_sizes.h needs PAGE_SIZE */
#include <asm/cache.h> /* kmalloc_sizes.h needs L1_CACHE_BYTES */
#include <linux/compiler.h>
+#include <linux/kmemtrace.h>
/* Size description struct for general caches. */
struct cache_sizes {
@@ -30,6 +31,8 @@ void *__kmalloc(size_t size, gfp_t flags);
static inline void *kmalloc(size_t size, gfp_t flags)
{
+ void *ret;
+
if (__builtin_constant_p(size)) {
int i = 0;
@@ -50,10 +53,17 @@ static inline void *kmalloc(size_t size, gfp_t flags)
found:
#ifdef CONFIG_ZONE_DMA
if (flags & GFP_DMA)
- return kmem_cache_alloc(malloc_sizes[i].cs_dmacachep,
- flags);
+ ret = kmem_cache_alloc(malloc_sizes[i].cs_dmacachep,
+ flags | __GFP_NOTRACE);
+ else
#endif
- return kmem_cache_alloc(malloc_sizes[i].cs_cachep, flags);
+ ret = kmem_cache_alloc(malloc_sizes[i].cs_cachep,
+ flags | __GFP_NOTRACE);
+
+ kmemtrace_mark_alloc(KMEMTRACE_KIND_KERNEL, _THIS_IP_, ret,
+ size, malloc_sizes[i].cs_size, flags);
+
+ return ret;
}
return __kmalloc(size, flags);
}
diff --git a/mm/slab.c b/mm/slab.c
index 046607f..29f0599 100644
--- a/mm/slab.c
+++ b/mm/slab.c
@@ -111,6 +111,7 @@
#include <linux/rtmutex.h>
#include <linux/reciprocal_div.h>
#include <linux/debugobjects.h>
+#include <linux/kmemtrace.h>
#include <asm/cacheflush.h>
#include <asm/tlbflush.h>
@@ -3621,7 +3622,12 @@ static inline void __cache_free(struct kmem_cache *cachep, void *objp)
*/
void *kmem_cache_alloc(struct kmem_cache *cachep, gfp_t flags)
{
- return __cache_alloc(cachep, flags, __builtin_return_address(0));
+ void *ret = __cache_alloc(cachep, flags, __builtin_return_address(0));
+
+ kmemtrace_mark_alloc(KMEMTRACE_KIND_CACHE, _RET_IP_, ret,
+ obj_size(cachep), obj_size(cachep), flags);
+
+ return ret;
}
EXPORT_SYMBOL(kmem_cache_alloc);
@@ -3669,8 +3675,14 @@ out:
#ifdef CONFIG_NUMA
void *kmem_cache_alloc_node(struct kmem_cache *cachep, gfp_t flags, int nodeid)
{
- return __cache_alloc_node(cachep, flags, nodeid,
- __builtin_return_address(0));
+ void *ret = __cache_alloc_node(cachep, flags, nodeid,
+ __builtin_return_address(0));
+
+ kmemtrace_mark_alloc_node(KMEMTRACE_KIND_CACHE, _RET_IP_, ret,
+ obj_size(cachep), obj_size(cachep),
+ flags, nodeid);
+
+ return ret;
}
EXPORT_SYMBOL(kmem_cache_alloc_node);
@@ -3718,6 +3730,7 @@ static __always_inline void *__do_kmalloc(size_t size, gfp_t flags,
void *caller)
{
struct kmem_cache *cachep;
+ void *ret;
/* If you want to save a few bytes .text space: replace
* __ with kmem_.
@@ -3726,12 +3739,18 @@ static __always_inline void *__do_kmalloc(size_t size, gfp_t flags,
*/
cachep = __find_general_cachep(size, flags);
if (unlikely(ZERO_OR_NULL_PTR(cachep)))
- return cachep;
- return __cache_alloc(cachep, flags, caller);
+ ret = cachep;
+ else {
+ ret = __cache_alloc(cachep, flags, caller);
+ kmemtrace_mark_alloc(KMEMTRACE_KIND_KERNEL, caller, ret,
+ size, cachep->buffer_size, flags);
+ }
+
+ return ret;
}
-#ifdef CONFIG_DEBUG_SLAB
+#if defined(CONFIG_DEBUG_SLAB) || defined(CONFIG_KMEMTRACE)
void *__kmalloc(size_t size, gfp_t flags)
{
return __do_kmalloc(size, flags, __builtin_return_address(0));
@@ -3770,6 +3789,8 @@ void kmem_cache_free(struct kmem_cache *cachep, void *objp)
debug_check_no_obj_freed(objp, obj_size(cachep));
__cache_free(cachep, objp);
local_irq_restore(flags);
+
+ kmemtrace_mark_free(KMEMTRACE_KIND_CACHE, _RET_IP_, objp);
}
EXPORT_SYMBOL(kmem_cache_free);
@@ -3796,6 +3817,8 @@ void kfree(const void *objp)
debug_check_no_obj_freed(objp, obj_size(c));
__cache_free(c, (void *)objp);
local_irq_restore(flags);
+
+ kmemtrace_mark_free(KMEMTRACE_KIND_KERNEL, _RET_IP_, objp);
}
EXPORT_SYMBOL(kfree);
--
1.5.6.1
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-07-10 18:07 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1215712946-23572-1-git-send-email-eduard.munteanu@linux360.ro>
2008-07-10 18:05 ` [RFC PATCH 1/5] kmemtrace: Core implementation Eduard - Gabriel Munteanu
2008-07-10 18:05 ` Eduard - Gabriel Munteanu
2008-07-11 8:41 ` Pekka Enberg
2008-07-11 8:41 ` Pekka Enberg
2008-07-11 20:02 ` Eduard - Gabriel Munteanu
2008-07-11 20:02 ` Eduard - Gabriel Munteanu
[not found] ` <1215712946-23572-2-git-send-email-eduard.munteanu@linux360.ro>
2008-07-10 18:06 ` [RFC PATCH 2/5] Add new GFP flag __GFP_NOTRACE Eduard - Gabriel Munteanu
2008-07-10 18:06 ` Eduard - Gabriel Munteanu
2008-07-11 8:33 ` Pekka Enberg
2008-07-11 8:33 ` Pekka Enberg
2008-07-11 14:41 ` Christoph Lameter
2008-07-11 14:41 ` Christoph Lameter
2008-07-11 19:56 ` Eduard - Gabriel Munteanu
2008-07-11 19:56 ` Eduard - Gabriel Munteanu
[not found] ` <1215712946-23572-3-git-send-email-eduard.munteanu@linux360.ro>
2008-07-10 18:06 ` Eduard - Gabriel Munteanu [this message]
2008-07-10 18:06 ` [RFC PATCH 3/5] kmemtrace: SLAB hooks Eduard - Gabriel Munteanu
2008-07-11 8:49 ` Pekka Enberg
2008-07-11 8:49 ` Pekka Enberg
2008-07-12 19:04 ` [PATCH] " Eduard - Gabriel Munteanu
2008-07-12 19:04 ` Eduard - Gabriel Munteanu
2008-07-14 16:28 ` Pekka Enberg
2008-07-14 16:28 ` Pekka Enberg
2008-07-14 16:32 ` Christoph Lameter
2008-07-14 16:32 ` Christoph Lameter
2008-07-14 17:21 ` Eduard - Gabriel Munteanu
2008-07-14 17:21 ` Eduard - Gabriel Munteanu
2008-07-14 17:42 ` [RESEND PATCH] " Eduard - Gabriel Munteanu
2008-07-14 17:42 ` Eduard - Gabriel Munteanu
2008-07-14 18:19 ` Pekka Enberg
2008-07-14 18:19 ` Pekka Enberg
2008-07-14 18:37 ` eduard.munteanu
2008-07-14 18:37 ` eduard.munteanu
2008-07-15 7:17 ` Pekka Enberg
2008-07-15 7:17 ` Pekka Enberg
[not found] ` <1215712946-23572-4-git-send-email-eduard.munteanu@linux360.ro>
2008-07-10 18:06 ` [RFC PATCH 4/5] kmemtrace: SLUB hooks Eduard - Gabriel Munteanu
2008-07-10 18:06 ` Eduard - Gabriel Munteanu
2008-07-11 8:35 ` Pekka Enberg
2008-07-11 8:35 ` Pekka Enberg
2008-07-11 14:48 ` Christoph Lameter
2008-07-11 14:48 ` Christoph Lameter
2008-07-11 20:21 ` Eduard - Gabriel Munteanu
2008-07-11 20:21 ` Eduard - Gabriel Munteanu
2008-07-12 13:28 ` Eduard - Gabriel Munteanu
2008-07-12 13:28 ` Eduard - Gabriel Munteanu
2008-07-12 13:36 ` Eduard - Gabriel Munteanu
2008-07-12 13:36 ` Eduard - Gabriel Munteanu
2008-07-11 8:45 ` Pekka Enberg
2008-07-11 8:45 ` Pekka Enberg
2008-07-11 20:19 ` Eduard - Gabriel Munteanu
2008-07-11 20:19 ` Eduard - Gabriel Munteanu
2008-07-14 16:30 ` Pekka Enberg
2008-07-14 16:30 ` Pekka Enberg
[not found] ` <1215712946-23572-5-git-send-email-eduard.munteanu@linux360.ro>
2008-07-10 18:06 ` [RFC PATCH 5/5] kmemtrace: SLOB hooks Eduard - Gabriel Munteanu
2008-07-10 18:06 ` Eduard - Gabriel Munteanu
2008-07-11 8:44 ` Pekka Enberg
2008-07-11 8:44 ` Pekka Enberg
2008-07-11 15:36 ` Matt Mackall
2008-07-11 15:36 ` Matt Mackall
2008-07-11 20:14 ` Eduard - Gabriel Munteanu
2008-07-11 20:14 ` Eduard - Gabriel Munteanu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080710210611.7c194a70@linux360.ro \
--to=eduard.munteanu@linux360.ro \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.