All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Lameter <cl@linux-foundation.org>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] kmemtrace: SLAB hooks.
Date: Mon, 14 Jul 2008 11:32:25 -0500	[thread overview]
Message-ID: <487B7F99.4060004@linux-foundation.org> (raw)
In-Reply-To: <1216052893.6762.3.camel@penberg-laptop>

Pekka Enberg wrote:
> Hi Eduard-Gabriel,
> 
> On Sat, 2008-07-12 at 22:04 +0300, Eduard - Gabriel Munteanu wrote:
>> This adds hooks for the SLAB allocator, to allow tracing with kmemtrace.
>>
>> Signed-off-by: Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>
>> @@ -28,8 +29,20 @@ extern struct cache_sizes malloc_sizes[];
>>  void *kmem_cache_alloc(struct kmem_cache *, gfp_t);
>>  void *__kmalloc(size_t size, gfp_t flags);
>>  
>> +#ifdef CONFIG_KMEMTRACE
>> +extern void *__kmem_cache_alloc(struct kmem_cache *cachep, gfp_t flags);
>> +#else
>> +static inline void *__kmem_cache_alloc(struct kmem_cache *cachep,
>> +				       gfp_t flags)
>> +{
>> +	return __kmem_cache_alloc(cachep, flags);
> 
> Looks as if the function calls itself recursively?
> 

Code not tested? Are you sure you configured for slab?


WARNING: multiple messages have this Message-ID (diff)
From: Christoph Lameter <cl@linux-foundation.org>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] kmemtrace: SLAB hooks.
Date: Mon, 14 Jul 2008 11:32:25 -0500	[thread overview]
Message-ID: <487B7F99.4060004@linux-foundation.org> (raw)
In-Reply-To: <1216052893.6762.3.camel@penberg-laptop>

Pekka Enberg wrote:
> Hi Eduard-Gabriel,
> 
> On Sat, 2008-07-12 at 22:04 +0300, Eduard - Gabriel Munteanu wrote:
>> This adds hooks for the SLAB allocator, to allow tracing with kmemtrace.
>>
>> Signed-off-by: Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>
>> @@ -28,8 +29,20 @@ extern struct cache_sizes malloc_sizes[];
>>  void *kmem_cache_alloc(struct kmem_cache *, gfp_t);
>>  void *__kmalloc(size_t size, gfp_t flags);
>>  
>> +#ifdef CONFIG_KMEMTRACE
>> +extern void *__kmem_cache_alloc(struct kmem_cache *cachep, gfp_t flags);
>> +#else
>> +static inline void *__kmem_cache_alloc(struct kmem_cache *cachep,
>> +				       gfp_t flags)
>> +{
>> +	return __kmem_cache_alloc(cachep, flags);
> 
> Looks as if the function calls itself i>>?recursively?
> 

Code not tested? Are you sure you configured for slab?

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2008-07-14 16:33 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1215712946-23572-1-git-send-email-eduard.munteanu@linux360.ro>
2008-07-10 18:05 ` [RFC PATCH 1/5] kmemtrace: Core implementation Eduard - Gabriel Munteanu
2008-07-10 18:05   ` Eduard - Gabriel Munteanu
2008-07-11  8:41   ` Pekka Enberg
2008-07-11  8:41     ` Pekka Enberg
2008-07-11 20:02     ` Eduard - Gabriel Munteanu
2008-07-11 20:02       ` Eduard - Gabriel Munteanu
     [not found] ` <1215712946-23572-2-git-send-email-eduard.munteanu@linux360.ro>
2008-07-10 18:06   ` [RFC PATCH 2/5] Add new GFP flag __GFP_NOTRACE Eduard - Gabriel Munteanu
2008-07-10 18:06     ` Eduard - Gabriel Munteanu
2008-07-11  8:33     ` Pekka Enberg
2008-07-11  8:33       ` Pekka Enberg
2008-07-11 14:41     ` Christoph Lameter
2008-07-11 14:41       ` Christoph Lameter
2008-07-11 19:56       ` Eduard - Gabriel Munteanu
2008-07-11 19:56         ` Eduard - Gabriel Munteanu
     [not found]   ` <1215712946-23572-3-git-send-email-eduard.munteanu@linux360.ro>
2008-07-10 18:06     ` [RFC PATCH 3/5] kmemtrace: SLAB hooks Eduard - Gabriel Munteanu
2008-07-10 18:06       ` Eduard - Gabriel Munteanu
2008-07-11  8:49       ` Pekka Enberg
2008-07-11  8:49         ` Pekka Enberg
2008-07-12 19:04         ` [PATCH] " Eduard - Gabriel Munteanu
2008-07-12 19:04           ` Eduard - Gabriel Munteanu
2008-07-14 16:28           ` Pekka Enberg
2008-07-14 16:28             ` Pekka Enberg
2008-07-14 16:32             ` Christoph Lameter [this message]
2008-07-14 16:32               ` Christoph Lameter
2008-07-14 17:21               ` Eduard - Gabriel Munteanu
2008-07-14 17:21                 ` Eduard - Gabriel Munteanu
2008-07-14 17:42               ` [RESEND PATCH] " Eduard - Gabriel Munteanu
2008-07-14 17:42                 ` Eduard - Gabriel Munteanu
2008-07-14 18:19                 ` Pekka Enberg
2008-07-14 18:19                   ` Pekka Enberg
2008-07-14 18:37                   ` eduard.munteanu
2008-07-14 18:37                     ` eduard.munteanu
2008-07-15  7:17                     ` Pekka Enberg
2008-07-15  7:17                       ` Pekka Enberg
     [not found]     ` <1215712946-23572-4-git-send-email-eduard.munteanu@linux360.ro>
2008-07-10 18:06       ` [RFC PATCH 4/5] kmemtrace: SLUB hooks Eduard - Gabriel Munteanu
2008-07-10 18:06         ` Eduard - Gabriel Munteanu
2008-07-11  8:35         ` Pekka Enberg
2008-07-11  8:35           ` Pekka Enberg
2008-07-11 14:48           ` Christoph Lameter
2008-07-11 14:48             ` Christoph Lameter
2008-07-11 20:21             ` Eduard - Gabriel Munteanu
2008-07-11 20:21               ` Eduard - Gabriel Munteanu
2008-07-12 13:28             ` Eduard - Gabriel Munteanu
2008-07-12 13:28               ` Eduard - Gabriel Munteanu
2008-07-12 13:36               ` Eduard - Gabriel Munteanu
2008-07-12 13:36                 ` Eduard - Gabriel Munteanu
2008-07-11  8:45         ` Pekka Enberg
2008-07-11  8:45           ` Pekka Enberg
2008-07-11 20:19           ` Eduard - Gabriel Munteanu
2008-07-11 20:19             ` Eduard - Gabriel Munteanu
2008-07-14 16:30             ` Pekka Enberg
2008-07-14 16:30               ` Pekka Enberg
     [not found]       ` <1215712946-23572-5-git-send-email-eduard.munteanu@linux360.ro>
2008-07-10 18:06         ` [RFC PATCH 5/5] kmemtrace: SLOB hooks Eduard - Gabriel Munteanu
2008-07-10 18:06           ` Eduard - Gabriel Munteanu
2008-07-11  8:44           ` Pekka Enberg
2008-07-11  8:44             ` Pekka Enberg
2008-07-11 15:36             ` Matt Mackall
2008-07-11 15:36               ` Matt Mackall
2008-07-11 20:14               ` Eduard - Gabriel Munteanu
2008-07-11 20:14                 ` Eduard - Gabriel Munteanu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=487B7F99.4060004@linux-foundation.org \
    --to=cl@linux-foundation.org \
    --cc=eduard.munteanu@linux360.ro \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=penberg@cs.helsinki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.