From: Grant Likely <grant.likely@secretlab.ca>
To: Anton Vorontsov <avorontsov@ru.mvista.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] of/i2c: don't pass -1 to irq_dispose_mapping, otherwise kernel will oops
Date: Fri, 11 Jul 2008 15:18:13 -0600 [thread overview]
Message-ID: <20080711211813.GC18239@secretlab.ca> (raw)
In-Reply-To: <20080711191930.GA23723@polina.dev.rtsoft.ru>
On Fri, Jul 11, 2008 at 11:19:30PM +0400, Anton Vorontsov wrote:
> On Fri, Jul 11, 2008 at 09:11:02PM +0200, Jochen Friedrich wrote:
> >
> > Shouldn't this be:
> > if (info.irq != NO_IRQ)
>
> Maybe, maybe not. See
>
> http://lkml.org/lkml/2005/11/21/211
>
> I.e. maybe we should use "if (irq)". Or if we should use NO_IRQ, then we
> need to fixup all the users of .irq.
Yes, these are definitely wrong and need to be fixed.
g.
next prev parent reply other threads:[~2008-07-11 21:18 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-11 17:48 [PATCH] of/i2c: don't pass -1 to irq_dispose_mapping, otherwise kernel will oops Anton Vorontsov
2008-07-11 18:14 ` Anton Vorontsov
2008-07-11 18:23 ` Grant Likely
2008-07-11 18:55 ` Anton Vorontsov
[not found] ` <20080711182323.GB15321-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
2008-07-11 19:01 ` Jochen Friedrich
2008-07-11 19:01 ` Jochen Friedrich
2008-07-11 19:15 ` Anton Vorontsov
[not found] ` <20080711191502.GA21847-PHTr8nzUCjejyJ0x5qLZdcN33GVbZNy3@public.gmane.org>
2008-07-12 8:22 ` Wolfram Sang
2008-07-12 8:22 ` [i2c] " Wolfram Sang
2008-07-12 8:00 ` Wolfram Sang
2008-07-12 8:00 ` Wolfram Sang
2008-07-13 3:59 ` Jon Smirl
[not found] ` <20080712080004.GA16739-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2008-07-16 22:20 ` Grant Likely
2008-07-16 22:20 ` [i2c] " Grant Likely
2008-07-11 19:11 ` Jochen Friedrich
2008-07-11 19:19 ` Anton Vorontsov
2008-07-11 21:18 ` Grant Likely [this message]
2008-07-11 21:46 ` Anton Vorontsov
2008-07-11 22:08 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080711211813.GC18239@secretlab.ca \
--to=grant.likely@secretlab.ca \
--cc=avorontsov@ru.mvista.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.