All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jochen Friedrich <jochen-NIgtFMG+Po8@public.gmane.org>
To: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
Cc: linuxppc-dev-mnsaURCQ41sdnm+yROfE0A@public.gmane.org,
	Anton Vorontsov
	<avorontsov-hkdhdckH98+B+jHODAdFcQ@public.gmane.org>,
	i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
Subject: Re: [PATCH] of/i2c: don't pass -1 to irq_dispose_mapping, otherwise kernel will oops
Date: Fri, 11 Jul 2008 21:01:10 +0200	[thread overview]
Message-ID: <4877ADF6.8070702@scram.de> (raw)
In-Reply-To: <20080711182323.GB15321-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>

Hi Grant,

> What is the reason that info.irq is set to -1 in the first place?  This
> looks like another bug to me.  Does something in the i2c layer depend on
> the -1 value?

Nope, it was a bug in the i2c documentation fixed recently:

http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=8e29da9ee8958cc17e27f4053420f1c982614793

Thanks,
Jochen

_______________________________________________
i2c mailing list
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
http://lists.lm-sensors.org/mailman/listinfo/i2c

WARNING: multiple messages have this Message-ID (diff)
From: Jochen Friedrich <jochen@scram.de>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: khali@linux-fr.org, linuxppc-dev@ozlabs.org, i2c@lm-sensors.org
Subject: Re: [PATCH] of/i2c: don't pass -1 to irq_dispose_mapping,	otherwise kernel will oops
Date: Fri, 11 Jul 2008 21:01:10 +0200	[thread overview]
Message-ID: <4877ADF6.8070702@scram.de> (raw)
In-Reply-To: <20080711182323.GB15321@secretlab.ca>

Hi Grant,

> What is the reason that info.irq is set to -1 in the first place?  This
> looks like another bug to me.  Does something in the i2c layer depend on
> the -1 value?

Nope, it was a bug in the i2c documentation fixed recently:

http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=8e29da9ee8958cc17e27f4053420f1c982614793

Thanks,
Jochen

  parent reply	other threads:[~2008-07-11 19:01 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-11 17:48 [PATCH] of/i2c: don't pass -1 to irq_dispose_mapping, otherwise kernel will oops Anton Vorontsov
2008-07-11 18:14 ` Anton Vorontsov
2008-07-11 18:23 ` Grant Likely
2008-07-11 18:55   ` Anton Vorontsov
     [not found]   ` <20080711182323.GB15321-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
2008-07-11 19:01     ` Jochen Friedrich [this message]
2008-07-11 19:01       ` Jochen Friedrich
2008-07-11 19:15       ` Anton Vorontsov
     [not found]         ` <20080711191502.GA21847-PHTr8nzUCjejyJ0x5qLZdcN33GVbZNy3@public.gmane.org>
2008-07-12  8:22           ` Wolfram Sang
2008-07-12  8:22             ` [i2c] " Wolfram Sang
2008-07-12  8:00   ` Wolfram Sang
2008-07-12  8:00     ` Wolfram Sang
2008-07-13  3:59     ` Jon Smirl
     [not found]     ` <20080712080004.GA16739-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2008-07-16 22:20       ` Grant Likely
2008-07-16 22:20         ` [i2c] " Grant Likely
2008-07-11 19:11 ` Jochen Friedrich
2008-07-11 19:19   ` Anton Vorontsov
2008-07-11 21:18     ` Grant Likely
2008-07-11 21:46       ` Anton Vorontsov
2008-07-11 22:08         ` Grant Likely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4877ADF6.8070702@scram.de \
    --to=jochen-nigtfmg+po8@public.gmane.org \
    --cc=avorontsov-hkdhdckH98+B+jHODAdFcQ@public.gmane.org \
    --cc=grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org \
    --cc=i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org \
    --cc=linuxppc-dev-mnsaURCQ41sdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.