* [PATCH] powerpc/ep8248e: Fix compile problem if !CONFIG_FS_ENET
@ 2008-07-16 13:39 ` Kumar Gala
0 siblings, 0 replies; 16+ messages in thread
From: Kumar Gala @ 2008-07-16 13:39 UTC (permalink / raw)
To: linuxppc-dev; +Cc: davej, akpm, torvalds, linux-kernel
If we don't enable FS_ENET we get build issues:
arch/powerpc/platforms/built-in.o: In function `ep8248e_mdio_probe':
arch/powerpc/platforms/82xx/ep8248e.c:129: undefined reference to `alloc_mdio_bitbang'
arch/powerpc/platforms/82xx/ep8248e.c:143: undefined reference to `mdiobus_register'
Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
---
In my powerpc-next tree.
- k
arch/powerpc/platforms/82xx/ep8248e.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/arch/powerpc/platforms/82xx/ep8248e.c b/arch/powerpc/platforms/82xx/ep8248e.c
index d5770fd..373e993 100644
--- a/arch/powerpc/platforms/82xx/ep8248e.c
+++ b/arch/powerpc/platforms/82xx/ep8248e.c
@@ -59,6 +59,7 @@ static void __init ep8248e_pic_init(void)
of_node_put(np);
}
+#ifdef CONFIG_FS_ENET_MDIO_FCC
static void ep8248e_set_mdc(struct mdiobb_ctrl *ctrl, int level)
{
if (level)
@@ -164,6 +165,7 @@ static struct of_platform_driver ep8248e_mdio_driver = {
.probe = ep8248e_mdio_probe,
.remove = ep8248e_mdio_remove,
};
+#endif
struct cpm_pin {
int port, pin, flags;
@@ -296,7 +298,9 @@ static __initdata struct of_device_id of_bus_ids[] = {
static int __init declare_of_platform_devices(void)
{
of_platform_bus_probe(NULL, of_bus_ids, NULL);
+#ifdef CONFIG_FS_ENET_MDIO_FCC
of_register_platform_driver(&ep8248e_mdio_driver);
+#endif
return 0;
}
--
1.5.5.1
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH] powerpc/ep8248e: Fix compile problem if !CONFIG_FS_ENET
@ 2008-07-16 13:39 ` Kumar Gala
0 siblings, 0 replies; 16+ messages in thread
From: Kumar Gala @ 2008-07-16 13:39 UTC (permalink / raw)
To: linuxppc-dev; +Cc: davej, Benjamin Herrenschmidt, akpm, torvalds, linux-kernel
If we don't enable FS_ENET we get build issues:
arch/powerpc/platforms/built-in.o: In function `ep8248e_mdio_probe':
arch/powerpc/platforms/82xx/ep8248e.c:129: undefined reference to `alloc_mdio_bitbang'
arch/powerpc/platforms/82xx/ep8248e.c:143: undefined reference to `mdiobus_register'
Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
---
In my powerpc-next tree.
- k
arch/powerpc/platforms/82xx/ep8248e.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/arch/powerpc/platforms/82xx/ep8248e.c b/arch/powerpc/platforms/82xx/ep8248e.c
index d5770fd..373e993 100644
--- a/arch/powerpc/platforms/82xx/ep8248e.c
+++ b/arch/powerpc/platforms/82xx/ep8248e.c
@@ -59,6 +59,7 @@ static void __init ep8248e_pic_init(void)
of_node_put(np);
}
+#ifdef CONFIG_FS_ENET_MDIO_FCC
static void ep8248e_set_mdc(struct mdiobb_ctrl *ctrl, int level)
{
if (level)
@@ -164,6 +165,7 @@ static struct of_platform_driver ep8248e_mdio_driver = {
.probe = ep8248e_mdio_probe,
.remove = ep8248e_mdio_remove,
};
+#endif
struct cpm_pin {
int port, pin, flags;
@@ -296,7 +298,9 @@ static __initdata struct of_device_id of_bus_ids[] = {
static int __init declare_of_platform_devices(void)
{
of_platform_bus_probe(NULL, of_bus_ids, NULL);
+#ifdef CONFIG_FS_ENET_MDIO_FCC
of_register_platform_driver(&ep8248e_mdio_driver);
+#endif
return 0;
}
--
1.5.5.1
^ permalink raw reply related [flat|nested] 16+ messages in thread* Re: [PATCH] powerpc/ep8248e: Fix compile problem if !CONFIG_FS_ENET
2008-07-16 13:39 ` Kumar Gala
@ 2008-07-16 21:47 ` Scott Wood
-1 siblings, 0 replies; 16+ messages in thread
From: Scott Wood @ 2008-07-16 21:47 UTC (permalink / raw)
To: Kumar Gala; +Cc: linuxppc-dev, akpm, torvalds, linux-kernel, davej
On Wed, Jul 16, 2008 at 08:39:12AM -0500, Kumar Gala wrote:
> If we don't enable FS_ENET we get build issues:
>
> arch/powerpc/platforms/built-in.o: In function `ep8248e_mdio_probe':
> arch/powerpc/platforms/82xx/ep8248e.c:129: undefined reference to `alloc_mdio_bitbang'
> arch/powerpc/platforms/82xx/ep8248e.c:143: undefined reference to `mdiobus_register'
How is this possible? CONFIG_EP8248E selects CONFIG_MDIO_BITBANG.
> +#ifdef CONFIG_FS_ENET_MDIO_FCC
> static void ep8248e_set_mdc(struct mdiobb_ctrl *ctrl, int level)
> {
> if (level)
> @@ -164,6 +165,7 @@ static struct of_platform_driver ep8248e_mdio_driver = {
> .probe = ep8248e_mdio_probe,
> .remove = ep8248e_mdio_remove,
> };
> +#endif
This is wrong -- ep8248e doesn't use the FS_ENET_MDIO_FCC code.
-Scott
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PATCH] powerpc/ep8248e: Fix compile problem if !CONFIG_FS_ENET
@ 2008-07-16 21:47 ` Scott Wood
0 siblings, 0 replies; 16+ messages in thread
From: Scott Wood @ 2008-07-16 21:47 UTC (permalink / raw)
To: Kumar Gala; +Cc: linuxppc-dev, davej, akpm, torvalds, linux-kernel
On Wed, Jul 16, 2008 at 08:39:12AM -0500, Kumar Gala wrote:
> If we don't enable FS_ENET we get build issues:
>
> arch/powerpc/platforms/built-in.o: In function `ep8248e_mdio_probe':
> arch/powerpc/platforms/82xx/ep8248e.c:129: undefined reference to `alloc_mdio_bitbang'
> arch/powerpc/platforms/82xx/ep8248e.c:143: undefined reference to `mdiobus_register'
How is this possible? CONFIG_EP8248E selects CONFIG_MDIO_BITBANG.
> +#ifdef CONFIG_FS_ENET_MDIO_FCC
> static void ep8248e_set_mdc(struct mdiobb_ctrl *ctrl, int level)
> {
> if (level)
> @@ -164,6 +165,7 @@ static struct of_platform_driver ep8248e_mdio_driver = {
> .probe = ep8248e_mdio_probe,
> .remove = ep8248e_mdio_remove,
> };
> +#endif
This is wrong -- ep8248e doesn't use the FS_ENET_MDIO_FCC code.
-Scott
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PATCH] powerpc/ep8248e: Fix compile problem if !CONFIG_FS_ENET
2008-07-16 21:47 ` Scott Wood
@ 2008-07-16 21:57 ` Dave Jones
-1 siblings, 0 replies; 16+ messages in thread
From: Dave Jones @ 2008-07-16 21:57 UTC (permalink / raw)
To: Scott Wood; +Cc: linuxppc-dev, akpm, torvalds, linux-kernel
On Wed, Jul 16, 2008 at 04:47:23PM -0500, Scott Wood wrote:
> On Wed, Jul 16, 2008 at 08:39:12AM -0500, Kumar Gala wrote:
> > If we don't enable FS_ENET we get build issues:
> >
> > arch/powerpc/platforms/built-in.o: In function `ep8248e_mdio_probe':
> > arch/powerpc/platforms/82xx/ep8248e.c:129: undefined reference to `alloc_mdio_bitbang'
> > arch/powerpc/platforms/82xx/ep8248e.c:143: undefined reference to `mdiobus_register'
>
> How is this possible? CONFIG_EP8248E selects CONFIG_MDIO_BITBANG.
If CONFIG_PHYLIB=m however, that doesn't make any difference, because
vmlinuz is trying to use a symbol which now lives in a module.
Dave
--
http://www.codemonkey.org.uk
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] powerpc/ep8248e: Fix compile problem if !CONFIG_FS_ENET
@ 2008-07-16 21:57 ` Dave Jones
0 siblings, 0 replies; 16+ messages in thread
From: Dave Jones @ 2008-07-16 21:57 UTC (permalink / raw)
To: Scott Wood; +Cc: Kumar Gala, linuxppc-dev, akpm, torvalds, linux-kernel
On Wed, Jul 16, 2008 at 04:47:23PM -0500, Scott Wood wrote:
> On Wed, Jul 16, 2008 at 08:39:12AM -0500, Kumar Gala wrote:
> > If we don't enable FS_ENET we get build issues:
> >
> > arch/powerpc/platforms/built-in.o: In function `ep8248e_mdio_probe':
> > arch/powerpc/platforms/82xx/ep8248e.c:129: undefined reference to `alloc_mdio_bitbang'
> > arch/powerpc/platforms/82xx/ep8248e.c:143: undefined reference to `mdiobus_register'
>
> How is this possible? CONFIG_EP8248E selects CONFIG_MDIO_BITBANG.
If CONFIG_PHYLIB=m however, that doesn't make any difference, because
vmlinuz is trying to use a symbol which now lives in a module.
Dave
--
http://www.codemonkey.org.uk
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] powerpc/ep8248e: Fix compile problem if !CONFIG_FS_ENET
2008-07-16 21:57 ` Dave Jones
(?)
@ 2008-07-16 22:10 ` Kumar Gala
2008-07-16 22:19 ` Dave Jones
2008-07-16 22:23 ` Kumar Gala
-1 siblings, 2 replies; 16+ messages in thread
From: Kumar Gala @ 2008-07-16 22:10 UTC (permalink / raw)
To: Dave Jones; +Cc: Scott Wood, linuxppc-dev, akpm, torvalds, linux-kernel
On Jul 16, 2008, at 4:57 PM, Dave Jones wrote:
> On Wed, Jul 16, 2008 at 04:47:23PM -0500, Scott Wood wrote:
>> On Wed, Jul 16, 2008 at 08:39:12AM -0500, Kumar Gala wrote:
>>> If we don't enable FS_ENET we get build issues:
>>>
>>> arch/powerpc/platforms/built-in.o: In function `ep8248e_mdio_probe':
>>> arch/powerpc/platforms/82xx/ep8248e.c:129: undefined reference to
>>> `alloc_mdio_bitbang'
>>> arch/powerpc/platforms/82xx/ep8248e.c:143: undefined reference to
>>> `mdiobus_register'
>>
>> How is this possible? CONFIG_EP8248E selects CONFIG_MDIO_BITBANG.
>
> If CONFIG_PHYLIB=m however, that doesn't make any difference, because
> vmlinuz is trying to use a symbol which now lives in a module.
The mdiobus_register make sense, I'm not sure get why
alloc_mdio_bitbang is undefined.
- k
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] powerpc/ep8248e: Fix compile problem if !CONFIG_FS_ENET
2008-07-16 22:10 ` Kumar Gala
@ 2008-07-16 22:19 ` Dave Jones
2008-07-16 22:55 ` Kumar Gala
2008-07-16 22:23 ` Kumar Gala
1 sibling, 1 reply; 16+ messages in thread
From: Dave Jones @ 2008-07-16 22:19 UTC (permalink / raw)
To: Kumar Gala; +Cc: Scott Wood, linuxppc-dev, akpm, torvalds, linux-kernel
On Wed, Jul 16, 2008 at 05:10:29PM -0500, Kumar Gala wrote:
>
> On Jul 16, 2008, at 4:57 PM, Dave Jones wrote:
>
> > On Wed, Jul 16, 2008 at 04:47:23PM -0500, Scott Wood wrote:
> >> On Wed, Jul 16, 2008 at 08:39:12AM -0500, Kumar Gala wrote:
> >>> If we don't enable FS_ENET we get build issues:
> >>>
> >>> arch/powerpc/platforms/built-in.o: In function `ep8248e_mdio_probe':
> >>> arch/powerpc/platforms/82xx/ep8248e.c:129: undefined reference to
> >>> `alloc_mdio_bitbang'
> >>> arch/powerpc/platforms/82xx/ep8248e.c:143: undefined reference to
> >>> `mdiobus_register'
> >>
> >> How is this possible? CONFIG_EP8248E selects CONFIG_MDIO_BITBANG.
> >
> > If CONFIG_PHYLIB=m however, that doesn't make any difference, because
> > vmlinuz is trying to use a symbol which now lives in a module.
>
> The mdiobus_register make sense, I'm not sure get why
> alloc_mdio_bitbang is undefined.
Erm, same reason. it's built into phy.o, which ends up in the module,
not the vmlinuz.
(also, it doesn't look like it's exported even if it was built-in?)
Dave
--
http://www.codemonkey.org.uk
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] powerpc/ep8248e: Fix compile problem if !CONFIG_FS_ENET
2008-07-16 22:19 ` Dave Jones
@ 2008-07-16 22:55 ` Kumar Gala
2008-07-21 16:14 ` Scott Wood
0 siblings, 1 reply; 16+ messages in thread
From: Kumar Gala @ 2008-07-16 22:55 UTC (permalink / raw)
To: Dave Jones; +Cc: Scott Wood, linuxppc-dev, akpm, torvalds, linux-kernel
On Jul 16, 2008, at 5:19 PM, Dave Jones wrote:
> On Wed, Jul 16, 2008 at 05:10:29PM -0500, Kumar Gala wrote:
>>
>> On Jul 16, 2008, at 4:57 PM, Dave Jones wrote:
>>
>>> On Wed, Jul 16, 2008 at 04:47:23PM -0500, Scott Wood wrote:
>>>> On Wed, Jul 16, 2008 at 08:39:12AM -0500, Kumar Gala wrote:
>>>>> If we don't enable FS_ENET we get build issues:
>>>>>
>>>>> arch/powerpc/platforms/built-in.o: In function
>>>>> `ep8248e_mdio_probe':
>>>>> arch/powerpc/platforms/82xx/ep8248e.c:129: undefined reference to
>>>>> `alloc_mdio_bitbang'
>>>>> arch/powerpc/platforms/82xx/ep8248e.c:143: undefined reference to
>>>>> `mdiobus_register'
>>>>
>>>> How is this possible? CONFIG_EP8248E selects CONFIG_MDIO_BITBANG.
>>>
>>> If CONFIG_PHYLIB=m however, that doesn't make any difference,
>>> because
>>> vmlinuz is trying to use a symbol which now lives in a module.
>>
>> The mdiobus_register make sense, I'm not sure get why
>> alloc_mdio_bitbang is undefined.
>
> Erm, same reason. it's built into phy.o, which ends up in the module,
> not the vmlinuz.
>
> (also, it doesn't look like it's exported even if it was built-in?)
It looks like the simplest solution at this point is to
unconditionally select the PHYLIB for this board. We should look at
moving the low level mdio bitbang ops out so they can be built as a
module.
- k
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] powerpc/ep8248e: Fix compile problem if !CONFIG_FS_ENET
2008-07-16 22:55 ` Kumar Gala
@ 2008-07-21 16:14 ` Scott Wood
0 siblings, 0 replies; 16+ messages in thread
From: Scott Wood @ 2008-07-21 16:14 UTC (permalink / raw)
To: Kumar Gala; +Cc: Dave Jones, akpm, torvalds, linux-kernel, linuxppc-dev
On Wed, Jul 16, 2008 at 05:55:17PM -0500, Kumar Gala wrote:
> It looks like the simplest solution at this point is to unconditionally
> select the PHYLIB for this board. We should look at moving the low level
> mdio bitbang ops out so they can be built as a module.
Or exporting the MDIO/MDC pins through the GPIO API.
-Scott
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] powerpc/ep8248e: Fix compile problem if !CONFIG_FS_ENET
@ 2008-07-21 16:14 ` Scott Wood
0 siblings, 0 replies; 16+ messages in thread
From: Scott Wood @ 2008-07-21 16:14 UTC (permalink / raw)
To: Kumar Gala; +Cc: Dave Jones, linuxppc-dev, akpm, torvalds, linux-kernel
On Wed, Jul 16, 2008 at 05:55:17PM -0500, Kumar Gala wrote:
> It looks like the simplest solution at this point is to unconditionally
> select the PHYLIB for this board. We should look at moving the low level
> mdio bitbang ops out so they can be built as a module.
Or exporting the MDIO/MDC pins through the GPIO API.
-Scott
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] powerpc/ep8248e: Fix compile problem if !CONFIG_FS_ENET
2008-07-16 22:10 ` Kumar Gala
@ 2008-07-16 22:23 ` Kumar Gala
2008-07-16 22:23 ` Kumar Gala
1 sibling, 0 replies; 16+ messages in thread
From: Kumar Gala @ 2008-07-16 22:23 UTC (permalink / raw)
To: Kumar Gala
Cc: linux-kernel, linuxppc-dev, Scott Wood, Dave Jones, akpm,
torvalds
On Jul 16, 2008, at 5:10 PM, Kumar Gala wrote:
>
> On Jul 16, 2008, at 4:57 PM, Dave Jones wrote:
>
>> On Wed, Jul 16, 2008 at 04:47:23PM -0500, Scott Wood wrote:
>>> On Wed, Jul 16, 2008 at 08:39:12AM -0500, Kumar Gala wrote:
>>>> If we don't enable FS_ENET we get build issues:
>>>>
>>>> arch/powerpc/platforms/built-in.o: In function
>>>> `ep8248e_mdio_probe':
>>>> arch/powerpc/platforms/82xx/ep8248e.c:129: undefined reference to
>>>> `alloc_mdio_bitbang'
>>>> arch/powerpc/platforms/82xx/ep8248e.c:143: undefined reference to
>>>> `mdiobus_register'
>>>
>>> How is this possible? CONFIG_EP8248E selects CONFIG_MDIO_BITBANG.
>>
>> If CONFIG_PHYLIB=m however, that doesn't make any difference, because
>> vmlinuz is trying to use a symbol which now lives in a module.
>
> The mdiobus_register make sense, I'm not sure get why
> alloc_mdio_bitbang is undefined.
nevermind, I now see why the libphy is being built.
- k
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] powerpc/ep8248e: Fix compile problem if !CONFIG_FS_ENET
@ 2008-07-16 22:23 ` Kumar Gala
0 siblings, 0 replies; 16+ messages in thread
From: Kumar Gala @ 2008-07-16 22:23 UTC (permalink / raw)
To: Kumar Gala
Cc: Dave Jones, Scott Wood, linuxppc-dev, akpm, torvalds,
linux-kernel
On Jul 16, 2008, at 5:10 PM, Kumar Gala wrote:
>
> On Jul 16, 2008, at 4:57 PM, Dave Jones wrote:
>
>> On Wed, Jul 16, 2008 at 04:47:23PM -0500, Scott Wood wrote:
>>> On Wed, Jul 16, 2008 at 08:39:12AM -0500, Kumar Gala wrote:
>>>> If we don't enable FS_ENET we get build issues:
>>>>
>>>> arch/powerpc/platforms/built-in.o: In function
>>>> `ep8248e_mdio_probe':
>>>> arch/powerpc/platforms/82xx/ep8248e.c:129: undefined reference to
>>>> `alloc_mdio_bitbang'
>>>> arch/powerpc/platforms/82xx/ep8248e.c:143: undefined reference to
>>>> `mdiobus_register'
>>>
>>> How is this possible? CONFIG_EP8248E selects CONFIG_MDIO_BITBANG.
>>
>> If CONFIG_PHYLIB=m however, that doesn't make any difference, because
>> vmlinuz is trying to use a symbol which now lives in a module.
>
> The mdiobus_register make sense, I'm not sure get why
> alloc_mdio_bitbang is undefined.
nevermind, I now see why the libphy is being built.
- k
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] powerpc/ep8248e: Fix compile problem if !CONFIG_FS_ENET
2008-07-16 21:57 ` Dave Jones
(?)
(?)
@ 2008-07-21 16:13 ` Scott Wood
-1 siblings, 0 replies; 16+ messages in thread
From: Scott Wood @ 2008-07-21 16:13 UTC (permalink / raw)
To: Dave Jones, Kumar Gala, linuxppc-dev, akpm, torvalds,
linux-kernel
On Wed, Jul 16, 2008 at 05:57:45PM -0400, Dave Jones wrote:
> On Wed, Jul 16, 2008 at 04:47:23PM -0500, Scott Wood wrote:
> > On Wed, Jul 16, 2008 at 08:39:12AM -0500, Kumar Gala wrote:
> > > If we don't enable FS_ENET we get build issues:
> > >
> > > arch/powerpc/platforms/built-in.o: In function `ep8248e_mdio_probe':
> > > arch/powerpc/platforms/82xx/ep8248e.c:129: undefined reference to `alloc_mdio_bitbang'
> > > arch/powerpc/platforms/82xx/ep8248e.c:143: undefined reference to `mdiobus_register'
> >
> > How is this possible? CONFIG_EP8248E selects CONFIG_MDIO_BITBANG.
>
> If CONFIG_PHYLIB=m however, that doesn't make any difference, because
> vmlinuz is trying to use a symbol which now lives in a module.
Yuck. If FOO selects BAR, and FOO is 'y', then BAR should be 'y', not 'm'.
If BAR depends on other symbols that are 'm', they should be changed to 'y'.
-Scott
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] powerpc/ep8248e: Fix compile problem if !CONFIG_FS_ENET
2008-07-16 21:47 ` Scott Wood
@ 2008-07-16 22:01 ` Kumar Gala
-1 siblings, 0 replies; 16+ messages in thread
From: Kumar Gala @ 2008-07-16 22:01 UTC (permalink / raw)
To: Scott Wood; +Cc: linuxppc-dev, akpm, torvalds, linux-kernel, davej
On Jul 16, 2008, at 4:47 PM, Scott Wood wrote:
> On Wed, Jul 16, 2008 at 08:39:12AM -0500, Kumar Gala wrote:
>> If we don't enable FS_ENET we get build issues:
>>
>> arch/powerpc/platforms/built-in.o: In function `ep8248e_mdio_probe':
>> arch/powerpc/platforms/82xx/ep8248e.c:129: undefined reference to
>> `alloc_mdio_bitbang'
>> arch/powerpc/platforms/82xx/ep8248e.c:143: undefined reference to
>> `mdiobus_register'
>
> How is this possible? CONFIG_EP8248E selects CONFIG_MDIO_BITBANG.
>
>> +#ifdef CONFIG_FS_ENET_MDIO_FCC
>> static void ep8248e_set_mdc(struct mdiobb_ctrl *ctrl, int level)
>> {
>> if (level)
>> @@ -164,6 +165,7 @@ static struct of_platform_driver
>> ep8248e_mdio_driver = {
>> .probe = ep8248e_mdio_probe,
>> .remove = ep8248e_mdio_remove,
>> };
>> +#endif
>
> This is wrong -- ep8248e doesn't use the FS_ENET_MDIO_FCC code.
You're correct this should be CONFIG_MDIO_BITBANG
- k
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PATCH] powerpc/ep8248e: Fix compile problem if !CONFIG_FS_ENET
@ 2008-07-16 22:01 ` Kumar Gala
0 siblings, 0 replies; 16+ messages in thread
From: Kumar Gala @ 2008-07-16 22:01 UTC (permalink / raw)
To: Scott Wood; +Cc: linuxppc-dev, davej, akpm, torvalds, linux-kernel
On Jul 16, 2008, at 4:47 PM, Scott Wood wrote:
> On Wed, Jul 16, 2008 at 08:39:12AM -0500, Kumar Gala wrote:
>> If we don't enable FS_ENET we get build issues:
>>
>> arch/powerpc/platforms/built-in.o: In function `ep8248e_mdio_probe':
>> arch/powerpc/platforms/82xx/ep8248e.c:129: undefined reference to
>> `alloc_mdio_bitbang'
>> arch/powerpc/platforms/82xx/ep8248e.c:143: undefined reference to
>> `mdiobus_register'
>
> How is this possible? CONFIG_EP8248E selects CONFIG_MDIO_BITBANG.
>
>> +#ifdef CONFIG_FS_ENET_MDIO_FCC
>> static void ep8248e_set_mdc(struct mdiobb_ctrl *ctrl, int level)
>> {
>> if (level)
>> @@ -164,6 +165,7 @@ static struct of_platform_driver
>> ep8248e_mdio_driver = {
>> .probe = ep8248e_mdio_probe,
>> .remove = ep8248e_mdio_remove,
>> };
>> +#endif
>
> This is wrong -- ep8248e doesn't use the FS_ENET_MDIO_FCC code.
You're correct this should be CONFIG_MDIO_BITBANG
- k
^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2008-07-21 16:16 UTC | newest]
Thread overview: 16+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-07-16 13:39 [PATCH] powerpc/ep8248e: Fix compile problem if !CONFIG_FS_ENET Kumar Gala
2008-07-16 13:39 ` Kumar Gala
2008-07-16 21:47 ` Scott Wood
2008-07-16 21:47 ` Scott Wood
2008-07-16 21:57 ` Dave Jones
2008-07-16 21:57 ` Dave Jones
2008-07-16 22:10 ` Kumar Gala
2008-07-16 22:19 ` Dave Jones
2008-07-16 22:55 ` Kumar Gala
2008-07-21 16:14 ` Scott Wood
2008-07-21 16:14 ` Scott Wood
2008-07-16 22:23 ` Kumar Gala
2008-07-16 22:23 ` Kumar Gala
2008-07-21 16:13 ` Scott Wood
2008-07-16 22:01 ` Kumar Gala
2008-07-16 22:01 ` Kumar Gala
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.