Re: [Xen-changelog] [xen-unstable] libxc: Clean up xc_map_foreign_ranges() interface to hide the

[Samuel Thibault <samuel.thibault@eu.citrix.com>]

Samuel Thibault, le Wed 23 Jul 2008 16:59:41 +0100, a écrit :
> Xen patchbot-unstable, le Wed 23 Jul 2008 08:50:44 -0700, a écrit :
> > diff -r 351ce3b94e2d -r 7299346111fb tools/libxc/xc_private.h
> > --- a/tools/libxc/xc_private.h	Wed Jul 23 13:31:57 2008 +0100
> > +++ b/tools/libxc/xc_private.h	Wed Jul 23 16:39:46 2008 +0100
> > @@ -184,8 +184,9 @@ static inline int do_sysctl(int xc_handl
> >      return ret;
> >  }
> >  
> > -int xc_map_foreign_ranges(int xc_handle, uint32_t dom,
> > -                          privcmd_mmap_entry_t *entries, int nr);
> > +void *xc_map_foreign_ranges(int xc_handle, uint32_t dom,
> > +                            size_t size, int prot, size_t chunksize,
> > +                            privcmd_mmap_entry_t entries[], int nentries);
> 
> Mmm, why chunksize?  Shouldn't entries[] provide it, for a more powerful
> interface (each entry can have a different size)?

Also, the size argument is redundant.

Samuel