* Re: [Xen-changelog] [xen-unstable] libxc: Clean up xc_map_foreign_ranges() interface to hide the [not found] <200807231550.m6NFoicJ028399@xenbits.xensource.com> @ 2008-07-23 15:59 ` Samuel Thibault 2008-07-23 16:02 ` Samuel Thibault 0 siblings, 1 reply; 2+ messages in thread From: Samuel Thibault @ 2008-07-23 15:59 UTC (permalink / raw) To: xen-devel Xen patchbot-unstable, le Wed 23 Jul 2008 08:50:44 -0700, a écrit : > diff -r 351ce3b94e2d -r 7299346111fb tools/libxc/xc_private.h > --- a/tools/libxc/xc_private.h Wed Jul 23 13:31:57 2008 +0100 > +++ b/tools/libxc/xc_private.h Wed Jul 23 16:39:46 2008 +0100 > @@ -184,8 +184,9 @@ static inline int do_sysctl(int xc_handl > return ret; > } > > -int xc_map_foreign_ranges(int xc_handle, uint32_t dom, > - privcmd_mmap_entry_t *entries, int nr); > +void *xc_map_foreign_ranges(int xc_handle, uint32_t dom, > + size_t size, int prot, size_t chunksize, > + privcmd_mmap_entry_t entries[], int nentries); Mmm, why chunksize? Shouldn't entries[] provide it, for a more powerful interface (each entry can have a different size)? Samuel ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [Xen-changelog] [xen-unstable] libxc: Clean up xc_map_foreign_ranges() interface to hide the 2008-07-23 15:59 ` [Xen-changelog] [xen-unstable] libxc: Clean up xc_map_foreign_ranges() interface to hide the Samuel Thibault @ 2008-07-23 16:02 ` Samuel Thibault 0 siblings, 0 replies; 2+ messages in thread From: Samuel Thibault @ 2008-07-23 16:02 UTC (permalink / raw) To: xen-devel Samuel Thibault, le Wed 23 Jul 2008 16:59:41 +0100, a écrit : > Xen patchbot-unstable, le Wed 23 Jul 2008 08:50:44 -0700, a écrit : > > diff -r 351ce3b94e2d -r 7299346111fb tools/libxc/xc_private.h > > --- a/tools/libxc/xc_private.h Wed Jul 23 13:31:57 2008 +0100 > > +++ b/tools/libxc/xc_private.h Wed Jul 23 16:39:46 2008 +0100 > > @@ -184,8 +184,9 @@ static inline int do_sysctl(int xc_handl > > return ret; > > } > > > > -int xc_map_foreign_ranges(int xc_handle, uint32_t dom, > > - privcmd_mmap_entry_t *entries, int nr); > > +void *xc_map_foreign_ranges(int xc_handle, uint32_t dom, > > + size_t size, int prot, size_t chunksize, > > + privcmd_mmap_entry_t entries[], int nentries); > > Mmm, why chunksize? Shouldn't entries[] provide it, for a more powerful > interface (each entry can have a different size)? Also, the size argument is redundant. Samuel ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-07-23 16:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <200807231550.m6NFoicJ028399@xenbits.xensource.com>
2008-07-23 15:59 ` [Xen-changelog] [xen-unstable] libxc: Clean up xc_map_foreign_ranges() interface to hide the Samuel Thibault
2008-07-23 16:02 ` Samuel Thibault
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.