* [PATCH] usb: don't hide bios bug warning
@ 2008-07-27 1:12 Yinghai Lu
2008-07-27 1:24 ` Greg KH
0 siblings, 1 reply; 5+ messages in thread
From: Yinghai Lu @ 2008-07-27 1:12 UTC (permalink / raw)
To: Greg Kroah-Hartman, Ingo Molnar, Andrew Morton; +Cc: linux-usb, linux-kernel
quirk_usb_disable_handoff will wait a while if there is BIOS bug.
let the end user know the reason for that.
Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com>
---
drivers/usb/host/pci-quirks.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
Index: linux-2.6/drivers/usb/host/pci-quirks.c
===================================================================
--- linux-2.6.orig/drivers/usb/host/pci-quirks.c
+++ linux-2.6/drivers/usb/host/pci-quirks.c
@@ -190,7 +190,8 @@ static void __devinit quirk_usb_handoff_
msleep(10);
}
if (wait_time <= 0)
- dev_warn(&pdev->dev, "OHCI: BIOS handoff failed"
+ dev_printk(KERN_WARNING, &pdev->dev,
+ "OHCI: BIOS handoff failed"
" (BIOS bug?) %08x\n",
readl(base + OHCI_CONTROL));
@@ -242,7 +243,8 @@ static void __devinit quirk_usb_disable_
switch (cap & 0xff) {
case 1: /* BIOS/SMM/... handoff support */
if ((cap & EHCI_USBLEGSUP_BIOS)) {
- dev_dbg(&pdev->dev, "EHCI: BIOS handoff\n");
+ dev_printk(KERN_DEBUG, &pdev->dev,
+ "EHCI: BIOS handoff\n");
#if 0
/* aleksey_gorelov@phoenix.com reports that some systems need SMI forced on,
@@ -283,7 +285,8 @@ static void __devinit quirk_usb_disable_
/* well, possibly buggy BIOS... try to shut
* it down, and hope nothing goes too wrong
*/
- dev_warn(&pdev->dev, "EHCI: BIOS handoff failed"
+ dev_printk(KERN_WARNING, &pdev->dev,
+ "EHCI: BIOS handoff failed"
" (BIOS bug?) %08x\n", cap);
pci_write_config_byte(pdev, offset + 2, 0);
}
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] usb: don't hide bios bug warning
2008-07-27 1:12 [PATCH] usb: don't hide bios bug warning Yinghai Lu
@ 2008-07-27 1:24 ` Greg KH
2008-07-27 1:48 ` Yinghai Lu
0 siblings, 1 reply; 5+ messages in thread
From: Greg KH @ 2008-07-27 1:24 UTC (permalink / raw)
To: Yinghai Lu; +Cc: Ingo Molnar, Andrew Morton, linux-usb, linux-kernel
On Sat, Jul 26, 2008 at 06:12:15PM -0700, Yinghai Lu wrote:
>
> quirk_usb_disable_handoff will wait a while if there is BIOS bug.
> let the end user know the reason for that.
>
> Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com>
>
> ---
> drivers/usb/host/pci-quirks.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> Index: linux-2.6/drivers/usb/host/pci-quirks.c
> ===================================================================
> --- linux-2.6.orig/drivers/usb/host/pci-quirks.c
> +++ linux-2.6/drivers/usb/host/pci-quirks.c
> @@ -190,7 +190,8 @@ static void __devinit quirk_usb_handoff_
> msleep(10);
> }
> if (wait_time <= 0)
> - dev_warn(&pdev->dev, "OHCI: BIOS handoff failed"
> + dev_printk(KERN_WARNING, &pdev->dev,
> + "OHCI: BIOS handoff failed"
This is the exact same thing here, no change.
> @@ -242,7 +243,8 @@ static void __devinit quirk_usb_disable_
> switch (cap & 0xff) {
> case 1: /* BIOS/SMM/... handoff support */
> if ((cap & EHCI_USBLEGSUP_BIOS)) {
> - dev_dbg(&pdev->dev, "EHCI: BIOS handoff\n");
> + dev_printk(KERN_DEBUG, &pdev->dev,
> + "EHCI: BIOS handoff\n");
Is this what you really want to see? But you just made things noiser.
> @@ -283,7 +285,8 @@ static void __devinit quirk_usb_disable_
> /* well, possibly buggy BIOS... try to shut
> * it down, and hope nothing goes too wrong
> */
> - dev_warn(&pdev->dev, "EHCI: BIOS handoff failed"
> + dev_printk(KERN_WARNING, &pdev->dev,
> + "EHCI: BIOS handoff failed"
This is the exact same thing, no change.
confused,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] usb: don't hide bios bug warning
2008-07-27 1:24 ` Greg KH
@ 2008-07-27 1:48 ` Yinghai Lu
2008-07-27 1:56 ` David Brownell
0 siblings, 1 reply; 5+ messages in thread
From: Yinghai Lu @ 2008-07-27 1:48 UTC (permalink / raw)
To: Greg KH; +Cc: Ingo Molnar, Andrew Morton, linux-usb, linux-kernel
On Sat, Jul 26, 2008 at 6:24 PM, Greg KH <gregkh@suse.de> wrote:
> On Sat, Jul 26, 2008 at 06:12:15PM -0700, Yinghai Lu wrote:
>>
>> quirk_usb_disable_handoff will wait a while if there is BIOS bug.
>> let the end user know the reason for that.
>>
>> Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com>
>>
>> ---
>> drivers/usb/host/pci-quirks.c | 9 ++++++---
>> 1 file changed, 6 insertions(+), 3 deletions(-)
>>
>> Index: linux-2.6/drivers/usb/host/pci-quirks.c
>> ===================================================================
>> --- linux-2.6.orig/drivers/usb/host/pci-quirks.c
>> +++ linux-2.6/drivers/usb/host/pci-quirks.c
>> @@ -190,7 +190,8 @@ static void __devinit quirk_usb_handoff_
>> msleep(10);
>> }
>> if (wait_time <= 0)
>> - dev_warn(&pdev->dev, "OHCI: BIOS handoff failed"
>> + dev_printk(KERN_WARNING, &pdev->dev,
>> + "OHCI: BIOS handoff failed"
>
> This is the exact same thing here, no change.
>
>> @@ -242,7 +243,8 @@ static void __devinit quirk_usb_disable_
>> switch (cap & 0xff) {
>> case 1: /* BIOS/SMM/... handoff support */
>> if ((cap & EHCI_USBLEGSUP_BIOS)) {
>> - dev_dbg(&pdev->dev, "EHCI: BIOS handoff\n");
>> + dev_printk(KERN_DEBUG, &pdev->dev,
>> + "EHCI: BIOS handoff\n");
>
> Is this what you really want to see? But you just made things noiser.
>
>> @@ -283,7 +285,8 @@ static void __devinit quirk_usb_disable_
>> /* well, possibly buggy BIOS... try to shut
>> * it down, and hope nothing goes too wrong
>> */
>> - dev_warn(&pdev->dev, "EHCI: BIOS handoff failed"
>> + dev_printk(KERN_WARNING, &pdev->dev,
>> + "EHCI: BIOS handoff failed"
>
> This is the exact same thing, no change.
>
> confused,
end user will not set CONFIG_USB_DEBUG, so that dev_warn will do nothing.
YH
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] usb: don't hide bios bug warning
2008-07-27 1:48 ` Yinghai Lu
@ 2008-07-27 1:56 ` David Brownell
2008-07-27 3:24 ` Yinghai Lu
0 siblings, 1 reply; 5+ messages in thread
From: David Brownell @ 2008-07-27 1:56 UTC (permalink / raw)
To: yhlu.kernel, gregkh; +Cc: mingo, linux-usb, linux-kernel, akpm
> >> - dev_warn(&pdev->dev, "EHCI: BIOS handoff failed"
> >> + dev_printk(KERN_WARNING, &pdev->dev,
> >> + "EHCI: BIOS handoff failed"
> >
> > This is the exact same thing, no change.
> >
> > confused,
>
> end user will not set CONFIG_USB_DEBUG, so that dev_warn will do nothing.
Yes it does ... KERN_WARNING != KERN_DEBUG, and it's the latter
which is toggled (via DEBUG) by CONFIG_USB_DEBUG...
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] usb: don't hide bios bug warning
2008-07-27 1:56 ` David Brownell
@ 2008-07-27 3:24 ` Yinghai Lu
0 siblings, 0 replies; 5+ messages in thread
From: Yinghai Lu @ 2008-07-27 3:24 UTC (permalink / raw)
To: David Brownell; +Cc: gregkh, mingo, linux-usb, linux-kernel, akpm
On Sat, Jul 26, 2008 at 6:56 PM, David Brownell <david-b@pacbell.net> wrote:
>> >> - dev_warn(&pdev->dev, "EHCI: BIOS handoff failed"
>> >> + dev_printk(KERN_WARNING, &pdev->dev,
>> >> + "EHCI: BIOS handoff failed"
>> >
>> > This is the exact same thing, no change.
>> >
>> > confused,
>>
>> end user will not set CONFIG_USB_DEBUG, so that dev_warn will do nothing.
>
> Yes it does ... KERN_WARNING != KERN_DEBUG, and it's the latter
> which is toggled (via DEBUG) by CONFIG_USB_DEBUG...
you are right,
please forget about the patch.
YH
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2008-07-27 3:25 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-07-27 1:12 [PATCH] usb: don't hide bios bug warning Yinghai Lu
2008-07-27 1:24 ` Greg KH
2008-07-27 1:48 ` Yinghai Lu
2008-07-27 1:56 ` David Brownell
2008-07-27 3:24 ` Yinghai Lu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.