From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: "andrzej zaborowski" <balrogg@gmail.com>, kvm@vger.kernel.org
Subject: Re: [Qemu-devel] [PATCH]: Fix i2c_bus_save, which fixes KVM live migration
Date: Tue, 29 Jul 2008 19:18:54 +0100 [thread overview]
Message-ID: <200807291918.55451.paul@codesourcery.com> (raw)
In-Reply-To: <fb249edb0807290659s2eaa6f45ue02abe5907f22128@mail.gmail.com>
On Tuesday 29 July 2008, andrzej zaborowski wrote:
> 2008/7/29 Chris Lalancette <clalance@redhat.com>:
> > Attached is a simple patch to make i2c_bus_save() put a 32-bit quantity
> > in the save file, which matches what i2c_bus_load() expects to pull out
> > of the save file later. Without this fix in place, KVM live migration
> > fails since the sender is only sending 1 byte while the receiver is
> > waiting to receive 4 bytes.
>
> Thanks, I committed this modified to use byte width afterall since the
> addresses are 7-bit quantities.
No they aren't. I2C also supports 10-bit addressing.
Paul
WARNING: multiple messages have this Message-ID (diff)
From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: kvm@vger.kernel.org
Subject: Re: [Qemu-devel] [PATCH]: Fix i2c_bus_save, which fixes KVM live migration
Date: Tue, 29 Jul 2008 19:18:54 +0100 [thread overview]
Message-ID: <200807291918.55451.paul@codesourcery.com> (raw)
In-Reply-To: <fb249edb0807290659s2eaa6f45ue02abe5907f22128@mail.gmail.com>
On Tuesday 29 July 2008, andrzej zaborowski wrote:
> 2008/7/29 Chris Lalancette <clalance@redhat.com>:
> > Attached is a simple patch to make i2c_bus_save() put a 32-bit quantity
> > in the save file, which matches what i2c_bus_load() expects to pull out
> > of the save file later. Without this fix in place, KVM live migration
> > fails since the sender is only sending 1 byte while the receiver is
> > waiting to receive 4 bytes.
>
> Thanks, I committed this modified to use byte width afterall since the
> addresses are 7-bit quantities.
No they aren't. I2C also supports 10-bit addressing.
Paul
next prev parent reply other threads:[~2008-07-29 18:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-29 6:55 [PATCH]: Fix i2c_bus_save, which fixes KVM live migration Chris Lalancette
2008-07-29 6:55 ` [Qemu-devel] " Chris Lalancette
2008-07-29 13:06 ` Avi Kivity
2008-07-29 13:06 ` [Qemu-devel] " Avi Kivity
2008-07-29 13:43 ` [Qemu-devel] " Anthony Liguori
2008-07-29 13:43 ` Anthony Liguori
2008-07-29 13:59 ` andrzej zaborowski
2008-07-29 18:18 ` Paul Brook [this message]
2008-07-29 18:18 ` Paul Brook
2008-07-29 18:35 ` andrzej zaborowski
2008-07-29 18:38 ` Anthony Liguori
2008-07-29 18:38 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200807291918.55451.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=balrogg@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.