From: Anthony Liguori <anthony@codemonkey.ws>
To: andrzej zaborowski <balrogg@gmail.com>
Cc: Paul Brook <paul@codesourcery.com>,
qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: Re: [Qemu-devel] [PATCH]: Fix i2c_bus_save, which fixes KVM live migration
Date: Tue, 29 Jul 2008 13:38:54 -0500 [thread overview]
Message-ID: <488F63BE.5060804@codemonkey.ws> (raw)
In-Reply-To: <fb249edb0807291135u64fbc9efh513622f1c74239ce@mail.gmail.com>
andrzej zaborowski wrote:
> 2008/7/29 Paul Brook <paul@codesourcery.com>:
>
>> No they aren't. I2C also supports 10-bit addressing.
>>
>
> Addresses in qemu are still <= 8-bit, for example i2c_slave_load()
> assumes this and current i2c api users do.
>
But for the save/restore format, if the spec can support 10-bit
addressing, then we should use be16s to avoid having to change
save/restore format if we ever expand the supported address size.
Regards,
Anthony Liguori
> Regards
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
WARNING: multiple messages have this Message-ID (diff)
From: Anthony Liguori <anthony@codemonkey.ws>
To: andrzej zaborowski <balrogg@gmail.com>
Cc: Paul Brook <paul@codesourcery.com>,
kvm@vger.kernel.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH]: Fix i2c_bus_save, which fixes KVM live migration
Date: Tue, 29 Jul 2008 13:38:54 -0500 [thread overview]
Message-ID: <488F63BE.5060804@codemonkey.ws> (raw)
In-Reply-To: <fb249edb0807291135u64fbc9efh513622f1c74239ce@mail.gmail.com>
andrzej zaborowski wrote:
> 2008/7/29 Paul Brook <paul@codesourcery.com>:
>
>> No they aren't. I2C also supports 10-bit addressing.
>>
>
> Addresses in qemu are still <= 8-bit, for example i2c_slave_load()
> assumes this and current i2c api users do.
>
But for the save/restore format, if the spec can support 10-bit
addressing, then we should use be16s to avoid having to change
save/restore format if we ever expand the supported address size.
Regards,
Anthony Liguori
> Regards
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2008-07-29 18:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-29 6:55 [PATCH]: Fix i2c_bus_save, which fixes KVM live migration Chris Lalancette
2008-07-29 6:55 ` [Qemu-devel] " Chris Lalancette
2008-07-29 13:06 ` Avi Kivity
2008-07-29 13:06 ` [Qemu-devel] " Avi Kivity
2008-07-29 13:43 ` [Qemu-devel] " Anthony Liguori
2008-07-29 13:43 ` Anthony Liguori
2008-07-29 13:59 ` andrzej zaborowski
2008-07-29 18:18 ` Paul Brook
2008-07-29 18:18 ` Paul Brook
2008-07-29 18:35 ` andrzej zaborowski
2008-07-29 18:38 ` Anthony Liguori [this message]
2008-07-29 18:38 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=488F63BE.5060804@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=balrogg@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.