From: Robert Millan <rmh@aybabtu.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: Current SVN is broken on x86_64
Date: Mon, 4 Aug 2008 11:16:19 +0200 [thread overview]
Message-ID: <20080804091619.GA737@thorin> (raw)
In-Reply-To: <1217809888.6283.27.camel@fz.local>
On Mon, Aug 04, 2008 at 02:31:28AM +0200, Felix Zielcke wrote:
> I just tried to compile the Debian packages with the currently SVN
> version and it failed:
>
> cc -Iloader/i386/efi -I/home/fz/grub/grub2-1.96+20080804/loader/i386/efi -I. -Iinclude -I/home/fz/grub/grub2-1.96+20080804/include -Wall -W -Wall -W -Wshadow -Wpointer-arith -Wmissing-prototypes -Wundef -Wstrict-prototypes -g -Os -m64 -fno-stack-protector -mno-stack-arg-probe -fno-builtin -m64 -MD -c -o _linux_mod-loader_i386_efi_linux.o /home/fz/grub/grub2-1.96+20080804/loader/i386/efi/linux.c
> In file included from /home/fz/grub/grub2-1.96+20080804/loader/i386/efi/linux.c:34:
> /home/fz/grub/grub2-1.96+20080804/include/grub/pci.h:48:26: error: grub/cpu/pci.h: No such file or directory
> /home/fz/grub/grub2-1.96+20080804/loader/i386/efi/linux.c: In function 'grub_find_video_card':
> /home/fz/grub/grub2-1.96+20080804/loader/i386/efi/linux.c:471: warning: implicit declaration of function 'grub_pci_read'
So we have grub/i386/pci.h but not grub/x86_64/pci.h. This is my fault, but I
think it's too easy to make mistakes with this <grub/i386/> vs <grub/x86_64/>
duplicity.
Furthermore, I had a look and some of the x86_64 versions are just stubs that
include the i386 one.
Why don't we handle this like Linux? They ship a single directory and use
#ifdefs where appropiate. That enforces consistency in the dir layout.
--
Robert Millan
The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
how) you may access your data; but nobody's threatening your freedom: we
still allow you to remove your data and not access it at all."
next prev parent reply other threads:[~2008-08-04 9:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-04 0:31 Current SVN is broken on x86_64 Felix Zielcke
2008-08-04 5:02 ` Pavel Roskin
2008-08-04 9:16 ` Robert Millan
2008-08-04 9:16 ` Robert Millan [this message]
2008-08-04 12:51 ` Pavel Roskin
2008-08-04 15:11 ` Robert Millan
2008-08-04 18:27 ` Pavel Roskin
2008-08-07 12:21 ` merging i386-efi and x86_64-efi (Re: Current SVN is broken on x86_64) Robert Millan
2008-08-07 12:25 ` Robert Millan
2008-08-04 10:09 ` Current SVN is broken on x86_64 Felix Zielcke
2008-08-07 10:58 ` Current SVN is (still ?, again ?) broken Felix Zielcke
2008-08-07 12:01 ` Bean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080804091619.GA737@thorin \
--to=rmh@aybabtu.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.