From: Divy Le Ray <divy@chelsio.com>
To: "David Miller" <davem@davemloft.net>
Cc: wangchen@cn.fujitsu.com, netdev@vger.kernel.org
Subject: Re: [PATCH]&[Question] netdevice: Use netdev_priv()
Date: Tue, 5 Aug 2008 10:51:49 -0700 [thread overview]
Message-ID: <200808051051.49824.divy@chelsio.com> (raw)
In-Reply-To: <20080805.030433.100665376.davem@davemloft.net>
On Tuesday 05 August 2008 03:04:33 am David Miller wrote:
> From: Wang Chen <wangchen@cn.fujitsu.com>
> Date: Tue, 05 Aug 2008 17:55:27 +0800
>
> > init_one() of cxgb2 makes several net_device to share one private data.
> > For this purpose, direct reference is necessary.
>
> It should use netdev->ml_priv which is created for this purpose.
>
> Every direct netdev->priv usage is a bug.
cxgb3 was fixed in this regard, cxgb2 needs the same treatment ...
cheers,
Divy
next prev parent reply other threads:[~2008-08-05 17:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-01 9:50 [PATCH]&[Question] netdevice: Use netdev_priv() Wang Chen
2008-08-01 10:08 ` David Miller
2008-08-01 10:16 ` Wang Chen
2008-08-01 10:24 ` David Miller
2008-08-01 10:35 ` Wang Chen
2008-08-01 11:05 ` David Miller
2008-08-05 9:55 ` Wang Chen
2008-08-05 10:04 ` David Miller
2008-08-05 17:51 ` Divy Le Ray [this message]
2008-08-06 4:21 ` Wang Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200808051051.49824.divy@chelsio.com \
--to=divy@chelsio.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=wangchen@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.