From: Wang Chen <wangchen@cn.fujitsu.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH]&[Question] netdevice: Use netdev_priv()
Date: Tue, 05 Aug 2008 17:55:27 +0800 [thread overview]
Message-ID: <4898238F.1050105@cn.fujitsu.com> (raw)
In-Reply-To: <20080801.040518.93393560.davem@davemloft.net>
David Miller said the following on 2008-8-1 19:05:
> From: Wang Chen <wangchen@cn.fujitsu.com>
> Date: Fri, 01 Aug 2008 18:35:24 +0800
>
>> How about add a comment to netdev->priv
>>
>> void *priv; /* pointer to private data, referent me by netdev_priv()*/
>
> Sure, but I'd much rather apply a patch that converts
> all the direct references :-)
I just checked some drivers' source.
And, maybe some direct references of net_device->priv are needed.
For example:
init_one() of cxgb2 makes several net_device to share one private data.
For this purpose, direct reference is necessary.
next prev parent reply other threads:[~2008-08-05 9:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-01 9:50 [PATCH]&[Question] netdevice: Use netdev_priv() Wang Chen
2008-08-01 10:08 ` David Miller
2008-08-01 10:16 ` Wang Chen
2008-08-01 10:24 ` David Miller
2008-08-01 10:35 ` Wang Chen
2008-08-01 11:05 ` David Miller
2008-08-05 9:55 ` Wang Chen [this message]
2008-08-05 10:04 ` David Miller
2008-08-05 17:51 ` Divy Le Ray
2008-08-06 4:21 ` Wang Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4898238F.1050105@cn.fujitsu.com \
--to=wangchen@cn.fujitsu.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.