All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wang Chen <wangchen@cn.fujitsu.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH]&[Question] netdevice: Use netdev_priv()
Date: Fri, 01 Aug 2008 18:16:32 +0800	[thread overview]
Message-ID: <4892E280.8050907@cn.fujitsu.com> (raw)
In-Reply-To: <20080801.030834.245436720.davem@davemloft.net>

David Miller said the following on 2008-8-1 18:08:
> From: Wang Chen <wangchen@cn.fujitsu.com>
> Date: Fri, 01 Aug 2008 17:50:15 +0800
> 
>> That make me think, what the use of netdev->priv?
>> We have netdev_priv() and use it flexibly. Why don't kill netdev->priv?
> 
> Way too many old drivers still reference netdev->priv directly.
> 
> Once we convert all of them to netdev_priv(), yes we can kill
> netdev->priv
> 

Thanks for the explanation.

Then next question comes.
We *have to* convert the drivers to use netdev_priv(), right?
Because, netdev->priv == netdev_priv() maybe change again in future,
just as before.


  reply	other threads:[~2008-08-01 10:18 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-01  9:50 [PATCH]&[Question] netdevice: Use netdev_priv() Wang Chen
2008-08-01 10:08 ` David Miller
2008-08-01 10:16   ` Wang Chen [this message]
2008-08-01 10:24     ` David Miller
2008-08-01 10:35       ` Wang Chen
2008-08-01 11:05         ` David Miller
2008-08-05  9:55           ` Wang Chen
2008-08-05 10:04             ` David Miller
2008-08-05 17:51               ` Divy Le Ray
2008-08-06  4:21                 ` Wang Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4892E280.8050907@cn.fujitsu.com \
    --to=wangchen@cn.fujitsu.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.