From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: dccp@vger.kernel.org
Subject: [PATCH] dccp: change L/R must have at least one byte in the
Date: Wed, 13 Aug 2008 12:55:32 +0000 [thread overview]
Message-ID: <20080813125532.GD12888@ghostprotocols.net> (raw)
Hi David, Gerrit,
Please consider applying.
- Arnaldo
dccp: change L/R must have at least one byte in the dccpsf_val field
Thanks to Eugene Teo for reporting this problem.
Signed-off-by: Eugene Teo <eugenete@kernel.sg>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
diff --git a/net/dccp/proto.c b/net/dccp/proto.c
index b622d97..1ca3b26 100644
--- a/net/dccp/proto.c
+++ b/net/dccp/proto.c
@@ -474,6 +474,11 @@ static int dccp_setsockopt_change(struct sock *sk, int type,
if (copy_from_user(&opt, optval, sizeof(opt)))
return -EFAULT;
+ /*
+ * rfc4340: 6.1. Change Options
+ */
+ if (opt.dccpsf_len < 1)
+ return -EINVAL;
val = kmalloc(opt.dccpsf_len, GFP_KERNEL);
if (!val)
WARNING: multiple messages have this Message-ID (diff)
From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: "David S. Miller" <davem@davemloft.net>,
Gerrit Renker <gerrit@erg.abdn.ac.uk>
Cc: netdev@vger.kernel.org, dccp@vger.kernel.org
Subject: [PATCH] dccp: change L/R must have at least one byte in the dccpsf_val field
Date: Wed, 13 Aug 2008 09:55:32 -0300 [thread overview]
Message-ID: <20080813125532.GD12888@ghostprotocols.net> (raw)
Hi David, Gerrit,
Please consider applying.
- Arnaldo
dccp: change L/R must have at least one byte in the dccpsf_val field
Thanks to Eugene Teo for reporting this problem.
Signed-off-by: Eugene Teo <eugenete@kernel.sg>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
diff --git a/net/dccp/proto.c b/net/dccp/proto.c
index b622d97..1ca3b26 100644
--- a/net/dccp/proto.c
+++ b/net/dccp/proto.c
@@ -474,6 +474,11 @@ static int dccp_setsockopt_change(struct sock *sk, int type,
if (copy_from_user(&opt, optval, sizeof(opt)))
return -EFAULT;
+ /*
+ * rfc4340: 6.1. Change Options
+ */
+ if (opt.dccpsf_len < 1)
+ return -EINVAL;
val = kmalloc(opt.dccpsf_len, GFP_KERNEL);
if (!val)
next reply other threads:[~2008-08-13 12:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-13 12:55 Arnaldo Carvalho de Melo [this message]
2008-08-13 12:55 ` [PATCH] dccp: change L/R must have at least one byte in the dccpsf_val field Arnaldo Carvalho de Melo
2008-08-13 15:04 ` [PATCH] dccp: change L/R must have at least one byte in the gerrit
2008-08-13 15:04 ` [PATCH] dccp: change L/R must have at least one byte in the dccpsf_val field gerrit
2008-08-13 20:49 ` [PATCH] dccp: change L/R must have at least one byte in the David Miller
2008-08-13 20:49 ` [PATCH] dccp: change L/R must have at least one byte in the dccpsf_val field David Miller
2008-08-14 1:08 ` Eugene Teo
2008-08-14 1:08 ` Eugene Teo
2008-08-14 1:12 ` [PATCH] dccp: change L/R must have at least one byte in the David Miller
2008-08-14 1:12 ` [PATCH] dccp: change L/R must have at least one byte in the dccpsf_val field David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080813125532.GD12888@ghostprotocols.net \
--to=acme@redhat.com \
--cc=dccp@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.