* [PATCH] dccp: change L/R must have at least one byte in the
@ 2008-08-13 12:55 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 10+ messages in thread
From: Arnaldo Carvalho de Melo @ 2008-08-13 12:55 UTC (permalink / raw)
To: dccp
Hi David, Gerrit,
Please consider applying.
- Arnaldo
dccp: change L/R must have at least one byte in the dccpsf_val field
Thanks to Eugene Teo for reporting this problem.
Signed-off-by: Eugene Teo <eugenete@kernel.sg>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
diff --git a/net/dccp/proto.c b/net/dccp/proto.c
index b622d97..1ca3b26 100644
--- a/net/dccp/proto.c
+++ b/net/dccp/proto.c
@@ -474,6 +474,11 @@ static int dccp_setsockopt_change(struct sock *sk, int type,
if (copy_from_user(&opt, optval, sizeof(opt)))
return -EFAULT;
+ /*
+ * rfc4340: 6.1. Change Options
+ */
+ if (opt.dccpsf_len < 1)
+ return -EINVAL;
val = kmalloc(opt.dccpsf_len, GFP_KERNEL);
if (!val)
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH] dccp: change L/R must have at least one byte in the dccpsf_val field
@ 2008-08-13 12:55 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 10+ messages in thread
From: Arnaldo Carvalho de Melo @ 2008-08-13 12:55 UTC (permalink / raw)
To: David S. Miller, Gerrit Renker; +Cc: netdev, dccp
Hi David, Gerrit,
Please consider applying.
- Arnaldo
dccp: change L/R must have at least one byte in the dccpsf_val field
Thanks to Eugene Teo for reporting this problem.
Signed-off-by: Eugene Teo <eugenete@kernel.sg>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
diff --git a/net/dccp/proto.c b/net/dccp/proto.c
index b622d97..1ca3b26 100644
--- a/net/dccp/proto.c
+++ b/net/dccp/proto.c
@@ -474,6 +474,11 @@ static int dccp_setsockopt_change(struct sock *sk, int type,
if (copy_from_user(&opt, optval, sizeof(opt)))
return -EFAULT;
+ /*
+ * rfc4340: 6.1. Change Options
+ */
+ if (opt.dccpsf_len < 1)
+ return -EINVAL;
val = kmalloc(opt.dccpsf_len, GFP_KERNEL);
if (!val)
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] dccp: change L/R must have at least one byte in the
2008-08-13 12:55 ` [PATCH] dccp: change L/R must have at least one byte in the dccpsf_val field Arnaldo Carvalho de Melo
@ 2008-08-13 15:04 ` gerrit
-1 siblings, 0 replies; 10+ messages in thread
From: gerrit @ 2008-08-13 15:04 UTC (permalink / raw)
To: dccp
> dccp: change L/R must have at least one byte in the dccpsf_val field
>
> Thanks to Eugene Teo for reporting this problem.
>
> Signed-off-by: Eugene Teo <eugenete@kernel.sg>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Gerrit Renker <gerrit@erg.abdn.ac.uk>
Dave, can you please apply -- this patch is for mainline only.
The dccp_setsockopt_change() function has been fully removed in the
test tree (
http://eden-feed.erg.abdn.ac.uk/cgi-bin/gitweb.cgi?pÜcp_exp.git;a=commitdiff;hñb8d02c7cb03e22037e1590d04f9ec8ab2423eb),
due to problems it caused.
Will be in contact regarding this soon.
Gerrit
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] dccp: change L/R must have at least one byte in the dccpsf_val field
@ 2008-08-13 15:04 ` gerrit
0 siblings, 0 replies; 10+ messages in thread
From: gerrit @ 2008-08-13 15:04 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo; +Cc: David S. Miller, Gerrit Renker, netdev, dccp
> dccp: change L/R must have at least one byte in the dccpsf_val field
>
> Thanks to Eugene Teo for reporting this problem.
>
> Signed-off-by: Eugene Teo <eugenete@kernel.sg>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Gerrit Renker <gerrit@erg.abdn.ac.uk>
Dave, can you please apply -- this patch is for mainline only.
The dccp_setsockopt_change() function has been fully removed in the
test tree (
http://eden-feed.erg.abdn.ac.uk/cgi-bin/gitweb.cgi?p=dccp_exp.git;a=commitdiff;h=f1b8d02c7cb03e22037e1590d04f9ec8ab2423eb),
due to problems it caused.
Will be in contact regarding this soon.
Gerrit
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] dccp: change L/R must have at least one byte in the
2008-08-13 15:04 ` [PATCH] dccp: change L/R must have at least one byte in the dccpsf_val field gerrit
@ 2008-08-13 20:49 ` David Miller
-1 siblings, 0 replies; 10+ messages in thread
From: David Miller @ 2008-08-13 20:49 UTC (permalink / raw)
To: dccp
From: gerrit@erg.abdn.ac.uk
Date: Wed, 13 Aug 2008 16:04:03 +0100 (BST)
> > dccp: change L/R must have at least one byte in the dccpsf_val field
> >
> > Thanks to Eugene Teo for reporting this problem.
> >
> > Signed-off-by: Eugene Teo <eugenete@kernel.sg>
> > Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> Signed-off-by: Gerrit Renker <gerrit@erg.abdn.ac.uk>
>
> Dave, can you please apply -- this patch is for mainline only.
Applied and I'll queue this up for -stable too, thanks everyone.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] dccp: change L/R must have at least one byte in the dccpsf_val field
@ 2008-08-13 20:49 ` David Miller
0 siblings, 0 replies; 10+ messages in thread
From: David Miller @ 2008-08-13 20:49 UTC (permalink / raw)
To: gerrit; +Cc: acme, netdev, dccp
From: gerrit@erg.abdn.ac.uk
Date: Wed, 13 Aug 2008 16:04:03 +0100 (BST)
> > dccp: change L/R must have at least one byte in the dccpsf_val field
> >
> > Thanks to Eugene Teo for reporting this problem.
> >
> > Signed-off-by: Eugene Teo <eugenete@kernel.sg>
> > Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> Signed-off-by: Gerrit Renker <gerrit@erg.abdn.ac.uk>
>
> Dave, can you please apply -- this patch is for mainline only.
Applied and I'll queue this up for -stable too, thanks everyone.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] dccp: change L/R must have at least one byte in the dccpsf_val field
2008-08-13 12:55 ` [PATCH] dccp: change L/R must have at least one byte in the dccpsf_val field Arnaldo Carvalho de Melo
@ 2008-08-14 1:08 ` Eugene Teo
-1 siblings, 0 replies; 10+ messages in thread
From: Eugene Teo @ 2008-08-14 1:08 UTC (permalink / raw)
To: dccp
On Wed, Aug 13, 2008 at 8:55 PM, Arnaldo Carvalho de Melo
<acme@redhat.com> wrote:
> Hi David, Gerrit,
>
> Please consider applying.
>
> - Arnaldo
>
> dccp: change L/R must have at least one byte in the dccpsf_val field
>
> Thanks to Eugene Teo for reporting this problem.
>
> Signed-off-by: Eugene Teo <eugenete@kernel.sg>
Should be eugeneteo@ instead of eugenete. Thanks.
Eugene
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] dccp: change L/R must have at least one byte in the dccpsf_val field
@ 2008-08-14 1:08 ` Eugene Teo
0 siblings, 0 replies; 10+ messages in thread
From: Eugene Teo @ 2008-08-14 1:08 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo, David S. Miller, Gerrit Renker, netdev,
dccp
On Wed, Aug 13, 2008 at 8:55 PM, Arnaldo Carvalho de Melo
<acme@redhat.com> wrote:
> Hi David, Gerrit,
>
> Please consider applying.
>
> - Arnaldo
>
> dccp: change L/R must have at least one byte in the dccpsf_val field
>
> Thanks to Eugene Teo for reporting this problem.
>
> Signed-off-by: Eugene Teo <eugenete@kernel.sg>
Should be eugeneteo@ instead of eugenete. Thanks.
Eugene
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] dccp: change L/R must have at least one byte in the
2008-08-14 1:08 ` Eugene Teo
@ 2008-08-14 1:12 ` David Miller
-1 siblings, 0 replies; 10+ messages in thread
From: David Miller @ 2008-08-14 1:12 UTC (permalink / raw)
To: dccp
From: "Eugene Teo" <eugeneteo@kernel.sg>
Date: Thu, 14 Aug 2008 09:08:56 +0800
> On Wed, Aug 13, 2008 at 8:55 PM, Arnaldo Carvalho de Melo
> <acme@redhat.com> wrote:
> > Hi David, Gerrit,
> >
> > Please consider applying.
> >
> > - Arnaldo
> >
> > dccp: change L/R must have at least one byte in the dccpsf_val field
> >
> > Thanks to Eugene Teo for reporting this problem.
> >
> > Signed-off-by: Eugene Teo <eugenete@kernel.sg>
>
> Should be eugeneteo@ instead of eugenete. Thanks.
I'll fix this up for the -stable submission, this version
is already in my net-2.6 tree and on the way to Linus.
Thanks.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] dccp: change L/R must have at least one byte in the dccpsf_val field
@ 2008-08-14 1:12 ` David Miller
0 siblings, 0 replies; 10+ messages in thread
From: David Miller @ 2008-08-14 1:12 UTC (permalink / raw)
To: eugeneteo; +Cc: acme, gerrit, netdev, dccp
From: "Eugene Teo" <eugeneteo@kernel.sg>
Date: Thu, 14 Aug 2008 09:08:56 +0800
> On Wed, Aug 13, 2008 at 8:55 PM, Arnaldo Carvalho de Melo
> <acme@redhat.com> wrote:
> > Hi David, Gerrit,
> >
> > Please consider applying.
> >
> > - Arnaldo
> >
> > dccp: change L/R must have at least one byte in the dccpsf_val field
> >
> > Thanks to Eugene Teo for reporting this problem.
> >
> > Signed-off-by: Eugene Teo <eugenete@kernel.sg>
>
> Should be eugeneteo@ instead of eugenete. Thanks.
I'll fix this up for the -stable submission, this version
is already in my net-2.6 tree and on the way to Linus.
Thanks.
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2008-08-14 1:12 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-08-13 12:55 [PATCH] dccp: change L/R must have at least one byte in the Arnaldo Carvalho de Melo
2008-08-13 12:55 ` [PATCH] dccp: change L/R must have at least one byte in the dccpsf_val field Arnaldo Carvalho de Melo
2008-08-13 15:04 ` [PATCH] dccp: change L/R must have at least one byte in the gerrit
2008-08-13 15:04 ` [PATCH] dccp: change L/R must have at least one byte in the dccpsf_val field gerrit
2008-08-13 20:49 ` [PATCH] dccp: change L/R must have at least one byte in the David Miller
2008-08-13 20:49 ` [PATCH] dccp: change L/R must have at least one byte in the dccpsf_val field David Miller
2008-08-14 1:08 ` Eugene Teo
2008-08-14 1:08 ` Eugene Teo
2008-08-14 1:12 ` [PATCH] dccp: change L/R must have at least one byte in the David Miller
2008-08-14 1:12 ` [PATCH] dccp: change L/R must have at least one byte in the dccpsf_val field David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.