From: Robert Millan <rmh@aybabtu.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] Replace magic numbers by constants
Date: Sun, 17 Aug 2008 17:37:19 +0200 [thread overview]
Message-ID: <20080817153719.GC9696@thorin> (raw)
In-Reply-To: <20080817142916.GB28198@pina.cat>
On Sun, Aug 17, 2008 at 04:29:16PM +0200, Carles Pina i Estany wrote:
> 2008-08-17 Carles Pina i Estany <carles@pina.cat>
>
> * menu/normal.c (run_menu): Change magic numbers by constants
> (16 by GRUB_TERM_UP and 14 by GRUB_TERM_DOWN)
When reading the subject I thought it was the other way around. Would
something like:
"replace hardcoded numbers with macros"
or
"macroify numbers"
etc, make it more clear?
--
Robert Millan
The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
how) you may access your data; but nobody's threatening your freedom: we
still allow you to remove your data and not access it at all."
next prev parent reply other threads:[~2008-08-17 15:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-17 13:01 [PATCH] Replace magic numbers by constants Carles Pina i Estany
2008-08-17 14:12 ` Marco Gerards
2008-08-17 14:29 ` Carles Pina i Estany
2008-08-17 15:37 ` Robert Millan [this message]
2008-08-17 19:11 ` Carles Pina i Estany
2008-08-20 9:26 ` Carles Pina i Estany
2008-08-20 10:08 ` Robert Millan
2008-08-20 10:51 ` Carles Pina i Estany
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080817153719.GC9696@thorin \
--to=rmh@aybabtu.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.